[INFO] fetching crate suspend-core 0.1.0... [INFO] checking suspend-core-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate suspend-core 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate suspend-core 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate suspend-core 0.1.0 [INFO] finished tweaking crates.io crate suspend-core 0.1.0 [INFO] tweaked toml for crates.io crate suspend-core 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding matchers v0.0.1 (latest: v0.2.0) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding tracing-log v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding tracing-subscriber v0.2.25 (latest: v0.3.18) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7aff670bca63d4e2f100b31c8867803ae201283fbc77f37a99a5a5825a59ef1b [INFO] running `Command { std: "docker" "start" "-a" "7aff670bca63d4e2f100b31c8867803ae201283fbc77f37a99a5a5825a59ef1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7aff670bca63d4e2f100b31c8867803ae201283fbc77f37a99a5a5825a59ef1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7aff670bca63d4e2f100b31c8867803ae201283fbc77f37a99a5a5825a59ef1b", kill_on_drop: false }` [INFO] [stdout] 7aff670bca63d4e2f100b31c8867803ae201283fbc77f37a99a5a5825a59ef1b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6012c3b513077e835e1ae9f2f2fece349a39dd71e322ed699bbcb0835d279cf2 [INFO] running `Command { std: "docker" "start" "-a" "6012c3b513077e835e1ae9f2f2fece349a39dd71e322ed699bbcb0835d279cf2", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking suspend-core v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listen.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn park_thread<'s>(f: impl FnOnce(Notifier), timeout: impl Expiry) -> bool { [INFO] [stdout] | ------------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let timeout: Option = timeout.into_expire(); [INFO] [stdout] 74 | with_listener(|guard, _waker| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 75 | | f(guard.notifier()); [INFO] [stdout] 76 | | guard.wait(timeout).unwrap() [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listen.rs:81:24 [INFO] [stdout] | [INFO] [stdout] 80 | fn with_listener(f: impl FnOnce(&mut ListenerGuard<'_>, &Waker) -> T) -> T { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | THREAD_LISTEN.with(|cached| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 82 | | if let Ok(mut borrowed) = cached.try_borrow_mut() { [INFO] [stdout] 83 | | let (listen, waker) = &mut *borrowed; [INFO] [stdout] 84 | | let mut guard = listen.lock_mut(); [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/listen.rs:229:22 [INFO] [stdout] | [INFO] [stdout] 229 | unsafe { Box::from_raw(self as *const _ as *mut Self) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 229 | unsafe { let _ = Box::from_raw(self as *const _ as *mut Self); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listen.rs:249:20 [INFO] [stdout] | [INFO] [stdout] 247 | pub(crate) fn new(guard: Guard<'s, NativeLock>, inner: NonNull) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | Self { [INFO] [stdout] 249 | guard: Some(guard), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `suspend-core` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6012c3b513077e835e1ae9f2f2fece349a39dd71e322ed699bbcb0835d279cf2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6012c3b513077e835e1ae9f2f2fece349a39dd71e322ed699bbcb0835d279cf2", kill_on_drop: false }` [INFO] [stdout] 6012c3b513077e835e1ae9f2f2fece349a39dd71e322ed699bbcb0835d279cf2