[INFO] fetching crate surrealkv 0.3.4... [INFO] checking surrealkv-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate surrealkv 0.3.4 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate surrealkv 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate surrealkv 0.3.4 [INFO] finished tweaking crates.io crate surrealkv 0.3.4 [INFO] tweaked toml for crates.io crate surrealkv 0.3.4 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 192 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding fs4 v0.6.6 (latest: v0.9.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parse-display v0.8.2 (latest: v0.10.0) [INFO] [stderr] Adding parse-display-derive v0.8.2 (latest: v0.10.0) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding regex-syntax v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding remove_dir_all v0.5.3 (latest: v0.8.3) [INFO] [stderr] Adding revision v0.7.1 (latest: v0.10.0) [INFO] [stderr] Adding revision-derive v0.7.0 (latest: v0.10.0) [INFO] [stderr] Adding structmeta v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding structmeta-derive v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5b6b62e6c73a4a09f472442924033321d6a373e372b1fe96142969402fb5c528 [INFO] running `Command { std: "docker" "start" "-a" "5b6b62e6c73a4a09f472442924033321d6a373e372b1fe96142969402fb5c528", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5b6b62e6c73a4a09f472442924033321d6a373e372b1fe96142969402fb5c528", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b6b62e6c73a4a09f472442924033321d6a373e372b1fe96142969402fb5c528", kill_on_drop: false }` [INFO] [stdout] 5b6b62e6c73a4a09f472442924033321d6a373e372b1fe96142969402fb5c528 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aab1b08cba9ecc03477b793b047c0a6d085fe1ca618d99fe6e517e354b3d25a8 [INFO] running `Command { std: "docker" "start" "-a" "aab1b08cba9ecc03477b793b047c0a6d085fe1ca618d99fe6e517e354b3d25a8", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling libmimalloc-sys v0.1.39 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking mimalloc v0.1.43 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking fs4 v0.6.6 [INFO] [stderr] Checking memmapix v0.7.6 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling structmeta-derive v0.2.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling structmeta v0.2.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling parse-display-derive v0.8.2 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling revision-derive v0.7.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking parse-display v0.8.2 [INFO] [stderr] Checking fmmap v0.3.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking quick_cache v0.6.6 [INFO] [stderr] Checking vart v0.4.0 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking nanoid v0.4.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking revision v0.7.1 [INFO] [stderr] Checking surrealkv v0.3.4 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/entry.rs:302:20 [INFO] [stdout] | [INFO] [stdout] 295 | pub(crate) fn new(store: Arc) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | value: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/entry.rs:303:23 [INFO] [stdout] | [INFO] [stdout] 295 | pub(crate) fn new(store: Arc) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | metadata: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/error.rs:122:24 [INFO] [stdout] | [INFO] [stdout] 121 | fn from(e: io::Error) -> Error { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | Error::IoError(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/meta.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 121 | let mut attributes = HashSet::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(Metadata { attributes }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/oracle.rs:428:18 [INFO] [stdout] | [INFO] [stdout] 427 | let (tx, rx) = bounded(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 429 | | ch: Mutex::new(Some(tx)), [INFO] [stdout] 430 | | closer: rx, [INFO] [stdout] 431 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/reader.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) fn new_from(rdr: MultiSegmentReader) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Reader { rdr, err: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/reader.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 131 | pub(crate) fn new(r: Reader, max_key_size: u64, max_value_size: u64) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | err: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/snapshot.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub(crate) fn take(store: Arc, start_ts: u64) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let snapshot = store.indexer.write().snapshot(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | start_ts, [INFO] [stdout] 36 | | snap: snapshot, [INFO] [stdout] 37 | | store, [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/snapshot.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 65 | let mut val_ref = ValueRef::new(self.store.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(Box::new(val_ref)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/store.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 57 | let (writes_tx, writes_rx) = bounded(10000); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let (stop_tx, stop_rx) = bounded(1); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | let core = Arc::new(Core::new(opts, writes_tx)?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let task_runner_handle = TaskRunner::new(core.clone(), writes_rx, stop_rx).spawn(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | core, [INFO] [stdout] 65 | | stop_tx, [INFO] [stdout] 66 | | is_closed: AtomicBool::new(false), [INFO] [stdout] ... | [INFO] [stdout] 69 | | stats: Arc::new(StorageStats::new()), [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/store.rs:222:15 [INFO] [stdout] | [INFO] [stdout] 221 | fn spawn(self) -> JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | spawn(Box::pin(async move { [INFO] [stdout] | _______________^ [INFO] [stdout] 223 | | loop { [INFO] [stdout] 224 | | select! { [INFO] [stdout] 225 | | req = self.writes_rx.recv().fuse() => { [INFO] [stdout] ... | [INFO] [stdout] 238 | | } [INFO] [stdout] 239 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/store.rs:365:12 [INFO] [stdout] | [INFO] [stdout] 329 | pub fn new(opts: Options, writes_tx: Sender) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | // Initialize a new Indexer with the provided options. [INFO] [stdout] 331 | let mut indexer = Self::initialize_indexer(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | [INFO] [stdout] 333 | let mut manifest = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 334 | let mut clog = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 357 | let oracle = Oracle::new(&opts); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | let value_cache = Cache::new(opts.max_value_cache_size as usize); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 366 | | indexer: RwLock::new(indexer), [INFO] [stdout] 367 | | opts, [INFO] [stdout] 368 | | manifest: manifest.map(RwLock::new), [INFO] [stdout] ... | [INFO] [stdout] 373 | | writes_tx, [INFO] [stdout] 374 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/store.rs:369:41 [INFO] [stdout] | [INFO] [stdout] 369 | clog: clog.map(|c| Arc::new(RwLock::new(c))), [INFO] [stdout] | - ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/transaction.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn new(core: Arc, mode: Mode) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let mut snapshot = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | read_ts, [INFO] [stdout] 132 | | mode, [INFO] [stdout] 133 | | snapshot, [INFO] [stdout] ... | [INFO] [stdout] 142 | | closed: false, [INFO] [stdout] 143 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/kv/transaction.rs:210:15 [INFO] [stdout] | [INFO] [stdout] 206 | let key = Bytes::copy_from_slice(key); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let hashed_key = sha256(key.clone()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | match self.snapshot.as_ref().unwrap().read().get(&key[..].into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log/mod.rs:705:12 [INFO] [stdout] | [INFO] [stdout] 676 | let mut file = Self::open_file(&file_path, opts)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 705 | Ok(Segment { [INFO] [stdout] | ____________^ [INFO] [stdout] 706 | | file, [INFO] [stdout] 707 | | file_header_offset: file_header_offset as u64, [INFO] [stdout] 708 | | file_offset: file_offset - file_header_offset as u64, [INFO] [stdout] ... | [INFO] [stdout] 712 | | file_size: opts.max_file_size, [INFO] [stdout] 713 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log/mod.rs:991:12 [INFO] [stdout] | [INFO] [stdout] 986 | let mut file = File::open(&segments[cur].file_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 989 | let buf = BufReader::with_capacity(READ_BUF_SIZE, file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 990 | [INFO] [stdout] 991 | Ok(MultiSegmentReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 992 | | buf, [INFO] [stdout] 993 | | segments, [INFO] [stdout] 994 | | cur, [INFO] [stdout] 995 | | off, [INFO] [stdout] 996 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log/aol.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 61 | let active_segment = Segment::open(dir, active_segment_id, opts)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let cache = LruCache::new(NonZeroUsize::new(opts.max_open_files).unwrap()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | active_segment, [INFO] [stdout] 69 | | active_segment_id, [INFO] [stdout] 70 | | dir: dir.to_path_buf(), [INFO] [stdout] ... | [INFO] [stdout] 75 | | fsync_failed: Default::default(), [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `surrealkv` (lib) due to 19 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "aab1b08cba9ecc03477b793b047c0a6d085fe1ca618d99fe6e517e354b3d25a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aab1b08cba9ecc03477b793b047c0a6d085fe1ca618d99fe6e517e354b3d25a8", kill_on_drop: false }` [INFO] [stdout] aab1b08cba9ecc03477b793b047c0a6d085fe1ca618d99fe6e517e354b3d25a8