[INFO] fetching crate surprise-me-derive 0.1.0... [INFO] checking surprise-me-derive-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate surprise-me-derive 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate surprise-me-derive 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate surprise-me-derive 0.1.0 [INFO] finished tweaking crates.io crate surprise-me-derive 0.1.0 [INFO] tweaked toml for crates.io crate surprise-me-derive 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dd7c73fafc2a9b4ce1635718dfa76f0f009d63a9d15a7c198e2eb78641b81b17 [INFO] running `Command { std: "docker" "start" "-a" "dd7c73fafc2a9b4ce1635718dfa76f0f009d63a9d15a7c198e2eb78641b81b17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dd7c73fafc2a9b4ce1635718dfa76f0f009d63a9d15a7c198e2eb78641b81b17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd7c73fafc2a9b4ce1635718dfa76f0f009d63a9d15a7c198e2eb78641b81b17", kill_on_drop: false }` [INFO] [stdout] dd7c73fafc2a9b4ce1635718dfa76f0f009d63a9d15a7c198e2eb78641b81b17 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 13367d30809d1226211aa7bcf973effc243d4a05aa7b2ed00c99cf84a8ac8266 [INFO] running `Command { std: "docker" "start" "-a" "13367d30809d1226211aa7bcf973effc243d4a05aa7b2ed00c99cf84a8ac8266", kill_on_drop: false }` [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking surprise-me-derive v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn surprise(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let name = input.ident.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | match impl_surprise(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/factor.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | predicates: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn surprise(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let name = input.ident.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | match impl_surprise(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/factor.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | predicates: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/factor.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 51 | vis: Visibility, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | name: &Ident, [INFO] [stdout] 53 | mut where_clause: WhereClause, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | mut data: DataStruct, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | ) -> Result { [INFO] [stdout] 56 | let distribution_body = match data.fields { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Fields::Named(ref fields) => { [INFO] [stdout] 58 | let fields = fields [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | / quote! { [INFO] [stdout] 89 | | #[allow(clippy::needless_borrow)] [INFO] [stdout] 90 | | #name { #( #fields ,)* } [INFO] [stdout] | | ------ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | | let fields = fields [INFO] [stdout] | | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 122 | / quote! { [INFO] [stdout] 123 | | #[allow(clippy::needless_borrow)] [INFO] [stdout] 124 | | #name ( #( #fields ),* ) [INFO] [stdout] | | ------ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | } [INFO] [stdout] 127 | | Fields::Unit => quote!(#name), [INFO] [stdout] | | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 130 | | let default_struct = match data.fields { [INFO] [stdout] | | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | | Fields::Named(ref fields) => { [INFO] [stdout] 132 | | let fields = fields.named.iter().map(|field| field.ident.as_ref()); [INFO] [stdout] | | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | | [INFO] [stdout] 134 | / quote! { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | #( #fields: Default::default(), )* [INFO] [stdout] | | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | | } [INFO] [stdout] 138 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | | let fields = fields.unnamed.iter().map(|_| quote!(Default::default())); [INFO] [stdout] | | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | | [INFO] [stdout] 143 | / quote! { [INFO] [stdout] 144 | | Self( #( #fields, )* ) [INFO] [stdout] | | ------ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | } [INFO] [stdout] 147 | | Fields::Unit => quote!(Self), [INFO] [stdout] | | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 150 | | let mut default_assigns = Punctuated::new(); [INFO] [stdout] | | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 205 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 206 | semi_token: data.semi_token, [INFO] [stdout] 207 | vis, [INFO] [stdout] 208 | fields: data.fields, [INFO] [stdout] ... [INFO] [stdout] 212 | default_where_clause: (!where_clause.predicates.is_empty()).then_some(where_clause), [INFO] [stdout] 213 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/factor.rs:509:12 [INFO] [stdout] | [INFO] [stdout] 217 | vis: Visibility, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | name: &Ident, [INFO] [stdout] 219 | mut where_clause: WhereClause, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | data: DataEnum, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let mut named_fields = Punctuated::::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | let mut factor_match_arms = Arms::default(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let mut default_assigns = Punctuated::::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let mut variants_weight = Punctuated::::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 476 | let default_fields = named_fields.iter().skip(1).map(|field| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | let default_struct = quote! { [INFO] [stdout] | _____________--------------___- [INFO] [stdout] | |_____________|________________| [INFO] [stdout] | |_____________|________________| [INFO] [stdout] | |_____________|________________| [INFO] [stdout] | |_____________|________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 483 | | Self { [INFO] [stdout] 484 | | variants_weight: Box::new([ #variants_weight ]), [INFO] [stdout] 485 | | #( #default_fields ,)* [INFO] [stdout] | | -------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | | } [INFO] [stdout] 487 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 488 | [INFO] [stdout] 489 | | let named_fields = FieldsNamed { [INFO] [stdout] | | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 494 | let distribution_body = quote! { [INFO] [stdout] | _____________-----------------___- [INFO] [stdout] | |_____________|___________________| [INFO] [stdout] | |_____________|___________________| [INFO] [stdout] | |_____________|___________________| [INFO] [stdout] | |_____________|___________________| [INFO] [stdout] | |_____________|___________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | | let weights = self.variants_weight.as_ref(); [INFO] [stdout] 496 | | let weighted_idx = ::surprise_me::rand::distributions::WeightedIndex::new(weights).unwrap(); [INFO] [stdout] 497 | | let idx = rng.sample(weighted_idx); [INFO] [stdout] ... | [INFO] [stdout] 502 | | } [INFO] [stdout] 503 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 509 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 510 | semi_token: None, [INFO] [stdout] 511 | vis, [INFO] [stdout] 512 | fields: Fields::Named(named_fields), [INFO] [stdout] ... [INFO] [stdout] 516 | default_where_clause: (!where_clause.predicates.is_empty()).then_some(where_clause), [INFO] [stdout] 517 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/factor.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 51 | vis: Visibility, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | name: &Ident, [INFO] [stdout] 53 | mut where_clause: WhereClause, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | mut data: DataStruct, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | ) -> Result { [INFO] [stdout] 56 | let distribution_body = match data.fields { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Fields::Named(ref fields) => { [INFO] [stdout] 58 | let fields = fields [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | / quote! { [INFO] [stdout] 89 | | #[allow(clippy::needless_borrow)] [INFO] [stdout] 90 | | #name { #( #fields ,)* } [INFO] [stdout] | | ------ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | | let fields = fields [INFO] [stdout] | | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 122 | / quote! { [INFO] [stdout] 123 | | #[allow(clippy::needless_borrow)] [INFO] [stdout] 124 | | #name ( #( #fields ),* ) [INFO] [stdout] | | ------ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | } [INFO] [stdout] 127 | | Fields::Unit => quote!(#name), [INFO] [stdout] | | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 130 | | let default_struct = match data.fields { [INFO] [stdout] | | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | | Fields::Named(ref fields) => { [INFO] [stdout] 132 | | let fields = fields.named.iter().map(|field| field.ident.as_ref()); [INFO] [stdout] | | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | | [INFO] [stdout] 134 | / quote! { [INFO] [stdout] 135 | | Self { [INFO] [stdout] 136 | | #( #fields: Default::default(), )* [INFO] [stdout] | | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | | } [INFO] [stdout] 138 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | | let fields = fields.unnamed.iter().map(|_| quote!(Default::default())); [INFO] [stdout] | | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | | [INFO] [stdout] 143 | / quote! { [INFO] [stdout] 144 | | Self( #( #fields, )* ) [INFO] [stdout] | | ------ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | } [INFO] [stdout] 147 | | Fields::Unit => quote!(Self), [INFO] [stdout] | | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 150 | | let mut default_assigns = Punctuated::new(); [INFO] [stdout] | | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 205 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 206 | semi_token: data.semi_token, [INFO] [stdout] 207 | vis, [INFO] [stdout] 208 | fields: data.fields, [INFO] [stdout] ... [INFO] [stdout] 212 | default_where_clause: (!where_clause.predicates.is_empty()).then_some(where_clause), [INFO] [stdout] 213 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/surprise.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn impl_surprise(input: DeriveInput) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | SurpriseImpl::new(input).map(|surprise_impl| quote!(#surprise_impl)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 16 | let factor = find_custom_factor(attrs)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(CustomSurpriseFactor(factor)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/factor.rs:509:12 [INFO] [stdout] | [INFO] [stdout] 217 | vis: Visibility, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | name: &Ident, [INFO] [stdout] 219 | mut where_clause: WhereClause, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | data: DataEnum, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let mut named_fields = Punctuated::::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | let mut factor_match_arms = Arms::default(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let mut default_assigns = Punctuated::::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let mut variants_weight = Punctuated::::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 476 | let default_fields = named_fields.iter().skip(1).map(|field| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | let default_struct = quote! { [INFO] [stdout] | _____________--------------___- [INFO] [stdout] | |_____________|________________| [INFO] [stdout] | |_____________|________________| [INFO] [stdout] | |_____________|________________| [INFO] [stdout] | |_____________|________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 483 | | Self { [INFO] [stdout] 484 | | variants_weight: Box::new([ #variants_weight ]), [INFO] [stdout] 485 | | #( #default_fields ,)* [INFO] [stdout] | | -------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | | } [INFO] [stdout] 487 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 488 | [INFO] [stdout] 489 | | let named_fields = FieldsNamed { [INFO] [stdout] | | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 494 | let distribution_body = quote! { [INFO] [stdout] | _____________-----------------___- [INFO] [stdout] | |_____________|___________________| [INFO] [stdout] | |_____________|___________________| [INFO] [stdout] | |_____________|___________________| [INFO] [stdout] | |_____________|___________________| [INFO] [stdout] | |_____________|___________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | | let weights = self.variants_weight.as_ref(); [INFO] [stdout] 496 | | let weighted_idx = ::surprise_me::rand::distributions::WeightedIndex::new(weights).unwrap(); [INFO] [stdout] 497 | | let idx = rng.sample(weighted_idx); [INFO] [stdout] ... | [INFO] [stdout] 502 | | } [INFO] [stdout] 503 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 509 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 510 | semi_token: None, [INFO] [stdout] 511 | vis, [INFO] [stdout] 512 | fields: Fields::Named(named_fields), [INFO] [stdout] ... [INFO] [stdout] 516 | default_where_clause: (!where_clause.predicates.is_empty()).then_some(where_clause), [INFO] [stdout] 517 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/surprise.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn impl_surprise(input: DeriveInput) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | SurpriseImpl::new(input).map(|surprise_impl| quote!(#surprise_impl)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 16 | let factor = find_custom_factor(attrs)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(CustomSurpriseFactor(factor)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `surprise-me-derive` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `surprise-me-derive` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "13367d30809d1226211aa7bcf973effc243d4a05aa7b2ed00c99cf84a8ac8266", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13367d30809d1226211aa7bcf973effc243d4a05aa7b2ed00c99cf84a8ac8266", kill_on_drop: false }` [INFO] [stdout] 13367d30809d1226211aa7bcf973effc243d4a05aa7b2ed00c99cf84a8ac8266