[INFO] fetching crate surge-ping 0.8.1... [INFO] checking surge-ping-0.8.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate surge-ping 0.8.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate surge-ping 0.8.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate surge-ping 0.8.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate surge-ping 0.8.1 [INFO] tweaked toml for crates.io crate surge-ping 0.8.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate surge-ping 0.8.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b687e105b7e8b982ab09aa82cc7c4de2749bef0e2c8993ff7fafb7d6447714ea [INFO] running `Command { std: "docker" "start" "-a" "b687e105b7e8b982ab09aa82cc7c4de2749bef0e2c8993ff7fafb7d6447714ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b687e105b7e8b982ab09aa82cc7c4de2749bef0e2c8993ff7fafb7d6447714ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b687e105b7e8b982ab09aa82cc7c4de2749bef0e2c8993ff7fafb7d6447714ea", kill_on_drop: false }` [INFO] [stdout] b687e105b7e8b982ab09aa82cc7c4de2749bef0e2c8993ff7fafb7d6447714ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cec78812bd402b05ec8fd2dd1eb54a2586cf5b914fce34421ceac0ef07cc11e1 [INFO] running `Command { std: "docker" "start" "-a" "cec78812bd402b05ec8fd2dd1eb54a2586cf5b914fce34421ceac0ef07cc11e1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling futures-core v0.3.27 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling futures-channel v0.3.27 [INFO] [stderr] Compiling parking_lot_core v0.9.7 [INFO] [stderr] Compiling futures-task v0.3.27 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Checking futures-sink v0.3.27 [INFO] [stderr] Compiling futures-util v0.3.27 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking pnet_base v0.34.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking futures-io v0.3.27 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking pnet_macros_support v0.34.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling futures-macro v0.3.27 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling pnet_macros v0.34.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pnet_packet v0.34.0 [INFO] [stderr] Checking futures-executor v0.3.27 [INFO] [stderr] Checking futures v0.3.27 [INFO] [stderr] Checking surge-ping v0.8.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 52 | let (sock_type, socket) = Self::create_socket(config)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let socket = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | UdpSocket::from_std(unsafe { std::net::UdpSocket::from_raw_fd(socket.into_raw_fd()) })?; [INFO] [stdout] 76 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | inner: Arc::new(socket), [INFO] [stdout] 78 | | sock_type, [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 202 | let socket = AsyncSocket::new(config)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let reply_map = ReplyMap::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let recv = task::spawn(recv_task(socket.clone(), reply_map.clone())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 206 | | socket, [INFO] [stdout] 207 | | reply_map, [INFO] [stdout] 208 | | recv: Arc::new(recv), [INFO] [stdout] 209 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 52 | let (sock_type, socket) = Self::create_socket(config)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let socket = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | UdpSocket::from_std(unsafe { std::net::UdpSocket::from_raw_fd(socket.into_raw_fd()) })?; [INFO] [stdout] 76 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | inner: Arc::new(socket), [INFO] [stdout] 78 | | sock_type, [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 202 | let socket = AsyncSocket::new(config)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let reply_map = ReplyMap::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let recv = task::spawn(recv_task(socket.clone(), reply_map.clone())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 206 | | socket, [INFO] [stdout] 207 | | reply_map, [INFO] [stdout] 208 | | recv: Arc::new(recv), [INFO] [stdout] 209 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `surge-ping` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `surge-ping` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "cec78812bd402b05ec8fd2dd1eb54a2586cf5b914fce34421ceac0ef07cc11e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cec78812bd402b05ec8fd2dd1eb54a2586cf5b914fce34421ceac0ef07cc11e1", kill_on_drop: false }` [INFO] [stdout] cec78812bd402b05ec8fd2dd1eb54a2586cf5b914fce34421ceac0ef07cc11e1