[INFO] fetching crate super-rodio 0.0.7... [INFO] checking super-rodio-0.0.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate super-rodio 0.0.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate super-rodio 0.0.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate super-rodio 0.0.7 [INFO] finished tweaking crates.io crate super-rodio 0.0.7 [INFO] tweaked toml for crates.io crate super-rodio 0.0.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 114 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding coreaudio-rs v0.11.3 (latest: v0.12.1) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding jni-sys v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding ndk v0.8.0 (latest: v0.9.0) [INFO] [stderr] Adding ndk-sys v0.5.0+25.2.9519653 (latest: v0.6.0+11769913) [INFO] [stderr] Adding ogg v0.8.0 (latest: v0.9.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding windows v0.54.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.54.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-result v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding windows-sys v0.45.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d1635bac084251d8b0c1a8c4e33651e0a370354d2745a6391ef2407fd653685a [INFO] running `Command { std: "docker" "start" "-a" "d1635bac084251d8b0c1a8c4e33651e0a370354d2745a6391ef2407fd653685a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d1635bac084251d8b0c1a8c4e33651e0a370354d2745a6391ef2407fd653685a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1635bac084251d8b0c1a8c4e33651e0a370354d2745a6391ef2407fd653685a", kill_on_drop: false }` [INFO] [stdout] d1635bac084251d8b0c1a8c4e33651e0a370354d2745a6391ef2407fd653685a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f730c2c0126a3f57287168cf455cfeb00e38cdc89c70b59bb03c0accf9a8646a [INFO] running `Command { std: "docker" "start" "-a" "f730c2c0126a3f57287168cf455cfeb00e38cdc89c70b59bb03c0accf9a8646a", kill_on_drop: false }` [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking limited-queue v0.1.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking rodio v0.19.0 [INFO] [stderr] Checking super-rodio v0.0.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:37:34 [INFO] [stdout] | [INFO] [stdout] 37 | gen_out: Box::new(|| OutputStream::try_default().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 28 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 30 | | state.write().unwrap().waiting_q.push(song); [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 36 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 38 | | state [INFO] [stdout] 39 | | .read() [INFO] [stdout] 40 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 44 | | .collect() [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 36 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | spawn(move || { [INFO] [stdout] 38 | / state [INFO] [stdout] 39 | | .read() [INFO] [stdout] 40 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:51:15 [INFO] [stdout] | [INFO] [stdout] 50 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 52 | | state [INFO] [stdout] 53 | | .read() [INFO] [stdout] 54 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 58 | | .collect() [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 50 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | spawn(move || { [INFO] [stdout] 52 | / state [INFO] [stdout] 53 | | .read() [INFO] [stdout] 54 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 64 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | spawn(move || state.read().unwrap().current.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 64 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | spawn(move || state.read().unwrap().current.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 73 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | // create a new thread for loading and playing music [INFO] [stdout] 75 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 76 | | // The life cycle of "_stream" should >= source [INFO] [stdout] 77 | | // so we should make a new sink each time before playing some source [INFO] [stdout] 78 | | let (_stream, stream_handle) = { (state.read().unwrap().gen_out)() }; [INFO] [stdout] ... | [INFO] [stdout] 125 | | } [INFO] [stdout] 126 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:132:15 [INFO] [stdout] | [INFO] [stdout] 131 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 133 | | // check if old sink exists and [INFO] [stdout] 134 | | // play/pause it by acquiring read lock [INFO] [stdout] 135 | | if let Some(sink) = &state.read().unwrap().sink { [INFO] [stdout] ... | [INFO] [stdout] 141 | | }; [INFO] [stdout] 142 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:148:15 [INFO] [stdout] | [INFO] [stdout] 147 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 149 | | // check if old sink exists and [INFO] [stdout] 150 | | // stop it by acquiring read lock [INFO] [stdout] 151 | | if let Some(sink) = &state.read().unwrap().sink { [INFO] [stdout] 152 | | sink.stop(); [INFO] [stdout] 153 | | }; [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:161:15 [INFO] [stdout] | [INFO] [stdout] 160 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 162 | | let mut state = state.write().unwrap(); [INFO] [stdout] 163 | | state.waiting_q.clear(); [INFO] [stdout] 164 | | state.played_q.clear(); [INFO] [stdout] 165 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:170:15 [INFO] [stdout] | [INFO] [stdout] 169 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 171 | | // acquire an arc for this thread [INFO] [stdout] 172 | | let res = state.read().unwrap().current.state == SongState::PLAY; [INFO] [stdout] 173 | | res [INFO] [stdout] 174 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:179:15 [INFO] [stdout] | [INFO] [stdout] 178 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 180 | | state.write().unwrap().mode = PlaybackMode::NORMAL; [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:186:15 [INFO] [stdout] | [INFO] [stdout] 185 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 187 | | state.write().unwrap().mode = PlaybackMode::AUTO; [INFO] [stdout] 188 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:210:15 [INFO] [stdout] | [INFO] [stdout] 205 | / with_generator: Box< [INFO] [stdout] 206 | | dyn Fn() -> (rodio::OutputStream, rodio::OutputStreamHandle) + Send + Sync, [INFO] [stdout] 207 | | >, [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | ) -> JoinHandle<()> { [INFO] [stdout] 209 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 211 | | state.write().unwrap().gen_out = with_generator; [INFO] [stdout] 212 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `super-rodio` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:37:34 [INFO] [stdout] | [INFO] [stdout] 37 | gen_out: Box::new(|| OutputStream::try_default().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 28 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 30 | | state.write().unwrap().waiting_q.push(song); [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 36 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 38 | | state [INFO] [stdout] 39 | | .read() [INFO] [stdout] 40 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 44 | | .collect() [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 36 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | spawn(move || { [INFO] [stdout] 38 | / state [INFO] [stdout] 39 | | .read() [INFO] [stdout] 40 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:51:15 [INFO] [stdout] | [INFO] [stdout] 50 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 52 | | state [INFO] [stdout] 53 | | .read() [INFO] [stdout] 54 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 58 | | .collect() [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 50 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | spawn(move || { [INFO] [stdout] 52 | / state [INFO] [stdout] 53 | | .read() [INFO] [stdout] 54 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 64 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | spawn(move || state.read().unwrap().current.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 64 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | spawn(move || state.read().unwrap().current.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 73 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | // create a new thread for loading and playing music [INFO] [stdout] 75 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 76 | | // The life cycle of "_stream" should >= source [INFO] [stdout] 77 | | // so we should make a new sink each time before playing some source [INFO] [stdout] 78 | | let (_stream, stream_handle) = { (state.read().unwrap().gen_out)() }; [INFO] [stdout] ... | [INFO] [stdout] 125 | | } [INFO] [stdout] 126 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:132:15 [INFO] [stdout] | [INFO] [stdout] 131 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 133 | | // check if old sink exists and [INFO] [stdout] 134 | | // play/pause it by acquiring read lock [INFO] [stdout] 135 | | if let Some(sink) = &state.read().unwrap().sink { [INFO] [stdout] ... | [INFO] [stdout] 141 | | }; [INFO] [stdout] 142 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:148:15 [INFO] [stdout] | [INFO] [stdout] 147 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 149 | | // check if old sink exists and [INFO] [stdout] 150 | | // stop it by acquiring read lock [INFO] [stdout] 151 | | if let Some(sink) = &state.read().unwrap().sink { [INFO] [stdout] 152 | | sink.stop(); [INFO] [stdout] 153 | | }; [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:161:15 [INFO] [stdout] | [INFO] [stdout] 160 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 162 | | let mut state = state.write().unwrap(); [INFO] [stdout] 163 | | state.waiting_q.clear(); [INFO] [stdout] 164 | | state.played_q.clear(); [INFO] [stdout] 165 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:170:15 [INFO] [stdout] | [INFO] [stdout] 169 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 171 | | // acquire an arc for this thread [INFO] [stdout] 172 | | let res = state.read().unwrap().current.state == SongState::PLAY; [INFO] [stdout] 173 | | res [INFO] [stdout] 174 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:179:15 [INFO] [stdout] | [INFO] [stdout] 178 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 180 | | state.write().unwrap().mode = PlaybackMode::NORMAL; [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:186:15 [INFO] [stdout] | [INFO] [stdout] 185 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 187 | | state.write().unwrap().mode = PlaybackMode::AUTO; [INFO] [stdout] 188 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_player.rs:210:15 [INFO] [stdout] | [INFO] [stdout] 205 | / with_generator: Box< [INFO] [stdout] 206 | | dyn Fn() -> (rodio::OutputStream, rodio::OutputStreamHandle) + Send + Sync, [INFO] [stdout] 207 | | >, [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | ) -> JoinHandle<()> { [INFO] [stdout] 209 | let state = Arc::clone(&self); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | spawn(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 211 | | state.write().unwrap().gen_out = with_generator; [INFO] [stdout] 212 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:153:21 [INFO] [stdout] | [INFO] [stdout] 151 | let out_d_copy = out_d.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | player.set_device_maker(Box::new(move || { [INFO] [stdout] 153 | OutputStream::try_from_device(&out_d_copy).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `super-rodio` (lib test) due to 18 previous errors [INFO] running `Command { std: "docker" "inspect" "f730c2c0126a3f57287168cf455cfeb00e38cdc89c70b59bb03c0accf9a8646a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f730c2c0126a3f57287168cf455cfeb00e38cdc89c70b59bb03c0accf9a8646a", kill_on_drop: false }` [INFO] [stdout] f730c2c0126a3f57287168cf455cfeb00e38cdc89c70b59bb03c0accf9a8646a