[INFO] fetching crate super-process 0.0.1... [INFO] checking super-process-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate super-process 0.0.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate super-process 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate super-process 0.0.1 [INFO] finished tweaking crates.io crate super-process 0.0.1 [INFO] tweaked toml for crates.io crate super-process 0.0.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 77 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c55def868e5c3929967d6214bff127971ac22631757ffc8d495c3f379e74a44 [INFO] running `Command { std: "docker" "start" "-a" "6c55def868e5c3929967d6214bff127971ac22631757ffc8d495c3f379e74a44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c55def868e5c3929967d6214bff127971ac22631757ffc8d495c3f379e74a44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c55def868e5c3929967d6214bff127971ac22631757ffc8d495c3f379e74a44", kill_on_drop: false }` [INFO] [stdout] 6c55def868e5c3929967d6214bff127971ac22631757ffc8d495c3f379e74a44 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c054b3f6f6ce8f1415163a09c27c74d986be74833d9debf77d364b92cabbaa13 [INFO] running `Command { std: "docker" "start" "-a" "c054b3f6f6ce8f1415163a09c27c74d986be74833d9debf77d364b92cabbaa13", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-process v2.2.4 [INFO] [stderr] Checking super-process v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:461:15 [INFO] [stdout] | [INFO] [stdout] 459 | .map_err(|e: exe::CommandError| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 460 | e.command_with_context( [INFO] [stdout] 461 | command.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:495:74 [INFO] [stdout] | [INFO] [stdout] 495 | async fn invoke(self) -> Result { [INFO] [stdout] | _____________________----_________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 496 | | let mut command = self.clone().command(); [INFO] [stdout] 497 | | let output = [INFO] [stdout] 498 | | command [INFO] [stdout] ... | [INFO] [stdout] 506 | | Ok(output) [INFO] [stdout] 507 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:503:36 [INFO] [stdout] | [INFO] [stdout] 502 | .map_err(|e: exe::CommandError| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 503 | e.command_with_context(self.clone(), "waiting for output".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:541:32 [INFO] [stdout] | [INFO] [stdout] 539 | let status = child.status().await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 540 | let e: exe::CommandError = e.into(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 541 | e.command_with_context(command.clone(), "merging async streams".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:567:10 [INFO] [stdout] | [INFO] [stdout] 557 | fn invoke_streaming(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | let mut command = self.clone().command(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 559 | let child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 567 | Ok(Streaming { [INFO] [stdout] | __________^ [INFO] [stdout] 568 | | child, [INFO] [stdout] 569 | | command: self, [INFO] [stdout] 570 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:565:34 [INFO] [stdout] | [INFO] [stdout] 564 | .map_err(|e: exe::CommandError| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 565 | e.command_with_context(self.clone(), "spawning async process".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:724:11 [INFO] [stdout] | [INFO] [stdout] 723 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 724 | e.with_context("when setting up the shell command".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:818:76 [INFO] [stdout] | [INFO] [stdout] 818 | async fn setup_command(self) -> Result { [INFO] [stdout] | ____________________________----____________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 819 | | let Self { [INFO] [stdout] 820 | | script: ShellScript { script_path }, [INFO] [stdout] 821 | | mut base, [INFO] [stdout] ... | [INFO] [stdout] 824 | | Ok(base) [INFO] [stdout] 825 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `super-process` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:461:15 [INFO] [stdout] | [INFO] [stdout] 459 | .map_err(|e: exe::CommandError| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 460 | e.command_with_context( [INFO] [stdout] 461 | command.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:495:74 [INFO] [stdout] | [INFO] [stdout] 495 | async fn invoke(self) -> Result { [INFO] [stdout] | _____________________----_________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 496 | | let mut command = self.clone().command(); [INFO] [stdout] 497 | | let output = [INFO] [stdout] 498 | | command [INFO] [stdout] ... | [INFO] [stdout] 506 | | Ok(output) [INFO] [stdout] 507 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:503:36 [INFO] [stdout] | [INFO] [stdout] 502 | .map_err(|e: exe::CommandError| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 503 | e.command_with_context(self.clone(), "waiting for output".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:541:32 [INFO] [stdout] | [INFO] [stdout] 539 | let status = child.status().await.map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 540 | let e: exe::CommandError = e.into(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 541 | e.command_with_context(command.clone(), "merging async streams".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:567:10 [INFO] [stdout] | [INFO] [stdout] 557 | fn invoke_streaming(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | let mut command = self.clone().command(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 559 | let child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 567 | Ok(Streaming { [INFO] [stdout] | __________^ [INFO] [stdout] 568 | | child, [INFO] [stdout] 569 | | command: self, [INFO] [stdout] 570 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:565:34 [INFO] [stdout] | [INFO] [stdout] 564 | .map_err(|e: exe::CommandError| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 565 | e.command_with_context(self.clone(), "spawning async process".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:724:11 [INFO] [stdout] | [INFO] [stdout] 723 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 724 | e.with_context("when setting up the shell command".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:818:76 [INFO] [stdout] | [INFO] [stdout] 818 | async fn setup_command(self) -> Result { [INFO] [stdout] | ____________________________----____________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 819 | | let Self { [INFO] [stdout] 820 | | script: ShellScript { script_path }, [INFO] [stdout] 821 | | mut base, [INFO] [stdout] ... | [INFO] [stdout] 824 | | Ok(base) [INFO] [stdout] 825 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `super-process` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "c054b3f6f6ce8f1415163a09c27c74d986be74833d9debf77d364b92cabbaa13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c054b3f6f6ce8f1415163a09c27c74d986be74833d9debf77d364b92cabbaa13", kill_on_drop: false }` [INFO] [stdout] c054b3f6f6ce8f1415163a09c27c74d986be74833d9debf77d364b92cabbaa13