[INFO] fetching crate sunset 0.2.0... [INFO] checking sunset-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sunset 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate sunset 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate sunset 0.2.0 [INFO] finished tweaking crates.io crate sunset 0.2.0 [INFO] tweaked toml for crates.io crate sunset 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 129 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding virtue v0.0.16 (latest: v0.0.17) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e4c1745134c904cb3fcca0a383483f428c307116e09e4331582de4fd67b76da [INFO] running `Command { std: "docker" "start" "-a" "6e4c1745134c904cb3fcca0a383483f428c307116e09e4331582de4fd67b76da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e4c1745134c904cb3fcca0a383483f428c307116e09e4331582de4fd67b76da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e4c1745134c904cb3fcca0a383483f428c307116e09e4331582de4fd67b76da", kill_on_drop: false }` [INFO] [stdout] 6e4c1745134c904cb3fcca0a383483f428c307116e09e4331582de4fd67b76da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e2f91445c36322abbc67ba0f0bd704fa3b9cf868c5ca5cfa16aafca7555b57e5 [INFO] running `Command { std: "docker" "start" "-a" "e2f91445c36322abbc67ba0f0bd704fa3b9cf868c5ca5cfa16aafca7555b57e5", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling virtue v0.0.16 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking pretty-hex v0.4.1 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling sunset-sshwire-derive v0.2.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking simplelog v0.12.2 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling snafu-derive v0.8.4 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking snafu v0.8.4 [INFO] [stderr] Checking sunset v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sshwire.rs:431:12 [INFO] [stdout] | [INFO] [stdout] 411 | let inner = SSHDecode::dec(s)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | Ok(Blob(inner)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 90 | let algo_conf = AlgoConfig::new(true); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Self::new(ClientServer::Client(client::Client::new()), algo_conf) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:96:19 [INFO] [stdout] | [INFO] [stdout] 95 | let algo_conf = AlgoConfig::new(false); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Self::new(ClientServer::Server(server::Server::new()), algo_conf) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 99 | fn new(cliserv: ClientServer, algo_conf: AlgoConfig) -> Result { [INFO] [stdout] | --------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Ok(Conn { [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | sess_id: None, [INFO] [stdout] 102 | | kex: Kex::new(), [INFO] [stdout] 103 | | remote_version: ident::RemoteVersion::new(cliserv.is_client()), [INFO] [stdout] ... | [INFO] [stdout] 108 | | parse_ctx: ParseContext::new(), [INFO] [stdout] 109 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encrypt.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 174 | kex_out: kex::KexOutput, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let enc = { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let dec = { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | Ok(Keys { enc, dec, integ_enc, integ_dec }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:84:22 [INFO] [stdout] | [INFO] [stdout] 67 | let mut kexs: LocalNames = fixed_options_kex.try_into().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | hostsig: fixed_options_hostsig.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:85:22 [INFO] [stdout] | [INFO] [stdout] 67 | let mut kexs: LocalNames = fixed_options_kex.try_into().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | ciphers: fixed_options_cipher.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:86:19 [INFO] [stdout] | [INFO] [stdout] 67 | let mut kexs: LocalNames = fixed_options_kex.try_into().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | macs: fixed_options_mac.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 67 | let mut kexs: LocalNames = fixed_options_kex.try_into().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | comps: fixed_options_comp.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:519:12 [INFO] [stdout] | [INFO] [stdout] 436 | let kex = SharedSecret::from_name(kex_method)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 519 | Ok(Algos { [INFO] [stdout] | ____________^ [INFO] [stdout] 520 | | kex, [INFO] [stdout] 521 | | hostsig, [INFO] [stdout] 522 | | cipher_enc, [INFO] [stdout] ... | [INFO] [stdout] 529 | | strict_kex, [INFO] [stdout] 530 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:754:12 [INFO] [stdout] | [INFO] [stdout] 751 | let ours = x25519_dalek::EphemeralSecret::random_from_rng(OsRng); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 754 | Ok(KexCurve25519 { ours: Some(ours), pubkey }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:771:12 [INFO] [stdout] | [INFO] [stdout] 770 | let shsec = kex.ours.take().trap()?.diffie_hellman(&theirs); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 771 | Ok(KexOutput::new(shsec.as_bytes(), algos, kex_hash)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:479:12 [INFO] [stdout] | [INFO] [stdout] 478 | let term = p.term.as_ascii()?.try_into().map_err(|_| Error::BadString)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | Ok(Pty { [INFO] [stdout] | ____________^ [INFO] [stdout] 480 | | term, [INFO] [stdout] 481 | | cols: p.cols, [INFO] [stdout] 482 | | rows: p.rows, [INFO] [stdout] ... | [INFO] [stdout] 485 | | modes: Vec::new(), [INFO] [stdout] 486 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:951:19 [INFO] [stdout] | [INFO] [stdout] 950 | pub fn pty(&mut self, pty: channel::Pty) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 951 | self.send(Req::Pty(pty)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/noasync.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn non_async(f: F) -> Result where F: Future { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | futures::pin_mut!(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | [INFO] [stdout] 23 | let w = futures::task::noop_waker(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | match f.poll(&mut Context::from_waker(&w)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sunset` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sshwire.rs:431:12 [INFO] [stdout] | [INFO] [stdout] 411 | let inner = SSHDecode::dec(s)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | Ok(Blob(inner)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 90 | let algo_conf = AlgoConfig::new(true); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Self::new(ClientServer::Client(client::Client::new()), algo_conf) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:96:19 [INFO] [stdout] | [INFO] [stdout] 95 | let algo_conf = AlgoConfig::new(false); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Self::new(ClientServer::Server(server::Server::new()), algo_conf) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conn.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 99 | fn new(cliserv: ClientServer, algo_conf: AlgoConfig) -> Result { [INFO] [stdout] | --------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Ok(Conn { [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | sess_id: None, [INFO] [stdout] 102 | | kex: Kex::new(), [INFO] [stdout] 103 | | remote_version: ident::RemoteVersion::new(cliserv.is_client()), [INFO] [stdout] ... | [INFO] [stdout] 108 | | parse_ctx: ParseContext::new(), [INFO] [stdout] 109 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encrypt.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 174 | kex_out: kex::KexOutput, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let enc = { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let dec = { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | Ok(Keys { enc, dec, integ_enc, integ_dec }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:84:22 [INFO] [stdout] | [INFO] [stdout] 67 | let mut kexs: LocalNames = fixed_options_kex.try_into().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | hostsig: fixed_options_hostsig.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:85:22 [INFO] [stdout] | [INFO] [stdout] 67 | let mut kexs: LocalNames = fixed_options_kex.try_into().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | ciphers: fixed_options_cipher.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:86:19 [INFO] [stdout] | [INFO] [stdout] 67 | let mut kexs: LocalNames = fixed_options_kex.try_into().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | macs: fixed_options_mac.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 67 | let mut kexs: LocalNames = fixed_options_kex.try_into().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | comps: fixed_options_comp.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:519:12 [INFO] [stdout] | [INFO] [stdout] 436 | let kex = SharedSecret::from_name(kex_method)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 519 | Ok(Algos { [INFO] [stdout] | ____________^ [INFO] [stdout] 520 | | kex, [INFO] [stdout] 521 | | hostsig, [INFO] [stdout] 522 | | cipher_enc, [INFO] [stdout] ... | [INFO] [stdout] 529 | | strict_kex, [INFO] [stdout] 530 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:754:12 [INFO] [stdout] | [INFO] [stdout] 751 | let ours = x25519_dalek::EphemeralSecret::random_from_rng(OsRng); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 754 | Ok(KexCurve25519 { ours: Some(ours), pubkey }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kex.rs:771:12 [INFO] [stdout] | [INFO] [stdout] 770 | let shsec = kex.ours.take().trap()?.diffie_hellman(&theirs); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 771 | Ok(KexOutput::new(shsec.as_bytes(), algos, kex_hash)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:479:12 [INFO] [stdout] | [INFO] [stdout] 478 | let term = p.term.as_ascii()?.try_into().map_err(|_| Error::BadString)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | Ok(Pty { [INFO] [stdout] | ____________^ [INFO] [stdout] 480 | | term, [INFO] [stdout] 481 | | cols: p.cols, [INFO] [stdout] 482 | | rows: p.rows, [INFO] [stdout] ... | [INFO] [stdout] 485 | | modes: Vec::new(), [INFO] [stdout] 486 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:951:19 [INFO] [stdout] | [INFO] [stdout] 950 | pub fn pty(&mut self, pty: channel::Pty) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 951 | self.send(Req::Pty(pty)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/noasync.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn non_async(f: F) -> Result where F: Future { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | futures::pin_mut!(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | [INFO] [stdout] 23 | let w = futures::task::noop_waker(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | match f.poll(&mut Context::from_waker(&w)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sunset` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "e2f91445c36322abbc67ba0f0bd704fa3b9cf868c5ca5cfa16aafca7555b57e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2f91445c36322abbc67ba0f0bd704fa3b9cf868c5ca5cfa16aafca7555b57e5", kill_on_drop: false }` [INFO] [stdout] e2f91445c36322abbc67ba0f0bd704fa3b9cf868c5ca5cfa16aafca7555b57e5