[INFO] fetching crate summavy-query-grammar 0.18.2... [INFO] checking summavy-query-grammar-0.18.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate summavy-query-grammar 0.18.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate summavy-query-grammar 0.18.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate summavy-query-grammar 0.18.2 [INFO] finished tweaking crates.io crate summavy-query-grammar 0.18.2 [INFO] tweaked toml for crates.io crate summavy-query-grammar 0.18.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 164c3148720028a8195fbc35aef5b48ca40502238971e13d0ddea1786c6419c1 [INFO] running `Command { std: "docker" "start" "-a" "164c3148720028a8195fbc35aef5b48ca40502238971e13d0ddea1786c6419c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "164c3148720028a8195fbc35aef5b48ca40502238971e13d0ddea1786c6419c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "164c3148720028a8195fbc35aef5b48ca40502238971e13d0ddea1786c6419c1", kill_on_drop: false }` [INFO] [stdout] 164c3148720028a8195fbc35aef5b48ca40502238971e13d0ddea1786c6419c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc3b66f8a24061f9db9e06c91b67f4bd2664c7f372a754b9be2eac9efaacbbd8 [INFO] running `Command { std: "docker" "start" "-a" "cc3b66f8a24061f9db9e06c91b67f4bd2664c7f372a754b9be2eac9efaacbbd8", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking summavy-query-grammar v0.18.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 30 | Lazy::new(|| Regex::new(ESCAPED_SPECIAL_CHARS_PATTERN).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:42:14 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|s| ESCAPED_SPECIAL_CHARS_RE.replace_all(&s, "$1").to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 162 | let term_default_field = (term_val(), slop_val()).map(|(phrase, slop)| UserInputLiteral { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | / attempt(term_query()) [INFO] [stdout] 169 | | .or(term_default_field) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 205 | let elastic_unbounded_range = ( [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let lower_bound = (one_of("{[".chars()), range_term_val()).map( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | let upper_bound = (range_term_val(), one_of("}]".chars())).map( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let lower_to_upper = ( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | / ( [INFO] [stdout] 254 | | optional(field_name()).skip(spaces()), [INFO] [stdout] 255 | | // try elastic first, if it matches, the range is unbounded [INFO] [stdout] 256 | | attempt(elastic_unbounded_range).or(lower_to_upper), [INFO] [stdout] 257 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:275:5 [INFO] [stdout] | [INFO] [stdout] 271 | let term_list = between(char('['), char(']'), sep_by(term_val(), spaces())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let set_content = ((string("IN"), spaces()), term_list).map(|(_, elements)| elements); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | [INFO] [stdout] 275 | (optional(attempt(field_name().skip(spaces()))), set_content) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:397:5 [INFO] [stdout] | [INFO] [stdout] 381 | let boolean_expr = (boosted_leaf().skip(spaces()), many1(operand_leaf())) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | .map(|(left, right)| aggregate_binary_expressions(left, right)); [INFO] [stdout] 383 | let whitespace_separated_leaves = many1(occur_leaf().skip(spaces().silent())).map( [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | let expr = attempt(boolean_expr).or(whitespace_separated_leaves); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 397 | spaces().with(expr).skip(spaces()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:397:30 [INFO] [stdout] | [INFO] [stdout] 381 | let boolean_expr = (boosted_leaf().skip(spaces()), many1(operand_leaf())) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | .map(|(left, right)| aggregate_binary_expressions(left, right)); [INFO] [stdout] 383 | let whitespace_separated_leaves = many1(occur_leaf().skip(spaces().silent())).map( [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | let expr = attempt(boolean_expr).or(whitespace_separated_leaves); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 397 | spaces().with(expr).skip(spaces()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `summavy-query-grammar` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 30 | Lazy::new(|| Regex::new(ESCAPED_SPECIAL_CHARS_PATTERN).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:42:14 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|s| ESCAPED_SPECIAL_CHARS_RE.replace_all(&s, "$1").to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:168:5 [INFO] [stdout] | [INFO] [stdout] 162 | let term_default_field = (term_val(), slop_val()).map(|(phrase, slop)| UserInputLiteral { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | / attempt(term_query()) [INFO] [stdout] 169 | | .or(term_default_field) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 205 | let elastic_unbounded_range = ( [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let lower_bound = (one_of("{[".chars()), range_term_val()).map( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | let upper_bound = (range_term_val(), one_of("}]".chars())).map( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let lower_to_upper = ( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | / ( [INFO] [stdout] 254 | | optional(field_name()).skip(spaces()), [INFO] [stdout] 255 | | // try elastic first, if it matches, the range is unbounded [INFO] [stdout] 256 | | attempt(elastic_unbounded_range).or(lower_to_upper), [INFO] [stdout] 257 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:275:5 [INFO] [stdout] | [INFO] [stdout] 271 | let term_list = between(char('['), char(']'), sep_by(term_val(), spaces())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let set_content = ((string("IN"), spaces()), term_list).map(|(_, elements)| elements); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | [INFO] [stdout] 275 | (optional(attempt(field_name().skip(spaces()))), set_content) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:397:5 [INFO] [stdout] | [INFO] [stdout] 381 | let boolean_expr = (boosted_leaf().skip(spaces()), many1(operand_leaf())) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | .map(|(left, right)| aggregate_binary_expressions(left, right)); [INFO] [stdout] 383 | let whitespace_separated_leaves = many1(occur_leaf().skip(spaces().silent())).map( [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | let expr = attempt(boolean_expr).or(whitespace_separated_leaves); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 397 | spaces().with(expr).skip(spaces()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query_grammar.rs:397:30 [INFO] [stdout] | [INFO] [stdout] 381 | let boolean_expr = (boosted_leaf().skip(spaces()), many1(operand_leaf())) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | .map(|(left, right)| aggregate_binary_expressions(left, right)); [INFO] [stdout] 383 | let whitespace_separated_leaves = many1(occur_leaf().skip(spaces().silent())).map( [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | let expr = attempt(boolean_expr).or(whitespace_separated_leaves); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 397 | spaces().with(expr).skip(spaces()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `summavy-query-grammar` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "cc3b66f8a24061f9db9e06c91b67f4bd2664c7f372a754b9be2eac9efaacbbd8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc3b66f8a24061f9db9e06c91b67f4bd2664c7f372a754b9be2eac9efaacbbd8", kill_on_drop: false }` [INFO] [stdout] cc3b66f8a24061f9db9e06c91b67f4bd2664c7f372a754b9be2eac9efaacbbd8