[INFO] fetching crate subtile 0.3.0... [INFO] checking subtile-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate subtile 0.3.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate subtile 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate subtile 0.3.0 [INFO] finished tweaking crates.io crate subtile 0.3.0 [INFO] tweaked toml for crates.io crate subtile 0.3.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 58 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 59d6bc0d76cd4127df57aa1b97b37dc598a17e39e2959e066766015feafb061d [INFO] running `Command { std: "docker" "start" "-a" "59d6bc0d76cd4127df57aa1b97b37dc598a17e39e2959e066766015feafb061d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "59d6bc0d76cd4127df57aa1b97b37dc598a17e39e2959e066766015feafb061d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59d6bc0d76cd4127df57aa1b97b37dc598a17e39e2959e066766015feafb061d", kill_on_drop: false }` [INFO] [stdout] 59d6bc0d76cd4127df57aa1b97b37dc598a17e39e2959e066766015feafb061d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d1c3a4b279544cbe28c48bd6807293bd3e4bb349592758661bfd5275aaded331 [INFO] running `Command { std: "docker" "start" "-a" "d1c3a4b279544cbe28c48bd6807293bd3e4bb349592758661bfd5275aaded331", kill_on_drop: false }` [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking iter_fixed v0.4.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking subtile v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image/utils.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 64 | .try_for_each(move |(i, img)| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | dump_image(&filepath, img.borrow()).map_err(|source| DumpError::DumpImage { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vobsub/idx.rs:93:50 [INFO] [stdout] | [INFO] [stdout] 93 | static KEY_VALUE: Lazy = Lazy::new(|| Regex::new("^([A-Za-z/ ]+): (.*)").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vobsub/img.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 130 | let end_of_line = value(0, tag_bits(0, 14u16)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | // Count for 4-nibble RLE. [INFO] [stdout] 132 | let count4 = preceded(tag_bits(0, 6u8), take_bits(8u16)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | // Count for 3-nibble RLE. [INFO] [stdout] 134 | let count3 = preceded(tag_bits(0, 4u8), take_bits(6u16)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | // Count for 2-nibble RLE. [INFO] [stdout] 136 | let count2 = preceded(tag_bits(0, 2u8), take_bits(4u16)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | // Count for 1-nibble RLE. [INFO] [stdout] 138 | let count1 = take_bits(2u16); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | alt((end_of_line, count4, count3, count2, count1))(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vobsub/img.rs:331:44 [INFO] [stdout] | [INFO] [stdout] 331 | .map(|(&palette_idx, &alpha)| (self.palette[palette_idx as usize].clone(), alpha)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vobsub/mpeg2/pes.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | map(|input| bits::complete::take(1u8)(input), |b: u8| b == 1)(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vobsub/sub.rs:395:14 [INFO] [stdout] | [INFO] [stdout] 316 | Some(Err(e)) => return Some(Err(From::from(e))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | Some(Ok((base_time, sub_packet))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image/utils.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 64 | .try_for_each(move |(i, img)| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | dump_image(&filepath, img.borrow()).map_err(|source| DumpError::DumpImage { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vobsub/idx.rs:93:50 [INFO] [stdout] | [INFO] [stdout] 93 | static KEY_VALUE: Lazy = Lazy::new(|| Regex::new("^([A-Za-z/ ]+): (.*)").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vobsub/img.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 130 | let end_of_line = value(0, tag_bits(0, 14u16)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | // Count for 4-nibble RLE. [INFO] [stdout] 132 | let count4 = preceded(tag_bits(0, 6u8), take_bits(8u16)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | // Count for 3-nibble RLE. [INFO] [stdout] 134 | let count3 = preceded(tag_bits(0, 4u8), take_bits(6u16)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | // Count for 2-nibble RLE. [INFO] [stdout] 136 | let count2 = preceded(tag_bits(0, 2u8), take_bits(4u16)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | // Count for 1-nibble RLE. [INFO] [stdout] 138 | let count1 = take_bits(2u16); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | alt((end_of_line, count4, count3, count2, count1))(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vobsub/img.rs:331:44 [INFO] [stdout] | [INFO] [stdout] 331 | .map(|(&palette_idx, &alpha)| (self.palette[palette_idx as usize].clone(), alpha)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vobsub/mpeg2/pes.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | map(|input| bits::complete::take(1u8)(input), |b: u8| b == 1)(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vobsub/sub.rs:395:14 [INFO] [stdout] | [INFO] [stdout] 316 | Some(Err(e)) => return Some(Err(From::from(e))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | Some(Ok((base_time, sub_packet))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `subtile` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `subtile` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "d1c3a4b279544cbe28c48bd6807293bd3e4bb349592758661bfd5275aaded331", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1c3a4b279544cbe28c48bd6807293bd3e4bb349592758661bfd5275aaded331", kill_on_drop: false }` [INFO] [stdout] d1c3a4b279544cbe28c48bd6807293bd3e4bb349592758661bfd5275aaded331