[INFO] fetching crate substrate-manager 0.1.2... [INFO] checking substrate-manager-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate substrate-manager 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate substrate-manager 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate substrate-manager 0.1.2 [INFO] finished tweaking crates.io crate substrate-manager 0.1.2 [INFO] tweaked toml for crates.io crate substrate-manager 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate substrate-manager 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: file `/workspace/builds/worker-4-tc2/source/src/bin/substrate-manager/main.rs` found to be present in multiple build targets: [INFO] [stderr] * `bin` target `substrate` [INFO] [stderr] * `bin` target `substrate-manager` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de3ae7534f59eb99e539bee8d59d7e3fb202d7dc3db40eb254455b6883091ad2 [INFO] running `Command { std: "docker" "start" "-a" "de3ae7534f59eb99e539bee8d59d7e3fb202d7dc3db40eb254455b6883091ad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de3ae7534f59eb99e539bee8d59d7e3fb202d7dc3db40eb254455b6883091ad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de3ae7534f59eb99e539bee8d59d7e3fb202d7dc3db40eb254455b6883091ad2", kill_on_drop: false }` [INFO] [stdout] de3ae7534f59eb99e539bee8d59d7e3fb202d7dc3db40eb254455b6883091ad2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae77332253d8c9d80026ec1c2b10c023aac62011a5ec3ebefce2cfeeed82aca6 [INFO] running `Command { std: "docker" "start" "-a" "ae77332253d8c9d80026ec1c2b10c023aac62011a5ec3ebefce2cfeeed82aca6", kill_on_drop: false }` [INFO] [stderr] warning: file `/opt/rustwide/workdir/src/bin/substrate-manager/main.rs` found to be present in multiple build targets: [INFO] [stderr] * `bin` target `substrate` [INFO] [stderr] * `bin` target `substrate-manager` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling proc-macro2 v1.0.65 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling quote v1.0.30 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustix v0.37.23 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling signal-hook v0.3.16 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling tempfile v3.6.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking gimli v0.27.3 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling thiserror v1.0.43 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking object v0.31.1 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Compiling serde_json v1.0.104 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Compiling backtrace v0.3.68 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking filetime v0.2.21 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking jobserver v0.1.26 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking newline-converter v0.2.2 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking winnow v0.5.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking color-spantrace v0.2.0 [INFO] [stderr] Checking dyn-clone v1.0.12 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking open v5.0.0 [INFO] [stderr] Checking unicode-xid v0.2.4 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Compiling serde_derive v1.0.183 [INFO] [stderr] Checking sha2 v0.10.7 [INFO] [stderr] Checking which v4.4.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking addr2line v0.20.0 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking clap_builder v4.3.21 [INFO] [stderr] Checking cargo-util v0.2.4 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Checking toml_edit v0.19.14 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling interactive-clap-derive v0.2.4 [INFO] [stderr] Compiling thiserror-impl v1.0.43 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Checking inquire v0.6.2 [INFO] [stderr] Checking interactive-clap v0.2.4 [INFO] [stderr] Checking clap v4.3.21 [INFO] [stderr] Checking substrate-manager v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Config` [INFO] [stdout] --> src/ops/substrate_run.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::util::{Config, SubstrateResult}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PathBuf` [INFO] [stdout] --> src/ops/substrate_frontend.rs:1:42 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{process::Command, path::{Path, PathBuf}}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow::Context as _` [INFO] [stdout] --> src/ops/substrate_new.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use anyhow::Context as _; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Config` [INFO] [stdout] --> src/ops/substrate_test.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::util::{Config, SubstrateResult}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Value` [INFO] [stdout] --> src/util/config.rs:10:47 [INFO] [stdout] | [INFO] [stdout] 10 | use toml_edit::{value, Document, Item, Table, Value}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/templates/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::manifest::Manifest` [INFO] [stdout] --> src/templates/mod.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{core::manifest::Manifest, util::SubstrateResult}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Config` [INFO] [stdout] --> src/ops/substrate_run.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::util::{Config, SubstrateResult}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PathBuf` [INFO] [stdout] --> src/ops/substrate_frontend.rs:1:42 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{process::Command, path::{Path, PathBuf}}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow::Context as _` [INFO] [stdout] --> src/ops/substrate_new.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use anyhow::Context as _; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Config` [INFO] [stdout] --> src/ops/substrate_test.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::util::{Config, SubstrateResult}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/ops/mod.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | pub mod substrate_test; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Value` [INFO] [stdout] --> src/util/config.rs:10:47 [INFO] [stdout] | [INFO] [stdout] 10 | use toml_edit::{value, Document, Item, Table, Value}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/templates/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::manifest::Manifest` [INFO] [stdout] --> src/templates/mod.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{core::manifest::Manifest, util::SubstrateResult}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_parent` is never used [INFO] [stdout] --> src/ops/substrate_new.rs:103:4 [INFO] [stdout] | [INFO] [stdout] 103 | fn get_parent(opts: &NewOptions) -> SubstrateResult<&str> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/manifest.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | toml.parse() [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/manifest.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | .map_err(|e| anyhow::Error::from(e).context("could not parse input as TOML")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/shell.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn from_write(out: Box) -> Shell { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Shell { [INFO] [stdout] 119 | output: ShellOut::Write(out), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/command_prelude.rs:7:19 [INFO] [stdout] | [INFO] [stdout] 6 | fn arg_quiet(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | self._arg(flag("quiet", "Do not print cargo log messages").short('q')) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/errors.rs:133:20 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn new(error: anyhow::Error, code: i32) -> CliError { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | CliError { [INFO] [stdout] 133 | error: Some(error), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/errors.rs:155:23 [INFO] [stdout] | [INFO] [stdout] 153 | fn from(err: clap::Error) -> CliError { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let code = if err.use_stderr() { 1 } else { 0 }; [INFO] [stdout] 155 | CliError::new(err.into(), code) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/errors.rs:161:23 [INFO] [stdout] | [INFO] [stdout] 160 | fn from(err: std::io::Error) -> CliError { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | CliError::new(err.into(), 1) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/errors.rs:168:20 [INFO] [stdout] | [INFO] [stdout] 166 | fn from(err: color_eyre::Report) -> CliError { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | CliError { [INFO] [stdout] 168 | error: Some(anyhow!(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_parent` is never used [INFO] [stdout] --> src/ops/substrate_new.rs:103:4 [INFO] [stdout] | [INFO] [stdout] 103 | fn get_parent(opts: &NewOptions) -> SubstrateResult<&str> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/manifest.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | toml.parse() [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/manifest.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | .map_err(|e| anyhow::Error::from(e).context("could not parse input as TOML")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/shell.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn from_write(out: Box) -> Shell { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Shell { [INFO] [stdout] 119 | output: ShellOut::Write(out), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/command_prelude.rs:7:19 [INFO] [stdout] | [INFO] [stdout] 6 | fn arg_quiet(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | self._arg(flag("quiet", "Do not print cargo log messages").short('q')) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/errors.rs:133:20 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn new(error: anyhow::Error, code: i32) -> CliError { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | CliError { [INFO] [stdout] 133 | error: Some(error), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/errors.rs:155:23 [INFO] [stdout] | [INFO] [stdout] 153 | fn from(err: clap::Error) -> CliError { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let code = if err.use_stderr() { 1 } else { 0 }; [INFO] [stdout] 155 | CliError::new(err.into(), code) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/errors.rs:161:23 [INFO] [stdout] | [INFO] [stdout] 160 | fn from(err: std::io::Error) -> CliError { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | CliError::new(err.into(), 1) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/errors.rs:168:20 [INFO] [stdout] | [INFO] [stdout] 166 | fn from(err: color_eyre::Report) -> CliError { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | CliError { [INFO] [stdout] 168 | error: Some(anyhow!(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `substrate-manager` (lib test) due to 9 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `substrate-manager` (lib) due to 9 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ae77332253d8c9d80026ec1c2b10c023aac62011a5ec3ebefce2cfeeed82aca6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae77332253d8c9d80026ec1c2b10c023aac62011a5ec3ebefce2cfeeed82aca6", kill_on_drop: false }` [INFO] [stdout] ae77332253d8c9d80026ec1c2b10c023aac62011a5ec3ebefce2cfeeed82aca6