[INFO] fetching crate substrate-constructor 0.1.0... [INFO] checking substrate-constructor-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate substrate-constructor 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate substrate-constructor 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate substrate-constructor 0.1.0 [INFO] finished tweaking crates.io crate substrate-constructor 0.1.0 [INFO] tweaked toml for crates.io crate substrate-constructor 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 73 packages to latest compatible versions [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding sp-arithmetic v24.0.0 (latest: v26.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c37f349af0326793149702fd8ee004ce0a4b4c88312be0b577e3c1edf65a843 [INFO] running `Command { std: "docker" "start" "-a" "0c37f349af0326793149702fd8ee004ce0a4b4c88312be0b577e3c1edf65a843", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c37f349af0326793149702fd8ee004ce0a4b4c88312be0b577e3c1edf65a843", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c37f349af0326793149702fd8ee004ce0a4b4c88312be0b577e3c1edf65a843", kill_on_drop: false }` [INFO] [stdout] 0c37f349af0326793149702fd8ee004ce0a4b4c88312be0b577e3c1edf65a843 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86cd2065c5e31ca1dc032178a38f1907e16489e7854c5377b72f5a640776a8d6 [INFO] running `Command { std: "docker" "start" "-a" "86cd2065c5e31ca1dc032178a38f1907e16489e7854c5377b72f5a640776a8d6", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking fixed-hash v0.8.0 [INFO] [stderr] Checking sp-std v14.0.0 [INFO] [stderr] Checking external-memory-tools v0.1.1 [INFO] [stderr] Checking base58 v0.2.0 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Checking primitive-types v0.12.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking integer-sqrt v0.1.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking parity-scale-codec v3.6.12 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking scale-info v2.11.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking frame-metadata v16.0.0 [INFO] [stderr] Checking sp-arithmetic v24.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking sp-crypto-hashing v0.1.0 [INFO] [stderr] Checking sp-core-hashing v16.0.0 [INFO] [stderr] Checking substrate_parser v0.6.1 [INFO] [stderr] Checking substrate-constructor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/try_fill.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(value) = <$ty>::try_from($source) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | UnsignedToFill::U64(ref mut old) => rpc_u64_fit!(u64, old, source), [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] = note: this warning originates in the macro `rpc_u64_fit` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/try_fill.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(value) = <$ty>::try_from($source) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 75 | UnsignedToFill::U128(ref mut old) => rpc_u64_fit!(u128, old, source), [INFO] [stdout] | ------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: this warning originates in the macro `rpc_u64_fit` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fill_prepare.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 95 | let fields_to_fill = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | prepare_fields::(&variant.fields, ext_memory, registry, Checker::new())?; [INFO] [stdout] 97 | let selected = VariantSelected { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | available_variants: variants.to_owned(), [INFO] [stdout] 106 | | selected, [INFO] [stdout] 107 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finalize.rs:342:14 [INFO] [stdout] | [INFO] [stdout] 335 | let mut fields_content = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | Some(VariantContent { [INFO] [stdout] | ______________^ [INFO] [stdout] 343 | | index: self.selected.index, [INFO] [stdout] 344 | | fields_content, [INFO] [stdout] 345 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `substrate-constructor` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/try_fill.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(value) = <$ty>::try_from($source) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | UnsignedToFill::U64(ref mut old) => rpc_u64_fit!(u64, old, source), [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] = note: this warning originates in the macro `rpc_u64_fit` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/try_fill.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(value) = <$ty>::try_from($source) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 75 | UnsignedToFill::U128(ref mut old) => rpc_u64_fit!(u128, old, source), [INFO] [stdout] | ------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: this warning originates in the macro `rpc_u64_fit` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fill_prepare.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 95 | let fields_to_fill = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | prepare_fields::(&variant.fields, ext_memory, registry, Checker::new())?; [INFO] [stdout] 97 | let selected = VariantSelected { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | available_variants: variants.to_owned(), [INFO] [stdout] 106 | | selected, [INFO] [stdout] 107 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finalize.rs:342:14 [INFO] [stdout] | [INFO] [stdout] 335 | let mut fields_content = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | Some(VariantContent { [INFO] [stdout] | ______________^ [INFO] [stdout] 343 | | index: self.selected.index, [INFO] [stdout] 344 | | fields_content, [INFO] [stdout] 345 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `substrate-constructor` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "86cd2065c5e31ca1dc032178a38f1907e16489e7854c5377b72f5a640776a8d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86cd2065c5e31ca1dc032178a38f1907e16489e7854c5377b72f5a640776a8d6", kill_on_drop: false }` [INFO] [stdout] 86cd2065c5e31ca1dc032178a38f1907e16489e7854c5377b72f5a640776a8d6