[INFO] fetching crate substrait-expr-funcgen 0.2.1... [INFO] checking substrait-expr-funcgen-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate substrait-expr-funcgen 0.2.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate substrait-expr-funcgen 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate substrait-expr-funcgen 0.2.1 [INFO] finished tweaking crates.io crate substrait-expr-funcgen 0.2.1 [INFO] tweaked toml for crates.io crate substrait-expr-funcgen 0.2.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 78 packages to latest compatible versions [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding prost v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding prost-build v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding prost-types v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding regress v0.8.0 (latest: v0.10.0) [INFO] [stderr] Adding substrait v0.29.4 (latest: v0.41.5) [INFO] [stderr] Adding typify v0.0.16 (latest: v0.1.0) [INFO] [stderr] Adding typify-impl v0.0.16 (latest: v0.1.0) [INFO] [stderr] Adding typify-macro v0.0.16 (latest: v0.1.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c705fe39f6a39d78231ea066b662c1d5c9560892ba850fa835cf2bc776d39aaa [INFO] running `Command { std: "docker" "start" "-a" "c705fe39f6a39d78231ea066b662c1d5c9560892ba850fa835cf2bc776d39aaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c705fe39f6a39d78231ea066b662c1d5c9560892ba850fa835cf2bc776d39aaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c705fe39f6a39d78231ea066b662c1d5c9560892ba850fa835cf2bc776d39aaa", kill_on_drop: false }` [INFO] [stdout] c705fe39f6a39d78231ea066b662c1d5c9560892ba850fa835cf2bc776d39aaa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 590f296c2c20e81068199649fb0a9c1352e408935e18051c645e272524be65b2 [INFO] running `Command { std: "docker" "start" "-a" "590f296c2c20e81068199649fb0a9c1352e408935e18051c645e272524be65b2", kill_on_drop: false }` [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling dyn-clone v1.0.17 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling bytes v1.7.1 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling unsafe-libyaml v0.2.11 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling regress v0.8.0 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling tempfile v3.12.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling prost v0.12.6 [INFO] [stderr] Checking prost-types v0.12.6 [INFO] [stderr] Compiling prost-build v0.12.6 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Compiling serde_tokenstream v0.2.2 [INFO] [stderr] Compiling typify-impl v0.0.16 [INFO] [stderr] Compiling typify-macro v0.0.16 [INFO] [stderr] Compiling typify v0.0.16 [INFO] [stderr] Compiling substrait v0.29.4 [INFO] [stderr] Checking substrait-expr-funcgen v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 180 | let func_name_caps: TokenStream = function.name.to_uppercase().parse()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | [INFO] [stdout] 182 | Ok(num_args [INFO] [stdout] | ________^ [INFO] [stdout] 183 | | .iter() [INFO] [stdout] 184 | | .enumerate() [INFO] [stdout] 185 | | .map(|(idx, num_args)| { [INFO] [stdout] ... | [INFO] [stdout] 206 | | }) [INFO] [stdout] 207 | | .collect::>()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `substrait-expr-funcgen` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 180 | let func_name_caps: TokenStream = function.name.to_uppercase().parse()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | [INFO] [stdout] 182 | Ok(num_args [INFO] [stdout] | ________^ [INFO] [stdout] 183 | | .iter() [INFO] [stdout] 184 | | .enumerate() [INFO] [stdout] 185 | | .map(|(idx, num_args)| { [INFO] [stdout] ... | [INFO] [stdout] 206 | | }) [INFO] [stdout] 207 | | .collect::>()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `substrait-expr-funcgen` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "590f296c2c20e81068199649fb0a9c1352e408935e18051c645e272524be65b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "590f296c2c20e81068199649fb0a9c1352e408935e18051c645e272524be65b2", kill_on_drop: false }` [INFO] [stdout] 590f296c2c20e81068199649fb0a9c1352e408935e18051c645e272524be65b2