[INFO] fetching crate subsrch 0.1.0... [INFO] checking subsrch-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate subsrch 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate subsrch 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate subsrch 0.1.0 [INFO] finished tweaking crates.io crate subsrch 0.1.0 [INFO] tweaked toml for crates.io crate subsrch 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding quote v0.3.15 (latest: v1.0.37) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding structopt v0.1.7 (latest: v0.3.26) [INFO] [stderr] Adding structopt-derive v0.1.6 (latest: v0.4.18) [INFO] [stderr] Adding syn v0.11.11 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding unicode-xid v0.0.4 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 684144c295a1f5d2380bd34beb699db01f3ebb0eb0f7e80af5b9fed398db51fe [INFO] running `Command { std: "docker" "start" "-a" "684144c295a1f5d2380bd34beb699db01f3ebb0eb0f7e80af5b9fed398db51fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "684144c295a1f5d2380bd34beb699db01f3ebb0eb0f7e80af5b9fed398db51fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "684144c295a1f5d2380bd34beb699db01f3ebb0eb0f7e80af5b9fed398db51fe", kill_on_drop: false }` [INFO] [stdout] 684144c295a1f5d2380bd34beb699db01f3ebb0eb0f7e80af5b9fed398db51fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 499227c870b4ac37f9b4ff6e40930e839da7c19dd0d6956681946511538db4da [INFO] running `Command { std: "docker" "start" "-a" "499227c870b4ac37f9b4ff6e40930e839da7c19dd0d6956681946511538db4da", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling structopt-derive v0.1.6 [INFO] [stderr] Checking structopt v0.1.7 [INFO] [stderr] Checking subsrch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/range.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 53 | pub trait RangeStrategy [INFO] [stdout] | ------------- associated function in this trait [INFO] [stdout] ... [INFO] [stdout] 61 | fn new(initial_len: usize) -> Range { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/indices.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | fn select_indices(self, indices: &Indices) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | / self.into_iter() [INFO] [stdout] 12 | | .enumerate() [INFO] [stdout] 13 | | .filter(|&(i, _)| indices.contains(&i)) [INFO] [stdout] 14 | | .map(|(_, t)| t) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/maximal.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 20 | let past_includes: Vec<_> = once(set![]) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let all_elements: HashSet<_> = (0..range.initial_len).collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let unpassed = &all_elements - passed; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | / potential_includes [INFO] [stdout] 38 | | .filter(|i| !past_includes.contains(i)) [INFO] [stdout] 39 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/main.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | let mut s = HashSet::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minimal.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 20 | let past_rejects: Vec<_> = once(set![]) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | / potential_rejects [INFO] [stdout] 34 | | .filter(|r| !past_rejects.contains(r)) [INFO] [stdout] 35 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/main.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | let mut s = HashSet::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range.rs:46:41 [INFO] [stdout] | [INFO] [stdout] 46 | .unwrap_or_else(|| Done(Some(passed.clone()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/searcher.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 23 | let mut child = self.command.spawn().expect("could not spawn child process"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | child.wait().expect("process did not finish").success() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `subsrch` (bin "subsrch") due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/indices.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | fn select_indices(self, indices: &Indices) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | / self.into_iter() [INFO] [stdout] 12 | | .enumerate() [INFO] [stdout] 13 | | .filter(|&(i, _)| indices.contains(&i)) [INFO] [stdout] 14 | | .map(|(_, t)| t) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/maximal.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 20 | let past_includes: Vec<_> = once(set![]) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let all_elements: HashSet<_> = (0..range.initial_len).collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let unpassed = &all_elements - passed; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | / potential_includes [INFO] [stdout] 38 | | .filter(|i| !past_includes.contains(i)) [INFO] [stdout] 39 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/main.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | let mut s = HashSet::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/maximal.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 133 | let mut range = MaximalRange::new(4); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | match range.next() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minimal.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 20 | let past_rejects: Vec<_> = once(set![]) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | / potential_rejects [INFO] [stdout] 34 | | .filter(|r| !past_rejects.contains(r)) [INFO] [stdout] 35 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/main.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | let mut s = HashSet::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minimal.rs:150:15 [INFO] [stdout] | [INFO] [stdout] 145 | let mut range = MinimalRange::new(4); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | match range.next() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range.rs:46:41 [INFO] [stdout] | [INFO] [stdout] 46 | .unwrap_or_else(|| Done(Some(passed.clone()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/searcher.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 23 | let mut child = self.command.spawn().expect("could not spawn child process"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | child.wait().expect("process did not finish").success() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `subsrch` (bin "subsrch" test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "499227c870b4ac37f9b4ff6e40930e839da7c19dd0d6956681946511538db4da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "499227c870b4ac37f9b4ff6e40930e839da7c19dd0d6956681946511538db4da", kill_on_drop: false }` [INFO] [stdout] 499227c870b4ac37f9b4ff6e40930e839da7c19dd0d6956681946511538db4da