[INFO] fetching crate stuart 0.3.1... [INFO] checking stuart-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate stuart 0.3.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate stuart 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate stuart 0.3.1 [INFO] finished tweaking crates.io crate stuart 0.3.1 [INFO] tweaked toml for crates.io crate stuart 0.3.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate stuart 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de55a5993b404fd6cc0501e826e6c0493e80310cd6b8299e4176df3ceabbb9d7 [INFO] running `Command { std: "docker" "start" "-a" "de55a5993b404fd6cc0501e826e6c0493e80310cd6b8299e4176df3ceabbb9d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de55a5993b404fd6cc0501e826e6c0493e80310cd6b8299e4176df3ceabbb9d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de55a5993b404fd6cc0501e826e6c0493e80310cd6b8299e4176df3ceabbb9d7", kill_on_drop: false }` [INFO] [stdout] de55a5993b404fd6cc0501e826e6c0493e80310cd6b8299e4176df3ceabbb9d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f64f9a2c6f73e9a6d2d5f6b9deb72bd775da4ae960e43cf53787e407bdb8071c [INFO] running `Command { std: "docker" "start" "-a" "f64f9a2c6f73e9a6d2d5f6b9deb72bd775da4ae960e43cf53787e407bdb8071c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling rustls v0.21.7 [INFO] [stderr] Compiling anyhow v1.0.62 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling pulldown-cmark v0.9.2 [INFO] [stderr] Checking iana-time-zone v0.1.46 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking humphrey_json v0.2.0 [INFO] [stderr] Checking libloading v0.7.3 [INFO] [stderr] Checking rustls-pemfile v1.0.3 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking rustls-pemfile v0.2.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling include_dir_macros v0.7.2 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking include_dir v0.7.2 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.17 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking clap v3.2.18 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking dateparser v0.1.7 [INFO] [stderr] Checking stuart_core v0.3.1 [INFO] [stderr] Checking rustls-webpki v0.101.6 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking humphrey v0.7.0 [INFO] [stderr] Checking humphrey_ws v0.5.1 [INFO] [stderr] Checking stuart v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 149 | let mut ctx = StuartContext::init(manifest_path, output, "production")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | [INFO] [stdout] 151 | ctx.build().map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 56 | Err(e) => match e.line_col() { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let plugins = plugins::load(&config.dependencies, path.parent().unwrap())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let stuart = Stuart::new(path.parent().unwrap().join("content")) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Ok(StuartContext { [INFO] [stdout] | ____________^ [INFO] [stdout] 115 | | stuart, [INFO] [stdout] 116 | | scripts, [INFO] [stdout] 117 | | stuart_env: stuart_env.into(), [INFO] [stdout] 118 | | project_dir: path.parent().unwrap().to_path_buf(), [INFO] [stdout] 119 | | output: output.into(), [INFO] [stdout] 120 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | .and_then(|path| path.canonicalize().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serve/mod.rs:43:23 [INFO] [stdout] | [INFO] [stdout] 43 | .and_then(|p| p.canonicalize().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serve/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 56 | let state = State { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let app = App::new_with_config(8, state) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | app.run("127.0.0.1:6904") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serve/mod.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 70 | .map_err(|_| Box::new("failed to start development server") as Box) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serve/mod.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 139 | humphrey_ws::websocket_handler(|stream, state: Arc| { [INFO] [stdout] | ------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | state.streams.lock().unwrap().push(stream) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stuart` (bin "stuart" test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 149 | let mut ctx = StuartContext::init(manifest_path, output, "production")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | [INFO] [stdout] 151 | ctx.build().map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 56 | Err(e) => match e.line_col() { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let plugins = plugins::load(&config.dependencies, path.parent().unwrap())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let stuart = Stuart::new(path.parent().unwrap().join("content")) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Ok(StuartContext { [INFO] [stdout] | ____________^ [INFO] [stdout] 115 | | stuart, [INFO] [stdout] 116 | | scripts, [INFO] [stdout] 117 | | stuart_env: stuart_env.into(), [INFO] [stdout] 118 | | project_dir: path.parent().unwrap().to_path_buf(), [INFO] [stdout] 119 | | output: output.into(), [INFO] [stdout] 120 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | .and_then(|path| path.canonicalize().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serve/mod.rs:43:23 [INFO] [stdout] | [INFO] [stdout] 43 | .and_then(|p| p.canonicalize().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serve/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 56 | let state = State { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let app = App::new_with_config(8, state) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | app.run("127.0.0.1:6904") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serve/mod.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 70 | .map_err(|_| Box::new("failed to start development server") as Box) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serve/mod.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 139 | humphrey_ws::websocket_handler(|stream, state: Arc| { [INFO] [stdout] | ------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | state.streams.lock().unwrap().push(stream) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stuart` (bin "stuart") due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "f64f9a2c6f73e9a6d2d5f6b9deb72bd775da4ae960e43cf53787e407bdb8071c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f64f9a2c6f73e9a6d2d5f6b9deb72bd775da4ae960e43cf53787e407bdb8071c", kill_on_drop: false }` [INFO] [stdout] f64f9a2c6f73e9a6d2d5f6b9deb72bd775da4ae960e43cf53787e407bdb8071c