[INFO] fetching crate structsy_tools 0.2.0... [INFO] checking structsy_tools-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate structsy_tools 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate structsy_tools 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate structsy_tools 0.2.0 [INFO] finished tweaking crates.io crate structsy_tools 0.2.0 [INFO] tweaked toml for crates.io crate structsy_tools 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 903f4d4e9dc7d3dc5df817df1061f44b098374edce23de7491a5e1f3c8cb22a0 [INFO] running `Command { std: "docker" "start" "-a" "903f4d4e9dc7d3dc5df817df1061f44b098374edce23de7491a5e1f3c8cb22a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "903f4d4e9dc7d3dc5df817df1061f44b098374edce23de7491a5e1f3c8cb22a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "903f4d4e9dc7d3dc5df817df1061f44b098374edce23de7491a5e1f3c8cb22a0", kill_on_drop: false }` [INFO] [stdout] 903f4d4e9dc7d3dc5df817df1061f44b098374edce23de7491a5e1f3c8cb22a0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a504fb247f7043ac6d2697fa30f1749d3fda32a9fc37bcbfd78c99cef9a24b6 [INFO] running `Command { std: "docker" "start" "-a" "8a504fb247f7043ac6d2697fa30f1749d3fda32a9fc37bcbfd78c99cef9a24b6", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking unsigned-varint v0.8.0 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking zigzag v0.1.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking persy v1.5.1 [INFO] [stderr] Checking structsy v0.5.2 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking structsy_tools v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 17 | let definitions = structsy.list_defined()?.map(|def| Data::Definition(def)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let st = structsy.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let data_iter = structsy [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(definitions.chain(data_iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 18 | let st = structsy.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | / RawRead::raw_scan(&st, &def.get_name()) [INFO] [stdout] 23 | | .ok() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn export_from_snapshot(snapshot: Snapshot) -> Result, StructsyError> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let definitions = snapshot.list_defined()?.map(|def| Data::Definition(def)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let snap = snapshot.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let data_iter = snapshot [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Ok(definitions.chain(data_iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 36 | let snap = snapshot.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | / RawRead::raw_scan(&snap, &def.get_name()) [INFO] [stdout] 41 | | .ok() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `structsy_tools` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8a504fb247f7043ac6d2697fa30f1749d3fda32a9fc37bcbfd78c99cef9a24b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a504fb247f7043ac6d2697fa30f1749d3fda32a9fc37bcbfd78c99cef9a24b6", kill_on_drop: false }` [INFO] [stdout] 8a504fb247f7043ac6d2697fa30f1749d3fda32a9fc37bcbfd78c99cef9a24b6