[INFO] fetching crate structinator 0.1.2... [INFO] checking structinator-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate structinator 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate structinator 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate structinator 0.1.2 [INFO] finished tweaking crates.io crate structinator 0.1.2 [INFO] tweaked toml for crates.io crate structinator 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding structinator_traits v0.1.5 (latest: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `proc_macro` is deprecated in favor of `proc-macro` and will not work in the 2024 edition [INFO] [stderr] (in the `structinator` library target) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fca41725f5df4b89c8e613b2b19dff8bcfe5db5cd974bb21ee639fa3fde35a78 [INFO] running `Command { std: "docker" "start" "-a" "fca41725f5df4b89c8e613b2b19dff8bcfe5db5cd974bb21ee639fa3fde35a78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fca41725f5df4b89c8e613b2b19dff8bcfe5db5cd974bb21ee639fa3fde35a78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fca41725f5df4b89c8e613b2b19dff8bcfe5db5cd974bb21ee639fa3fde35a78", kill_on_drop: false }` [INFO] [stdout] fca41725f5df4b89c8e613b2b19dff8bcfe5db5cd974bb21ee639fa3fde35a78 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54ff433e5c6d7e2e183cd6356d103e8786874ba491103af55b6881ba3aacf886 [INFO] running `Command { std: "docker" "start" "-a" "54ff433e5c6d7e2e183cd6356d103e8786874ba491103af55b6881ba3aacf886", kill_on_drop: false }` [INFO] [stderr] warning: `proc_macro` is deprecated in favor of `proc-macro` and will not work in the 2024 edition [INFO] [stderr] (in the `structinator` library target) [INFO] [stderr] Checking structinator_traits v0.1.5 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking structinator v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 96 | ... let name_copy = field.ident.as_ref().expect("All of the fields in a non-tuple struct should be named").clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ... let name_string = name_copy.to_string(); [INFO] [stdout] 98 | ... let field_type = field.ty.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | / ... syn::parse2(quote! { [INFO] [stdout] 100 | | ... #name_copy: <#field_type as std::convert::TryFrom<#inner_iterator_type>>::try_from(value_storage.remove(#name_string).expect("T... [INFO] [stdout] 101 | | ... }).expect("An unexpected error occured. If the error persists, consider using simpler types with fewer generics") [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `structinator` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 96 | ... let name_copy = field.ident.as_ref().expect("All of the fields in a non-tuple struct should be named").clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ... let name_string = name_copy.to_string(); [INFO] [stdout] 98 | ... let field_type = field.ty.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | / ... syn::parse2(quote! { [INFO] [stdout] 100 | | ... #name_copy: <#field_type as std::convert::TryFrom<#inner_iterator_type>>::try_from(value_storage.remove(#name_string).expect("T... [INFO] [stdout] 101 | | ... }).expect("An unexpected error occured. If the error persists, consider using simpler types with fewer generics") [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `structinator` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "54ff433e5c6d7e2e183cd6356d103e8786874ba491103af55b6881ba3aacf886", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54ff433e5c6d7e2e183cd6356d103e8786874ba491103af55b6881ba3aacf886", kill_on_drop: false }` [INFO] [stdout] 54ff433e5c6d7e2e183cd6356d103e8786874ba491103af55b6881ba3aacf886