[INFO] fetching crate struct-patch-derive 0.8.4... [INFO] checking struct-patch-derive-0.8.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate struct-patch-derive 0.8.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate struct-patch-derive 0.8.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate struct-patch-derive 0.8.4 [INFO] finished tweaking crates.io crate struct-patch-derive 0.8.4 [INFO] tweaked toml for crates.io crate struct-patch-derive 0.8.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f67a813ba778ca6772651fade2fcbcf358087eaa03f42a0a1793756406defcb8 [INFO] running `Command { std: "docker" "start" "-a" "f67a813ba778ca6772651fade2fcbcf358087eaa03f42a0a1793756406defcb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f67a813ba778ca6772651fade2fcbcf358087eaa03f42a0a1793756406defcb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f67a813ba778ca6772651fade2fcbcf358087eaa03f42a0a1793756406defcb8", kill_on_drop: false }` [INFO] [stdout] f67a813ba778ca6772651fade2fcbcf358087eaa03f42a0a1793756406defcb8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc80bf051586e99bba4373112af9784c6c888b19bc8cd8c5e457388862bfa90b [INFO] running `Command { std: "docker" "start" "-a" "cc80bf051586e99bba4373112af9784c6c888b19bc8cd8c5e457388862bfa90b", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking html-escape v0.2.13 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking struct-patch-derive v0.8.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 38 | AddFn(Ident), [INFO] [stdout] | ----- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 38 | AddFn(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `addable` is never read [INFO] [stdout] --> src/lib.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 41 | struct Field { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 46 | addable: Addable, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn derive_patch(item: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | / Patch::from_ast(syn::parse_macro_input!(item as syn::DeriveInput)) [INFO] [stdout] 20 | | .unwrap() [INFO] [stdout] 21 | | .to_token_stream() [INFO] [stdout] 22 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:349:12 [INFO] [stdout] | [INFO] [stdout] 279 | / DeriveInput { [INFO] [stdout] 280 | | ident, [INFO] [stdout] 281 | | data, [INFO] [stdout] 282 | | generics, [INFO] [stdout] 283 | | attrs, [INFO] [stdout] 284 | | vis, [INFO] [stdout] 285 | | }: syn::DeriveInput, [INFO] [stdout] | |___________________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | ) -> Result { [INFO] [stdout] 287 | let original_fields = if let syn::Data::Struct(syn::DataStruct { fields, .. }) = data { [INFO] [stdout] | --------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | let mut name = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let mut attributes = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | let mut fields = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | Ok(Patch { [INFO] [stdout] | ____________^ [INFO] [stdout] 350 | | visibility: vis, [INFO] [stdout] 351 | | patch_struct_name: name.unwrap_or({ [INFO] [stdout] 352 | | let ts = TokenStream::from_str(&format!("{}Patch", &ident,)).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 359 | | fields, [INFO] [stdout] 360 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:458:12 [INFO] [stdout] | [INFO] [stdout] 396 | / syn::Field { [INFO] [stdout] 397 | | ident, ty, attrs, .. [INFO] [stdout] 398 | | }: syn::Field, [INFO] [stdout] | |_____________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 399 | ) -> Result> { [INFO] [stdout] 400 | let mut attributes = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 401 | let mut field_type = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | let mut skip = false; [INFO] [stdout] 403 | let mut addable = Addable::Disable; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 458 | Ok(Some(Field { [INFO] [stdout] | ____________^ [INFO] [stdout] 459 | | ident, [INFO] [stdout] 460 | | retyped: field_type.is_some(), [INFO] [stdout] 461 | | ty: field_type.unwrap_or(ty), [INFO] [stdout] 462 | | attributes, [INFO] [stdout] 463 | | addable, [INFO] [stdout] 464 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `struct-patch-derive` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "cc80bf051586e99bba4373112af9784c6c888b19bc8cd8c5e457388862bfa90b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc80bf051586e99bba4373112af9784c6c888b19bc8cd8c5e457388862bfa90b", kill_on_drop: false }` [INFO] [stdout] cc80bf051586e99bba4373112af9784c6c888b19bc8cd8c5e457388862bfa90b