[INFO] fetching crate strings 0.1.1... [INFO] checking strings-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate strings 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate strings 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate strings 0.1.1 [INFO] finished tweaking crates.io crate strings 0.1.1 [INFO] tweaked toml for crates.io crate strings 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4bc0f9ec9df02e2f151480bff2a518929fbd1f37d5028d034863f7594f24be9d [INFO] running `Command { std: "docker" "start" "-a" "4bc0f9ec9df02e2f151480bff2a518929fbd1f37d5028d034863f7594f24be9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4bc0f9ec9df02e2f151480bff2a518929fbd1f37d5028d034863f7594f24be9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bc0f9ec9df02e2f151480bff2a518929fbd1f37d5028d034863f7594f24be9d", kill_on_drop: false }` [INFO] [stdout] 4bc0f9ec9df02e2f151480bff2a518929fbd1f37d5028d034863f7594f24be9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8b0ba21b0843ed4668a32d8d74b6713334b95db7c614ec47cd88447e058d740b [INFO] running `Command { std: "docker" "start" "-a" "8b0ba21b0843ed4668a32d8d74b6713334b95db7c614ec47cd88447e058d740b", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking strings v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/string_buffer.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 196 | try!(write!(fmt, "{}", node.data)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/string_buffer.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | try!(write!(f, "StringBuffer[{:?}", self.first.data)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/string_buffer.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | try!(write!(f, ", {:?}", next.data)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | try!(write!(fmt, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:259:17 [INFO] [stdout] | [INFO] [stdout] 259 | try!(write!(fmt, "|")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:265:17 [INFO] [stdout] | [INFO] [stdout] 265 | try!(write!(fmt, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:315:17 [INFO] [stdout] | [INFO] [stdout] 315 | try!(write!(fmt, "(")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:321:17 [INFO] [stdout] | [INFO] [stdout] 321 | try!(write!(fmt, ", ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:317:21 [INFO] [stdout] | [INFO] [stdout] 317 | try!(write!(fmt, "left: {:?}", &**left)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:319:21 [INFO] [stdout] | [INFO] [stdout] 319 | try!(write!(fmt, "left: ()")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:323:21 [INFO] [stdout] | [INFO] [stdout] 323 | try!(write!(fmt, "right: {:?}", &**right)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:325:21 [INFO] [stdout] | [INFO] [stdout] 325 | try!(write!(fmt, "right: ()")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | try!(write!(fmt, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | try!(write!(fmt, "|")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 309 | try!(write!(fmt, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:359:17 [INFO] [stdout] | [INFO] [stdout] 359 | try!(write!(fmt, "(")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:365:17 [INFO] [stdout] | [INFO] [stdout] 365 | try!(write!(fmt, ", ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:361:21 [INFO] [stdout] | [INFO] [stdout] 361 | try!(write!(fmt, "left: {:?}", &**left)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:363:21 [INFO] [stdout] | [INFO] [stdout] 363 | try!(write!(fmt, "left: ()")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:367:21 [INFO] [stdout] | [INFO] [stdout] 367 | try!(write!(fmt, "right: {:?}", &**right)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:369:21 [INFO] [stdout] | [INFO] [stdout] 369 | try!(write!(fmt, "right: ()")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/ropes/src_rope.rs:1017:13 [INFO] [stdout] | [INFO] [stdout] 1017 | (src_loc as isize + self.src_offset) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1017 - (src_loc as isize + self.src_offset) [INFO] [stdout] 1017 + src_loc as isize + self.src_offset [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/string_buffer.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 196 | try!(write!(fmt, "{}", node.data)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/string_buffer.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | try!(write!(f, "StringBuffer[{:?}", self.first.data)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/string_buffer.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | try!(write!(f, ", {:?}", next.data)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | try!(write!(fmt, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:259:17 [INFO] [stdout] | [INFO] [stdout] 259 | try!(write!(fmt, "|")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:265:17 [INFO] [stdout] | [INFO] [stdout] 265 | try!(write!(fmt, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:315:17 [INFO] [stdout] | [INFO] [stdout] 315 | try!(write!(fmt, "(")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:321:17 [INFO] [stdout] | [INFO] [stdout] 321 | try!(write!(fmt, ", ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:317:21 [INFO] [stdout] | [INFO] [stdout] 317 | try!(write!(fmt, "left: {:?}", &**left)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:319:21 [INFO] [stdout] | [INFO] [stdout] 319 | try!(write!(fmt, "left: ()")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:323:21 [INFO] [stdout] | [INFO] [stdout] 323 | try!(write!(fmt, "right: {:?}", &**right)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/rope.rs:325:21 [INFO] [stdout] | [INFO] [stdout] 325 | try!(write!(fmt, "right: ()")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | try!(write!(fmt, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | try!(write!(fmt, "|")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 309 | try!(write!(fmt, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:359:17 [INFO] [stdout] | [INFO] [stdout] 359 | try!(write!(fmt, "(")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:365:17 [INFO] [stdout] | [INFO] [stdout] 365 | try!(write!(fmt, ", ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:361:21 [INFO] [stdout] | [INFO] [stdout] 361 | try!(write!(fmt, "left: {:?}", &**left)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:363:21 [INFO] [stdout] | [INFO] [stdout] 363 | try!(write!(fmt, "left: ()")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:367:21 [INFO] [stdout] | [INFO] [stdout] 367 | try!(write!(fmt, "right: {:?}", &**right)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/ropes/src_rope.rs:369:21 [INFO] [stdout] | [INFO] [stdout] 369 | try!(write!(fmt, "right: ()")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/ropes/src_rope.rs:1017:13 [INFO] [stdout] | [INFO] [stdout] 1017 | (src_loc as isize + self.src_offset) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1017 - (src_loc as isize + self.src_offset) [INFO] [stdout] 1017 + src_loc as isize + self.src_offset [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/string_buffer.rs:264:17 [INFO] [stdout] | [INFO] [stdout] 264 | let mut last = &mut *result.first; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ropes/macros.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 29 | do_remove: F) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match do_remove(self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/ropes/rope.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | impl_rope!(Rope); [INFO] [stdout] | ---------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `impl_rope` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ropes/rope.rs:373:25 [INFO] [stdout] | [INFO] [stdout] 369 | fn new_inner(left: Option>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 370 | right: Option>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Node::InnerNode(Inode { [INFO] [stdout] | _________________________^ [INFO] [stdout] 374 | | left: left, [INFO] [stdout] 375 | | right: right, [INFO] [stdout] 376 | | weight: weight, [INFO] [stdout] 377 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ropes/macros.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 29 | do_remove: F) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match do_remove(self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/ropes/src_rope.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | impl_rope!(Rope); [INFO] [stdout] | ---------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_rope` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ropes/src_rope.rs:422:25 [INFO] [stdout] | [INFO] [stdout] 417 | fn new_inner(left: Option>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | right: Option>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 422 | Node::InnerNode(Inode { [INFO] [stdout] | _________________________^ [INFO] [stdout] 423 | | left: left, [INFO] [stdout] 424 | | right: right, [INFO] [stdout] 425 | | weight: weight, [INFO] [stdout] 426 | | src_weight: src_weight, [INFO] [stdout] 427 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/string_buffer.rs:264:17 [INFO] [stdout] | [INFO] [stdout] 264 | let mut last = &mut *result.first; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `strings` (lib) due to 5 previous errors; 23 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ropes/macros.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 29 | do_remove: F) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match do_remove(self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/ropes/rope.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | impl_rope!(Rope); [INFO] [stdout] | ---------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `impl_rope` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ropes/rope.rs:373:25 [INFO] [stdout] | [INFO] [stdout] 369 | fn new_inner(left: Option>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 370 | right: Option>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Node::InnerNode(Inode { [INFO] [stdout] | _________________________^ [INFO] [stdout] 374 | | left: left, [INFO] [stdout] 375 | | right: right, [INFO] [stdout] 376 | | weight: weight, [INFO] [stdout] 377 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ropes/macros.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 29 | do_remove: F) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match do_remove(self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/ropes/src_rope.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | impl_rope!(Rope); [INFO] [stdout] | ---------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_rope` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ropes/src_rope.rs:422:25 [INFO] [stdout] | [INFO] [stdout] 417 | fn new_inner(left: Option>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | right: Option>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 422 | Node::InnerNode(Inode { [INFO] [stdout] | _________________________^ [INFO] [stdout] 423 | | left: left, [INFO] [stdout] 424 | | right: right, [INFO] [stdout] 425 | | weight: weight, [INFO] [stdout] 426 | | src_weight: src_weight, [INFO] [stdout] 427 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `strings` (lib test) due to 5 previous errors; 23 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8b0ba21b0843ed4668a32d8d74b6713334b95db7c614ec47cd88447e058d740b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b0ba21b0843ed4668a32d8d74b6713334b95db7c614ec47cd88447e058d740b", kill_on_drop: false }` [INFO] [stdout] 8b0ba21b0843ed4668a32d8d74b6713334b95db7c614ec47cd88447e058d740b