[INFO] fetching crate streaming-libdeflate-rs 0.1.6... [INFO] checking streaming-libdeflate-rs-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate streaming-libdeflate-rs 0.1.6 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate streaming-libdeflate-rs 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate streaming-libdeflate-rs 0.1.6 [INFO] finished tweaking crates.io crate streaming-libdeflate-rs 0.1.6 [INFO] tweaked toml for crates.io crate streaming-libdeflate-rs 0.1.6 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate streaming-libdeflate-rs 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c57a2903e80c8a4207ab844c9c078f91946cdafa88b77a82f56aed28e8f1fc0b [INFO] running `Command { std: "docker" "start" "-a" "c57a2903e80c8a4207ab844c9c078f91946cdafa88b77a82f56aed28e8f1fc0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c57a2903e80c8a4207ab844c9c078f91946cdafa88b77a82f56aed28e8f1fc0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c57a2903e80c8a4207ab844c9c078f91946cdafa88b77a82f56aed28e8f1fc0b", kill_on_drop: false }` [INFO] [stdout] c57a2903e80c8a4207ab844c9c078f91946cdafa88b77a82f56aed28e8f1fc0b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c29403d0e60f2c4692e70c19b1162c2f01f38773bf0e5e574e411f594c02f7f [INFO] running `Command { std: "docker" "start" "-a" "2c29403d0e60f2c4692e70c19b1162c2f01f38773bf0e5e574e411f594c02f7f", kill_on_drop: false }` [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking filebuffer v1.0.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking nightly-quirks v0.1.5 [INFO] [stderr] Checking mt-debug-counters v0.1.4 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking streaming-libdeflate-rs v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:134:46 [INFO] [stdout] | [INFO] [stdout] 134 | DeflateChunkedBufferInput::new(|buf| read_file.read(buf).unwrap_or(0), buf_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams/deflate_chunked_buffer_input.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new usize + 'a>(read_func: F, buf_size: usize) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Self { [INFO] [stdout] 15 | buffer: unsafe { NightlyUtils::box_new_uninit_slice_assume_init(buf_size) }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams/deflate_chunked_buffer_input.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new usize + 'a>(read_func: F, buf_size: usize) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | func: Box::new(read_func), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams/deflate_chunked_buffer_output.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new Result<(), ()> + 'a>(write_func: F, buf_size: usize) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | buffer: unsafe { NightlyUtils::box_new_uninit_slice_assume_init(buf_size) }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams/deflate_chunked_buffer_output.rs:34:19 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new Result<(), ()> + 'a>(write_func: F, buf_size: usize) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | func: Box::new(write_func), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams/deflate_filebuffer_input.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(path: impl AsRef) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self { [INFO] [stdout] 14 | file: FileBuffer::open(path).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `streaming-libdeflate-rs` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:134:46 [INFO] [stdout] | [INFO] [stdout] 134 | DeflateChunkedBufferInput::new(|buf| read_file.read(buf).unwrap_or(0), buf_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams/deflate_chunked_buffer_input.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new usize + 'a>(read_func: F, buf_size: usize) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Self { [INFO] [stdout] 15 | buffer: unsafe { NightlyUtils::box_new_uninit_slice_assume_init(buf_size) }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams/deflate_chunked_buffer_input.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new usize + 'a>(read_func: F, buf_size: usize) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | func: Box::new(read_func), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams/deflate_chunked_buffer_output.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new Result<(), ()> + 'a>(write_func: F, buf_size: usize) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | buffer: unsafe { NightlyUtils::box_new_uninit_slice_assume_init(buf_size) }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams/deflate_chunked_buffer_output.rs:34:19 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new Result<(), ()> + 'a>(write_func: F, buf_size: usize) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | func: Box::new(write_func), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams/deflate_filebuffer_input.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(path: impl AsRef) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self { [INFO] [stdout] 14 | file: FileBuffer::open(path).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `streaming-libdeflate-rs` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "2c29403d0e60f2c4692e70c19b1162c2f01f38773bf0e5e574e411f594c02f7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c29403d0e60f2c4692e70c19b1162c2f01f38773bf0e5e574e411f594c02f7f", kill_on_drop: false }` [INFO] [stdout] 2c29403d0e60f2c4692e70c19b1162c2f01f38773bf0e5e574e411f594c02f7f