[INFO] fetching crate story-line-counter 1.0.0... [INFO] checking story-line-counter-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate story-line-counter 1.0.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate story-line-counter 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate story-line-counter 1.0.0 [INFO] finished tweaking crates.io crate story-line-counter 1.0.0 [INFO] tweaked toml for crates.io crate story-line-counter 1.0.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.7.20 (latest: v1.1.3) [INFO] [stderr] Adding ansi_term v0.11.0 (latest: v0.12.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.33.4 (latest: v4.5.16) [INFO] [stderr] Adding git2 v0.9.2 (latest: v0.19.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding libgit2-sys v0.8.2 (latest: v0.17.0+1.8.1) [INFO] [stderr] Adding libssh2-sys v0.2.23 (latest: v0.3.0) [INFO] [stderr] Adding regex v1.2.1 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] [stderr] Adding yaml-rust v0.3.5 (latest: v0.4.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cb27fd01b18380eb566ccf32376b16b1a42a43187c5d2ff04b762def0b32f65d [INFO] running `Command { std: "docker" "start" "-a" "cb27fd01b18380eb566ccf32376b16b1a42a43187c5d2ff04b762def0b32f65d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cb27fd01b18380eb566ccf32376b16b1a42a43187c5d2ff04b762def0b32f65d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb27fd01b18380eb566ccf32376b16b1a42a43187c5d2ff04b762def0b32f65d", kill_on_drop: false }` [INFO] [stdout] cb27fd01b18380eb566ccf32376b16b1a42a43187c5d2ff04b762def0b32f65d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9be6cfe6dab238dede2b4399c3a0f31619d3113dcbd6e57d127a0a49cf56452 [INFO] running `Command { std: "docker" "start" "-a" "f9be6cfe6dab238dede2b4399c3a0f31619d3113dcbd6e57d127a0a49cf56452", kill_on_drop: false }` [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking clap v2.33.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.8.2 [INFO] [stderr] Checking regex v1.2.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking git2 v0.9.2 [INFO] [stderr] Checking story-line-counter v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:53:71 [INFO] [stdout] | [INFO] [stdout] 53 | Category::Io => format!("An IO error occurred: {}", error.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:54:78 [INFO] [stdout] | [INFO] [stdout] 54 | Category::Syntax => format!("A syntax error occurred: {}", error.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:55:74 [INFO] [stdout] | [INFO] [stdout] 55 | Category::Data => format!("A data error occurred: {}", error.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:56:66 [INFO] [stdout] | [INFO] [stdout] 56 | Category::Eof => format!("Unexpected EOF. {}", error.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:87:43 [INFO] [stdout] | [INFO] [stdout] 87 | CliError::Git(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:88:42 [INFO] [stdout] | [INFO] [stdout] 88 | CliError::IO(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:89:45 [INFO] [stdout] | [INFO] [stdout] 89 | CliError::Input(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:53:71 [INFO] [stdout] | [INFO] [stdout] 53 | Category::Io => format!("An IO error occurred: {}", error.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:54:78 [INFO] [stdout] | [INFO] [stdout] 54 | Category::Syntax => format!("A syntax error occurred: {}", error.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:55:74 [INFO] [stdout] | [INFO] [stdout] 55 | Category::Data => format!("A data error occurred: {}", error.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:56:66 [INFO] [stdout] | [INFO] [stdout] 56 | Category::Eof => format!("Unexpected EOF. {}", error.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:87:43 [INFO] [stdout] | [INFO] [stdout] 87 | CliError::Git(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:88:42 [INFO] [stdout] | [INFO] [stdout] 88 | CliError::IO(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:89:45 [INFO] [stdout] | [INFO] [stdout] 89 | CliError::Input(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `branch` is never read [INFO] [stdout] --> src/repo/core.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct RepoPosition<'repo> { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 4 | pub repository: &'repo Repository, [INFO] [stdout] 5 | pub branch: Branch<'repo>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/mod.rs:121:10 [INFO] [stdout] | [INFO] [stdout] 107 | let mut diff_options = DiffOptions::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let first_commit = get_commit(&repository, &first_oid).unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let second_commit = get_commit(&repository, &second_oid).unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | [INFO] [stdout] 113 | let diff = repository [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Some(CommitPair { [INFO] [stdout] | __________^ [INFO] [stdout] 122 | | first: first_commit, [INFO] [stdout] 123 | | second: second_commit, [INFO] [stdout] 124 | | diff, [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/core.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 21 | let branch = get_branch(repository, branch_name, BranchType::Local)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let head = branch.get().peel_to_commit()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | [INFO] [stdout] 24 | Ok(RepoPosition { [INFO] [stdout] | ________^ [INFO] [stdout] 25 | | repository: &repository, [INFO] [stdout] 26 | | branch, [INFO] [stdout] 27 | | commit: head, [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `story-line-counter` (bin "story-line-counter") due to 3 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `branch` is never read [INFO] [stdout] --> src/repo/core.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct RepoPosition<'repo> { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 4 | pub repository: &'repo Repository, [INFO] [stdout] 5 | pub branch: Branch<'repo>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/mod.rs:121:10 [INFO] [stdout] | [INFO] [stdout] 107 | let mut diff_options = DiffOptions::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let first_commit = get_commit(&repository, &first_oid).unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let second_commit = get_commit(&repository, &second_oid).unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | [INFO] [stdout] 113 | let diff = repository [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Some(CommitPair { [INFO] [stdout] | __________^ [INFO] [stdout] 122 | | first: first_commit, [INFO] [stdout] 123 | | second: second_commit, [INFO] [stdout] 124 | | diff, [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/core.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 21 | let branch = get_branch(repository, branch_name, BranchType::Local)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let head = branch.get().peel_to_commit()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | [INFO] [stdout] 24 | Ok(RepoPosition { [INFO] [stdout] | ________^ [INFO] [stdout] 25 | | repository: &repository, [INFO] [stdout] 26 | | branch, [INFO] [stdout] 27 | | commit: head, [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `story-line-counter` (bin "story-line-counter" test) due to 3 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f9be6cfe6dab238dede2b4399c3a0f31619d3113dcbd6e57d127a0a49cf56452", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9be6cfe6dab238dede2b4399c3a0f31619d3113dcbd6e57d127a0a49cf56452", kill_on_drop: false }` [INFO] [stdout] f9be6cfe6dab238dede2b4399c3a0f31619d3113dcbd6e57d127a0a49cf56452