[INFO] fetching crate stens 0.9.0... [INFO] checking stens-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate stens 0.9.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate stens 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate stens 0.9.0 [INFO] finished tweaking crates.io crate stens 0.9.0 [INFO] tweaked toml for crates.io crate stens 0.9.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding amplify v3.14.2 (latest: v4.7.0) [INFO] [stderr] Adding amplify_derive v2.11.3 (latest: v4.0.1) [INFO] [stderr] Adding amplify_num v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding amplify_syn v1.1.6 (latest: v2.0.1) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (latest: v0.14.0) [INFO] [stderr] Adding darling v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding encoding_derive_helpers v0.8.1 (latest: v1.7.6) [INFO] [stderr] Adding serde_with v1.14.0 (latest: v3.9.0) [INFO] [stderr] Adding serde_with_macros v1.5.2 (latest: v3.9.0) [INFO] [stderr] Adding strict_encoding v0.9.0 (latest: v2.7.0) [INFO] [stderr] Adding strict_encoding_derive v0.9.0 (latest: v2.7.0) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6344d5bbb7badaac32b44bd711a64ed5544f5f52ce93eb2bc0db1041475f6f5c [INFO] running `Command { std: "docker" "start" "-a" "6344d5bbb7badaac32b44bd711a64ed5544f5f52ce93eb2bc0db1041475f6f5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6344d5bbb7badaac32b44bd711a64ed5544f5f52ce93eb2bc0db1041475f6f5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6344d5bbb7badaac32b44bd711a64ed5544f5f52ce93eb2bc0db1041475f6f5c", kill_on_drop: false }` [INFO] [stdout] 6344d5bbb7badaac32b44bd711a64ed5544f5f52ce93eb2bc0db1041475f6f5c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 760d4fc66420c88bff3b8d6d0aa9158189b24d47d9ba4bf9c4bccf5fa97435ce [INFO] running `Command { std: "docker" "start" "-a" "760d4fc66420c88bff3b8d6d0aa9158189b24d47d9ba4bf9c4bccf5fa97435ce", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling amplify_num v0.4.1 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking amplify_syn v1.1.6 [INFO] [stderr] Compiling amplify_derive v2.11.3 [INFO] [stderr] Compiling amplify v3.14.2 [INFO] [stderr] Compiling encoding_derive_helpers v0.8.1 [INFO] [stderr] Compiling strict_encoding_derive v0.9.0 [INFO] [stderr] Checking strict_encoding v0.9.0 [INFO] [stderr] Checking stens v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 359 | fn strict_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | let ty = u8::strict_decode(&mut d)?; [INFO] [stdout] 361 | Ok(match ty { [INFO] [stdout] | ____________^ [INFO] [stdout] 362 | | 0x00 => Self::Plain(StrictDecode::strict_decode(&mut d)?), [INFO] [stdout] 363 | | 0x10 => Self::Array( [INFO] [stdout] 364 | | StrictDecode::strict_decode(&mut d)?, [INFO] [stdout] ... | [INFO] [stdout] 375 | | } [INFO] [stdout] 376 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection.rs:187:12 [INFO] [stdout] | [INFO] [stdout] 174 | fn strict_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let mut data = Vec::::with_capacity(len as usize); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Ok(Self(data)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection.rs:280:12 [INFO] [stdout] | [INFO] [stdout] 261 | fn strict_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | let mut data = BTreeSet::::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | Ok(Self(data)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection.rs:388:12 [INFO] [stdout] | [INFO] [stdout] 368 | fn strict_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | let mut data = BTreeMap::::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | Ok(Self(data)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stens` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/schema.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 359 | fn strict_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | let ty = u8::strict_decode(&mut d)?; [INFO] [stdout] 361 | Ok(match ty { [INFO] [stdout] | ____________^ [INFO] [stdout] 362 | | 0x00 => Self::Plain(StrictDecode::strict_decode(&mut d)?), [INFO] [stdout] 363 | | 0x10 => Self::Array( [INFO] [stdout] 364 | | StrictDecode::strict_decode(&mut d)?, [INFO] [stdout] ... | [INFO] [stdout] 375 | | } [INFO] [stdout] 376 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection.rs:187:12 [INFO] [stdout] | [INFO] [stdout] 174 | fn strict_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let mut data = Vec::::with_capacity(len as usize); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Ok(Self(data)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection.rs:280:12 [INFO] [stdout] | [INFO] [stdout] 261 | fn strict_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | let mut data = BTreeSet::::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | Ok(Self(data)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection.rs:388:12 [INFO] [stdout] | [INFO] [stdout] 368 | fn strict_decode(mut d: D) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | let mut data = BTreeMap::::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | Ok(Self(data)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stens` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "760d4fc66420c88bff3b8d6d0aa9158189b24d47d9ba4bf9c4bccf5fa97435ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "760d4fc66420c88bff3b8d6d0aa9158189b24d47d9ba4bf9c4bccf5fa97435ce", kill_on_drop: false }` [INFO] [stdout] 760d4fc66420c88bff3b8d6d0aa9158189b24d47d9ba4bf9c4bccf5fa97435ce