[INFO] fetching crate steiner-tree 0.0.5... [INFO] checking steiner-tree-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate steiner-tree 0.0.5 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate steiner-tree 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate steiner-tree 0.0.5 [INFO] finished tweaking crates.io crate steiner-tree 0.0.5 [INFO] tweaked toml for crates.io crate steiner-tree 0.0.5 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate steiner-tree 0.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c63f30f27991d5b060ebbb2fc29d33ce3b7b6ee60af34f03066895807a2033a [INFO] running `Command { std: "docker" "start" "-a" "6c63f30f27991d5b060ebbb2fc29d33ce3b7b6ee60af34f03066895807a2033a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c63f30f27991d5b060ebbb2fc29d33ce3b7b6ee60af34f03066895807a2033a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c63f30f27991d5b060ebbb2fc29d33ce3b7b6ee60af34f03066895807a2033a", kill_on_drop: false }` [INFO] [stdout] 6c63f30f27991d5b060ebbb2fc29d33ce3b7b6ee60af34f03066895807a2033a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c3d3a613120145d73564f03f277cfe81d4fcc3cc7434f3d67aec6bbe43c8ceb3 [INFO] running `Command { std: "docker" "start" "-a" "c3d3a613120145d73564f03f277cfe81d4fcc3cc7434f3d67aec6bbe43c8ceb3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.10 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling serde_derive v1.0.139 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling crossbeam-epoch v0.9.9 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling serde v1.0.139 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking wyz v0.5.0 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking plotters-backend v0.3.4 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking bitvec v1.0.0 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking crossbeam-channel v0.5.5 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking plotters-svg v0.3.2 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking clap_builder v4.3.19 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking plotters v0.3.2 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.3.19 [INFO] [stderr] Checking steiner-tree v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen_lut.rs:255:53 [INFO] [stdout] | [INFO] [stdout] 255 | .map(|tree| ExpansionStage::new(compaction_stage.clone(), tree)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen_lut.rs:282:49 [INFO] [stdout] | [INFO] [stdout] 282 | .map(|tree| ExpansionStage::new(compaction_stage.clone(), tree)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen_lut.rs:337:57 [INFO] [stdout] | [INFO] [stdout] 337 | .map(|tree| ExpansionStage::new(compaction_stage.clone(), tree)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen_lut.rs:359:21 [INFO] [stdout] | [INFO] [stdout] 356 | let (compacted, expansion_op) = compaction_stage.clone().compact_boundary(*b); [INFO] [stdout] | --------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | let trees = gen_lut(compacted, cache); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 358 | // Expand all. [INFO] [stdout] 359 | / trees [INFO] [stdout] 360 | | .into_iter() [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen_lut.rs:361:30 [INFO] [stdout] | [INFO] [stdout] 356 | let (compacted, expansion_op) = compaction_stage.clone().compact_boundary(*b); [INFO] [stdout] | --------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | let trees = gen_lut(compacted, cache); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | .map(move |t| t.expand_boundary(&expansion_op)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen_lut.rs:796:50 [INFO] [stdout] | [INFO] [stdout] 796 | .map(|t| ExpansionStage::new(compaction_stage.clone(), t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compaction_expansion.rs:126:27 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(compaction_stage: CompactionStage, initial_tree: Tree) -> ExpansionStage { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | current_pins: compaction_stage.current_pins.into_canonical_form(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterator_set_operations.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 80 | fn net_set_op(a: A, b: B) -> SetOpIter [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | a: a.into_iter().peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterator_set_operations.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 80 | fn net_set_op(a: A, b: B) -> SetOpIter [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | b: b.into_iter().peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minimum_spanning_tree/nearest_neighbor.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(hasher: LSH) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Self { [INFO] [stdout] 28 | bins: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minimum_spanning_tree/nearest_neighbor.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn insert(&mut self, value: T) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let hash = self.hasher.hash(&value); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | self.bins.entry(hash).or_default().push(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minimum_spanning_tree/nearest_neighbor.rs:124:24 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn new(hasher: LSH) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | Self { [INFO] [stdout] 124 | hash_bins: HashBins::new(hasher), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pins.rs:186:10 [INFO] [stdout] | [INFO] [stdout] 159 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let mut moved_points = SmallVec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | (self.into_non_canonical(), moved_points) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:453:26 [INFO] [stdout] | [INFO] [stdout] 452 | let mut nodes = self.all_nodes(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 453 | nodes.next().map(|first_node| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 454 | | let mut lower_left = first_node; [INFO] [stdout] 455 | | let mut upper_right = first_node; [INFO] [stdout] ... | [INFO] [stdout] 464 | | Rect::new(lower_left, upper_right) [INFO] [stdout] 465 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `steiner-tree` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "c3d3a613120145d73564f03f277cfe81d4fcc3cc7434f3d67aec6bbe43c8ceb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3d3a613120145d73564f03f277cfe81d4fcc3cc7434f3d67aec6bbe43c8ceb3", kill_on_drop: false }` [INFO] [stdout] c3d3a613120145d73564f03f277cfe81d4fcc3cc7434f3d67aec6bbe43c8ceb3