[INFO] fetching crate steganer 1.1.0-post4... [INFO] checking steganer-1.1.0-post4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate steganer 1.1.0-post4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate steganer 1.1.0-post4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate steganer 1.1.0-post4 [INFO] finished tweaking crates.io crate steganer 1.1.0-post4 [INFO] tweaked toml for crates.io crate steganer 1.1.0-post4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate steganer 1.1.0-post4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a84daf75463882ba3cdb8c77d274a537b824811b5e789ed7f06ffe3048994f2e [INFO] running `Command { std: "docker" "start" "-a" "a84daf75463882ba3cdb8c77d274a537b824811b5e789ed7f06ffe3048994f2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a84daf75463882ba3cdb8c77d274a537b824811b5e789ed7f06ffe3048994f2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a84daf75463882ba3cdb8c77d274a537b824811b5e789ed7f06ffe3048994f2e", kill_on_drop: false }` [INFO] [stdout] a84daf75463882ba3cdb8c77d274a537b824811b5e789ed7f06ffe3048994f2e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 51c9aa83f14f663534a5d726459b42c9d82d08770e8968ef009b2363e18388a3 [INFO] running `Command { std: "docker" "start" "-a" "51c9aa83f14f663534a5d726459b42c9d82d08770e8968ef009b2363e18388a3", kill_on_drop: false }` [INFO] [stderr] warning: steganer v1.1.0-post4 (/opt/rustwide/workdir) ignoring invalid dependency `pyo3-pack` which is missing a lib target [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling proc-macro2 v1.0.5 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling cc v1.0.45 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling serde v1.0.101 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling ryu v1.0.1 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling bitflags v1.2.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling num-bigint v0.2.3 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Compiling thread_local v0.3.6 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling aho-corasick v0.7.6 [INFO] [stderr] Compiling itoa v0.4.4 [INFO] [stderr] Compiling regex-syntax v0.6.12 [INFO] [stderr] Compiling num-complex v0.2.3 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling unindent v0.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Compiling error-chain v0.12.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking bitreader v0.3.2 [INFO] [stderr] Checking untrusted v0.6.2 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Compiling ring v0.14.6 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking png v0.14.1 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking backtrace v0.3.38 [INFO] [stderr] Compiling regex v1.3.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking jpeg-decoder v0.1.16 [INFO] [stderr] Checking tiff v0.2.2 [INFO] [stderr] Checking image v0.21.3 [INFO] [stderr] Compiling pyo3-derive-backend v0.8.1 [INFO] [stderr] Checking test_common v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.101 [INFO] [stderr] Compiling proc-macro-hack v0.5.10 [INFO] [stderr] Compiling ctor v0.1.12 [INFO] [stderr] Compiling inventory-impl v0.1.4 [INFO] [stderr] Compiling ghost v0.1.1 [INFO] [stderr] Checking inventory v0.1.4 [INFO] [stderr] Compiling paste-impl v0.1.6 [INFO] [stderr] Compiling indoc-impl v0.3.4 [INFO] [stderr] Checking indoc v0.3.4 [INFO] [stderr] Checking paste v0.1.6 [INFO] [stderr] Compiling pyo3cls v0.8.1 [INFO] [stderr] Compiling serde_json v1.0.41 [INFO] [stderr] Compiling pyo3 v0.8.1 [INFO] [stderr] Checking steganer v1.1.0-post4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/fileio.rs:378:27 [INFO] [stdout] | [INFO] [stdout] 378 | use std::io::{Cursor, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/fileio.rs:446:39 [INFO] [stdout] | [INFO] [stdout] 446 | fn test_iterator_next_under_8() { ; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/fileio.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/stegimage.rs:374:47 [INFO] [stdout] | [INFO] [stdout] 374 | let message: &str = error.description(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_image` is never used [INFO] [stdout] --> src/stegimage.rs:272:8 [INFO] [stdout] | [INFO] [stdout] 84 | impl <'a> ContainerImage <'a>{ [INFO] [stdout] | ----------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 272 | fn get_image(&mut self)-> &mut DynamicImage { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/fileio.rs:193:50 [INFO] [stdout] | [INFO] [stdout] 193 | bit_reader: BitReader::new(file_bytes.clone()), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fileio.rs:256:12 [INFO] [stdout] | [INFO] [stdout] 253 | let destination = File::create(destination_file) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | Ok(FileWriter{destination, pending_data: initial_remainder}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `steganer` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: value assigned to `pixel` is never read [INFO] [stdout] --> src/stegimage.rs:482:17 [INFO] [stdout] | [INFO] [stdout] 482 | let mut pixel = container.get_image().get_pixel(0,0); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pixel` is never read [INFO] [stdout] --> src/stegimage.rs:506:17 [INFO] [stdout] | [INFO] [stdout] 506 | let mut pixel = container.get_image().get_pixel(0,0); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pixel` is never read [INFO] [stdout] --> src/stegimage.rs:548:17 [INFO] [stdout] | [INFO] [stdout] 548 | let mut pixel = container.get_image().get_pixel(0,0); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pixel` is never read [INFO] [stdout] --> src/stegimage.rs:572:17 [INFO] [stdout] | [INFO] [stdout] 572 | let mut pixel = container.get_image().get_pixel(0,0); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/fileio.rs:193:50 [INFO] [stdout] | [INFO] [stdout] 193 | bit_reader: BitReader::new(file_bytes.clone()), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fileio.rs:256:12 [INFO] [stdout] | [INFO] [stdout] 253 | let destination = File::create(destination_file) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | Ok(FileWriter{destination, pending_data: initial_remainder}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `steganer` (lib test) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "51c9aa83f14f663534a5d726459b42c9d82d08770e8968ef009b2363e18388a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51c9aa83f14f663534a5d726459b42c9d82d08770e8968ef009b2363e18388a3", kill_on_drop: false }` [INFO] [stdout] 51c9aa83f14f663534a5d726459b42c9d82d08770e8968ef009b2363e18388a3