[INFO] fetching crate steamlocate 2.0.0-beta.2... [INFO] checking steamlocate-2.0.0-beta.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate steamlocate 2.0.0-beta.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate steamlocate 2.0.0-beta.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate steamlocate 2.0.0-beta.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate steamlocate 2.0.0-beta.2 [INFO] tweaked toml for crates.io crate steamlocate 2.0.0-beta.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate steamlocate 2.0.0-beta.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 71af6bdb80e555d320ebea0ba0ed75428967919d9c40a8c1502773db59ab1833 [INFO] running `Command { std: "docker" "start" "-a" "71af6bdb80e555d320ebea0ba0ed75428967919d9c40a8c1502773db59ab1833", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "71af6bdb80e555d320ebea0ba0ed75428967919d9c40a8c1502773db59ab1833", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71af6bdb80e555d320ebea0ba0ed75428967919d9c40a8c1502773db59ab1833", kill_on_drop: false }` [INFO] [stdout] 71af6bdb80e555d320ebea0ba0ed75428967919d9c40a8c1502773db59ab1833 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a7ee0f10135e1a4632cd5e91bf0204d4c286b23d999a8270a6d76dc849a408f [INFO] running `Command { std: "docker" "start" "-a" "5a7ee0f10135e1a4632cd5e91bf0204d4c286b23d999a8270a6d76dc849a408f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.89 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling bumpalo v3.14.0 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Compiling wasm-bindgen v0.2.89 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking crc-catalog v2.2.0 [INFO] [stderr] Checking similar v2.3.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking crc v3.0.1 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.89 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.39 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.89 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Compiling pest v2.7.5 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.89 [INFO] [stderr] Compiling pest_meta v2.7.5 [INFO] [stderr] Checking js-sys v0.3.66 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Compiling pest_generator v2.7.5 [INFO] [stderr] Compiling pest_derive v2.7.5 [INFO] [stderr] Checking keyvalues-parser v0.2.0 [INFO] [stderr] Checking keyvalues-serde v0.2.0 [INFO] [stderr] Checking ron v0.7.1 [INFO] [stderr] Checking steamlocate v2.0.0-beta.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking wasm-bindgen-futures v0.4.39 [INFO] [stderr] Checking wasm-bindgen-test v0.3.39 [INFO] [stderr] Checking insta v1.34.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 212 | let store: config::Store = keyvalues_serde::from_str(&vdf_text).map_err(|de| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | ParseError::from_serde(de), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | keyvalues_serde::from_str(&contents) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:110:62 [INFO] [stdout] | [INFO] [stdout] 110 | .map_err(|err| Error::parse(ParseErrorKind::App, ParseError::from_serde(err), manifest)) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:226:20 [INFO] [stdout] | [INFO] [stdout] 224 | pub(crate) fn new(inner: ParseErrorInner) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | Self { [INFO] [stdout] 226 | inner: Box::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:235:19 [INFO] [stdout] | [INFO] [stdout] 234 | pub(crate) fn from_serde(err: keyvalues_serde::error::Error) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | Self::new(ParseErrorInner::Serde(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:54:36 [INFO] [stdout] | [INFO] [stdout] 54 | .map_err(|err| parse_error(ParseError::from_parser(err)))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:58:36 [INFO] [stdout] | [INFO] [stdout] 58 | .ok_or_else(|| parse_error(ParseError::unexpected_structure()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/library.rs:69:44 [INFO] [stdout] | [INFO] [stdout] 69 | .ok_or_else(|| parse_error(ParseError::unexpected_structure())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shortcut.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 78 | let read_dir = fs::read_dir(&user_data).map_err(|io| Error::io(io, &user_data))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | dir: user_data, [INFO] [stdout] 81 | | read_dir, [INFO] [stdout] 82 | | pending: Vec::new().into_iter(), [INFO] [stdout] 83 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/helpers.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn finish(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let tmp = TempDir::new()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let tmps = iter::once(tmp) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(TempSteamDir { [INFO] [stdout] | ____________^ [INFO] [stdout] 99 | | steam_dir: SteamDir::from_dir(&steam_dir)?, [INFO] [stdout] 100 | | _tmps: tmps, [INFO] [stdout] 101 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/helpers.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 213 | let tmp = TempDir::new()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(TempLibrary { [INFO] [stdout] | ____________^ [INFO] [stdout] 228 | | content_id: 1234, [INFO] [stdout] 229 | | path: root_dir, [INFO] [stdout] 230 | | apps, [INFO] [stdout] 231 | | _tmp: tmp, [INFO] [stdout] 232 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `steamlocate` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5a7ee0f10135e1a4632cd5e91bf0204d4c286b23d999a8270a6d76dc849a408f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a7ee0f10135e1a4632cd5e91bf0204d4c286b23d999a8270a6d76dc849a408f", kill_on_drop: false }` [INFO] [stdout] 5a7ee0f10135e1a4632cd5e91bf0204d4c286b23d999a8270a6d76dc849a408f