[INFO] fetching crate stdext 0.3.3... [INFO] checking stdext-0.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate stdext 0.3.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate stdext 0.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate stdext 0.3.3 [INFO] finished tweaking crates.io crate stdext 0.3.3 [INFO] tweaked toml for crates.io crate stdext 0.3.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3d44c9182217e783e896c6231559c4ae93c20bb3504681a6ad94b349a4510b6b [INFO] running `Command { std: "docker" "start" "-a" "3d44c9182217e783e896c6231559c4ae93c20bb3504681a6ad94b349a4510b6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3d44c9182217e783e896c6231559c4ae93c20bb3504681a6ad94b349a4510b6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d44c9182217e783e896c6231559c4ae93c20bb3504681a6ad94b349a4510b6b", kill_on_drop: false }` [INFO] [stdout] 3d44c9182217e783e896c6231559c4ae93c20bb3504681a6ad94b349a4510b6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eeee72d2b59ae5da2fdf8a861e71ccde8d307b2a2c125346a26524aa0ca4f210 [INFO] running `Command { std: "docker" "start" "-a" "eeee72d2b59ae5da2fdf8a861e71ccde8d307b2a2c125346a26524aa0ca4f210", kill_on_drop: false }` [INFO] [stderr] Checking stdext v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: an associated function with this name may be added to the standard library in the future [INFO] [stdout] --> src/duration.rs:242:16 [INFO] [stdout] | [INFO] [stdout] 242 | self + Self::from_hours(hours) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `duration::DurationExt::from_hours(...)` to keep using the current method [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] help: add `#![feature(duration_constructors)]` to the crate attributes to enable `std::time::Duration::from_hours` [INFO] [stdout] --> src/lib.rs:132:1 [INFO] [stdout] | [INFO] [stdout] 132 + #![feature(duration_constructors)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an associated function with this name may be added to the standard library in the future [INFO] [stdout] --> src/duration.rs:246:16 [INFO] [stdout] | [INFO] [stdout] 246 | self + Self::from_days(days) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `duration::DurationExt::from_days(...)` to keep using the current method [INFO] [stdout] help: add `#![feature(duration_constructors)]` to the crate attributes to enable `std::time::Duration::from_days` [INFO] [stdout] --> src/lib.rs:132:1 [INFO] [stdout] | [INFO] [stdout] 132 + #![feature(duration_constructors)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an associated function with this name may be added to the standard library in the future [INFO] [stdout] --> src/duration.rs:282:24 [INFO] [stdout] | [INFO] [stdout] 282 | assert_eq!(Duration::from_hours(hours), Duration::from_secs(seconds)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `duration::DurationExt::from_hours(...)` to keep using the current method [INFO] [stdout] help: add `#![feature(duration_constructors)]` to the crate attributes to enable `std::time::Duration::from_hours` [INFO] [stdout] --> src/lib.rs:132:1 [INFO] [stdout] | [INFO] [stdout] 132 + #![feature(duration_constructors)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an associated function with this name may be added to the standard library in the future [INFO] [stdout] --> src/duration.rs:289:24 [INFO] [stdout] | [INFO] [stdout] 289 | assert_eq!(Duration::from_days(days), Duration::from_secs(seconds)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `duration::DurationExt::from_days(...)` to keep using the current method [INFO] [stdout] help: add `#![feature(duration_constructors)]` to the crate attributes to enable `std::time::Duration::from_days` [INFO] [stdout] --> src/lib.rs:132:1 [INFO] [stdout] | [INFO] [stdout] 132 + #![feature(duration_constructors)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an associated function with this name may be added to the standard library in the future [INFO] [stdout] --> src/duration.rs:242:16 [INFO] [stdout] | [INFO] [stdout] 242 | self + Self::from_hours(hours) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `DurationExt::from_hours(...)` to keep using the current method [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] help: add `#![feature(duration_constructors)]` to the crate attributes to enable `Duration::from_hours` [INFO] [stdout] --> src/lib.rs:132:1 [INFO] [stdout] | [INFO] [stdout] 132 + #![feature(duration_constructors)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an associated function with this name may be added to the standard library in the future [INFO] [stdout] --> src/duration.rs:246:16 [INFO] [stdout] | [INFO] [stdout] 246 | self + Self::from_days(days) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `DurationExt::from_days(...)` to keep using the current method [INFO] [stdout] help: add `#![feature(duration_constructors)]` to the crate attributes to enable `Duration::from_days` [INFO] [stdout] --> src/lib.rs:132:1 [INFO] [stdout] | [INFO] [stdout] 132 + #![feature(duration_constructors)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/option.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 72 | fn combine(self, other: Option) -> Option<(T, U)> { [INFO] [stdout] | ---- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | match (self, other) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/option.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 79 | fn combine_with(self, other: Option, f: F) -> Option [INFO] [stdout] | ---- ---------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | self.combine(other).map(|(l, r)| f(l, r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/option.rs:83:33 [INFO] [stdout] | [INFO] [stdout] 79 | fn combine_with(self, other: Option, f: F) -> Option [INFO] [stdout] | ---- ---------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | self.combine(other).map(|(l, r)| f(l, r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 59 | fn combine(self, other: Result) -> Result<(T, U), E> { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | match (self, other) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 67 | fn combine_with(self, other: Result, f: F) -> Result [INFO] [stdout] | ---- ------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | self.combine(other).map(|(l, r)| f(l, r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:71:33 [INFO] [stdout] | [INFO] [stdout] 67 | fn combine_with(self, other: Result, f: F) -> Result [INFO] [stdout] | ---- ------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | self.combine(other).map(|(l, r)| f(l, r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/option.rs:73:15 [INFO] [stdout] | [INFO] [stdout] 72 | fn combine(self, other: Option) -> Option<(T, U)> { [INFO] [stdout] | ---- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | match (self, other) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stdext` (lib test) due to 7 previous errors; 4 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/option.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 79 | fn combine_with(self, other: Option, f: F) -> Option [INFO] [stdout] | ---- ---------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | self.combine(other).map(|(l, r)| f(l, r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/option.rs:83:33 [INFO] [stdout] | [INFO] [stdout] 79 | fn combine_with(self, other: Option, f: F) -> Option [INFO] [stdout] | ---- ---------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | self.combine(other).map(|(l, r)| f(l, r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 59 | fn combine(self, other: Result) -> Result<(T, U), E> { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | match (self, other) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 67 | fn combine_with(self, other: Result, f: F) -> Result [INFO] [stdout] | ---- ------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | self.combine(other).map(|(l, r)| f(l, r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:71:33 [INFO] [stdout] | [INFO] [stdout] 67 | fn combine_with(self, other: Result, f: F) -> Result [INFO] [stdout] | ---- ------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | self.combine(other).map(|(l, r)| f(l, r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stdext` (lib) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "eeee72d2b59ae5da2fdf8a861e71ccde8d307b2a2c125346a26524aa0ca4f210", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eeee72d2b59ae5da2fdf8a861e71ccde8d307b2a2c125346a26524aa0ca4f210", kill_on_drop: false }` [INFO] [stdout] eeee72d2b59ae5da2fdf8a861e71ccde8d307b2a2c125346a26524aa0ca4f210