[INFO] fetching crate statsrelay 3.0.1... [INFO] checking statsrelay-3.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate statsrelay 3.0.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate statsrelay 3.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/.cargo/config [INFO] started tweaking crates.io crate statsrelay 3.0.1 [INFO] finished tweaking crates.io crate statsrelay 3.0.1 [INFO] tweaked toml for crates.io crate statsrelay 3.0.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate statsrelay 3.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c3c6ea63602fd176e29334b16a90a5be5665130ba889d241585139c57eab20b [INFO] running `Command { std: "docker" "start" "-a" "6c3c6ea63602fd176e29334b16a90a5be5665130ba889d241585139c57eab20b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c3c6ea63602fd176e29334b16a90a5be5665130ba889d241585139c57eab20b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c3c6ea63602fd176e29334b16a90a5be5665130ba889d241585139c57eab20b", kill_on_drop: false }` [INFO] [stdout] 6c3c6ea63602fd176e29334b16a90a5be5665130ba889d241585139c57eab20b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f21ce48420d583e4152ad2f527ca7dc7f9115b519c694e626e4514c4000bf90 [INFO] running `Command { std: "docker" "start" "-a" "1f21ce48420d583e4152ad2f527ca7dc7f9115b519c694e626e4514c4000bf90", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.50 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling const_fn v0.4.3 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking futures-core v0.3.8 [INFO] [stderr] Compiling tinyvec_macros v0.1.0 [INFO] [stderr] Compiling matches v0.1.8 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling tinyvec v1.1.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling proc-macro-nested v0.1.6 [INFO] [stderr] Checking futures-sink v0.3.8 [INFO] [stderr] Compiling jobserver v0.1.21 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling cc v1.0.65 [INFO] [stderr] Compiling unicode-bidi v0.3.4 [INFO] [stderr] Compiling percent-encoding v2.1.0 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking futures-task v0.3.8 [INFO] [stderr] Checking futures-channel v0.3.8 [INFO] [stderr] Compiling form_urlencoded v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking futures-io v0.3.8 [INFO] [stderr] Compiling unicode-normalization v0.1.16 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling pin-project-internal v0.4.27 [INFO] [stderr] Checking pin-project-lite v0.1.11 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking net2 v0.2.35 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling libz-sys v1.1.2 [INFO] [stderr] Compiling libgit2-sys v0.12.14+1.1.0 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling indexmap v1.6.0 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Compiling idna v0.2.0 [INFO] [stderr] Checking tracing-core v0.1.17 [INFO] [stderr] Compiling serde_json v1.0.59 [INFO] [stderr] Checking smallvec v1.5.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking tracing v0.1.21 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking tokio v0.2.23 [INFO] [stderr] Checking http v0.2.1 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking parking_lot_core v0.8.0 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling url v2.2.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling tokio v0.3.4 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Compiling unicode-segmentation v1.7.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking signal-hook-registry v1.2.2 [INFO] [stderr] Checking mio v0.7.6 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Compiling anyhow v1.0.34 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking pin-project-lite v0.2.0 [INFO] [stderr] Checking bytes v0.6.0 [INFO] [stderr] Checking http-body v0.3.1 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking crossbeam-queue v0.3.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking socket2 v0.3.17 [INFO] [stderr] Checking tower-service v0.3.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking humantime v2.0.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking qp-trie v0.7.6 [INFO] [stderr] Checking crossbeam v0.8.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking murmur3 v0.5.1 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking env_logger v0.8.2 [INFO] [stderr] Compiling pin-project-internal v1.0.2 [INFO] [stderr] Compiling futures-macro v0.3.8 [INFO] [stderr] Compiling tokio-macros v0.3.1 [INFO] [stderr] Compiling thiserror-impl v1.0.22 [INFO] [stderr] Checking pin-project v1.0.2 [INFO] [stderr] Checking pin-project v0.4.27 [INFO] [stderr] Checking futures-util v0.3.8 [INFO] [stderr] Checking tracing-futures v0.2.4 [INFO] [stderr] Compiling structopt-derive v0.4.13 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking thiserror v1.0.22 [INFO] [stderr] Checking structopt v0.3.20 [INFO] [stderr] Checking futures-executor v0.3.8 [INFO] [stderr] Checking h2 v0.2.7 [INFO] [stderr] Checking futures v0.3.8 [INFO] [stderr] Checking stream-cancel v0.7.0 [INFO] [stderr] Checking bstr v0.2.14 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking csv v1.1.4 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling toml v0.5.7 [INFO] [stderr] Compiling git2 v0.13.12 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking tinytemplate v1.1.0 [INFO] [stderr] Checking hyper v0.13.9 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking criterion v0.3.3 [INFO] [stderr] Compiling cargo-lock v4.0.1 [INFO] [stderr] Compiling built v0.4.3 [INFO] [stderr] Compiling statsrelay v3.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends.rs:114:15 [INFO] [stdout] | [INFO] [stdout] 94 | let sender = client.sender(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let pdu_clone: StatsdPDU; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | match sender.try_send(pdu_clone) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn provide_statsd_pdu(&self, pdu: StatsdPDU) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | self.inner.read().provide_statsd_pdu(pdu) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statsd.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 54 | let mut buf = bytes::BytesMut::with_capacity(self.len() + offset); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | underlying: buf.freeze(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statsd.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(line: Bytes) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Some(StatsdPDU { [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | underlying: line, [INFO] [stdout] 127 | | value_index, [INFO] [stdout] 128 | | type_index, [INFO] [stdout] ... | [INFO] [stdout] 131 | | tags_index: tags_index, [INFO] [stdout] 132 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statsd_client.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 36 | let (trig, trip) = Tripwire::new(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let (sender, recv) = mpsc::channel::(channel_buffer); [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let inner = StatsdClientInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let (ticker_sender, ticker_recv) = mpsc::channel::(1); [INFO] [stdout] | ------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | inner: Arc::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statsd_server.rs:51:28 [INFO] [stdout] | [INFO] [stdout] 42 | fn udp_worker(&mut self, bind: String, backends: Backends) -> std::thread::JoinHandle<()> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let socket = UdpSocket::bind(bind.as_str()).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let gate = self.shutdown_gate.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | std::thread::spawn(move || { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 52 | | loop { [INFO] [stdout] 53 | | if gate.load(Relaxed) { [INFO] [stdout] 54 | | break; [INFO] [stdout] ... | [INFO] [stdout] 74 | | info!("terminating statsd udp"); [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `statsrelay` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends.rs:114:15 [INFO] [stdout] | [INFO] [stdout] 94 | let sender = client.sender(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let pdu_clone: StatsdPDU; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | match sender.try_send(pdu_clone) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backends.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn provide_statsd_pdu(&self, pdu: StatsdPDU) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | self.inner.read().provide_statsd_pdu(pdu) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statsd.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 54 | let mut buf = bytes::BytesMut::with_capacity(self.len() + offset); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | underlying: buf.freeze(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statsd.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(line: Bytes) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Some(StatsdPDU { [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | underlying: line, [INFO] [stdout] 127 | | value_index, [INFO] [stdout] 128 | | type_index, [INFO] [stdout] ... | [INFO] [stdout] 131 | | tags_index: tags_index, [INFO] [stdout] 132 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statsd_client.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 36 | let (trig, trip) = Tripwire::new(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let (sender, recv) = mpsc::channel::(channel_buffer); [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let inner = StatsdClientInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let (ticker_sender, ticker_recv) = mpsc::channel::(1); [INFO] [stdout] | ------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | inner: Arc::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statsd_server.rs:51:28 [INFO] [stdout] | [INFO] [stdout] 42 | fn udp_worker(&mut self, bind: String, backends: Backends) -> std::thread::JoinHandle<()> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let socket = UdpSocket::bind(bind.as_str()).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let gate = self.shutdown_gate.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | std::thread::spawn(move || { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 52 | | loop { [INFO] [stdout] 53 | | if gate.load(Relaxed) { [INFO] [stdout] 54 | | break; [INFO] [stdout] ... | [INFO] [stdout] 74 | | info!("terminating statsd udp"); [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `statsrelay` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "1f21ce48420d583e4152ad2f527ca7dc7f9115b519c694e626e4514c4000bf90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f21ce48420d583e4152ad2f527ca7dc7f9115b519c694e626e4514c4000bf90", kill_on_drop: false }` [INFO] [stdout] 1f21ce48420d583e4152ad2f527ca7dc7f9115b519c694e626e4514c4000bf90