[INFO] fetching crate statman 0.1.0... [INFO] checking statman-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate statman 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate statman 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate statman 0.1.0 [INFO] finished tweaking crates.io crate statman 0.1.0 [INFO] tweaked toml for crates.io crate statman 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate statman 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29b39f419ec6642a0cc36a49b2cb67ddd1caa8213090044a2dfe26700ee1fdf5 [INFO] running `Command { std: "docker" "start" "-a" "29b39f419ec6642a0cc36a49b2cb67ddd1caa8213090044a2dfe26700ee1fdf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29b39f419ec6642a0cc36a49b2cb67ddd1caa8213090044a2dfe26700ee1fdf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29b39f419ec6642a0cc36a49b2cb67ddd1caa8213090044a2dfe26700ee1fdf5", kill_on_drop: false }` [INFO] [stdout] 29b39f419ec6642a0cc36a49b2cb67ddd1caa8213090044a2dfe26700ee1fdf5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ffe772036cf7e611c8a6afe93f1edc5448741490da2be17701dc7613f9e89bc [INFO] running `Command { std: "docker" "start" "-a" "3ffe772036cf7e611c8a6afe93f1edc5448741490da2be17701dc7613f9e89bc", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking sdd v0.2.0 [INFO] [stderr] Checking atomic_float v1.0.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking scc v2.1.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking hdrhistogram v7.5.4 [INFO] [stderr] Checking statman v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:42 [INFO] [stdout] | [INFO] [stdout] 144 | INSTANCE.get_or_init(|| Arc::new(Stats::new())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:14 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn counter<'a, N: Into>(&self, name: N) -> Arc { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | Arc::clone( [INFO] [stdout] 165 | &self [INFO] [stdout] | ______________^ [INFO] [stdout] 166 | | .counters [INFO] [stdout] 167 | | .entry(name.into()) [INFO] [stdout] 168 | | .or_insert_with(|| { [INFO] [stdout] ... | [INFO] [stdout] 172 | | )) [INFO] [stdout] 173 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:181:14 [INFO] [stdout] | [INFO] [stdout] 179 | pub fn gauge_f64<'a, N: Into>(&self, name: N) -> Arc { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | Arc::clone( [INFO] [stdout] 181 | &self [INFO] [stdout] | ______________^ [INFO] [stdout] 182 | | .gauges_f64 [INFO] [stdout] 183 | | .entry(name.into()) [INFO] [stdout] 184 | | .or_insert_with(|| { [INFO] [stdout] ... | [INFO] [stdout] 188 | | )) [INFO] [stdout] 189 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `statman` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn gauge_i64<'a, N: Into>(&self, name: N) -> Arc { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Arc::clone( [INFO] [stdout] 197 | &self [INFO] [stdout] | ______________^ [INFO] [stdout] 198 | | .gauges_i64 [INFO] [stdout] 199 | | .entry(name.into()) [INFO] [stdout] 200 | | .or_insert_with(|| { [INFO] [stdout] ... | [INFO] [stdout] 204 | | )) [INFO] [stdout] 205 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:219:14 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn histogram<'a, N: Into>(&self, name: N) -> Arc { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | Arc::clone( [INFO] [stdout] 219 | &self [INFO] [stdout] | ______________^ [INFO] [stdout] 220 | | .histograms [INFO] [stdout] 221 | | .entry(name.into()) [INFO] [stdout] 222 | | .or_insert_with(|| { [INFO] [stdout] ... | [INFO] [stdout] 226 | | )) [INFO] [stdout] 227 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:235:14 [INFO] [stdout] | [INFO] [stdout] 233 | pub fn set<'a, N: Into>(&self, name: N) -> Arc { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | Arc::clone( [INFO] [stdout] 235 | &self [INFO] [stdout] | ______________^ [INFO] [stdout] 236 | | .sets [INFO] [stdout] 237 | | .entry(name.into()) [INFO] [stdout] 238 | | .or_insert_with(|| { [INFO] [stdout] ... | [INFO] [stdout] 241 | | )) [INFO] [stdout] 242 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn spawn(self, interval: Duration) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let callbacks = Arc::clone(&self.callbacks); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stats = self.stats; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let max_park_duration = self.max_park_duration; [INFO] [stdout] 114 | let runflag = Arc::clone(&self.runflag); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let flush_params = self.flush_params; [INFO] [stdout] 116 | let join_handle = thread::Builder::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(FlushSchedulerHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 148 | | callbacks: self.callbacks, [INFO] [stdout] 149 | | join_handle, [INFO] [stdout] 150 | | runflag: self.runflag, [INFO] [stdout] 151 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "3ffe772036cf7e611c8a6afe93f1edc5448741490da2be17701dc7613f9e89bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ffe772036cf7e611c8a6afe93f1edc5448741490da2be17701dc7613f9e89bc", kill_on_drop: false }` [INFO] [stdout] 3ffe772036cf7e611c8a6afe93f1edc5448741490da2be17701dc7613f9e89bc