[INFO] fetching crate stash 0.1.5... [INFO] checking stash-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate stash 0.1.5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate stash 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate stash 0.1.5 [INFO] finished tweaking crates.io crate stash 0.1.5 [INFO] tweaked toml for crates.io crate stash 0.1.5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate stash 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f71fe8d8e3d1a230645bc138a76bbd6d37cb1d8cf6d00fc38232cc2188ff62a0 [INFO] running `Command { std: "docker" "start" "-a" "f71fe8d8e3d1a230645bc138a76bbd6d37cb1d8cf6d00fc38232cc2188ff62a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f71fe8d8e3d1a230645bc138a76bbd6d37cb1d8cf6d00fc38232cc2188ff62a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f71fe8d8e3d1a230645bc138a76bbd6d37cb1d8cf6d00fc38232cc2188ff62a0", kill_on_drop: false }` [INFO] [stdout] f71fe8d8e3d1a230645bc138a76bbd6d37cb1d8cf6d00fc38232cc2188ff62a0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fbfd0b203f447d4d64d89af51b97525c424911be46e8570cc5666a5334dd4b47 [INFO] running `Command { std: "docker" "start" "-a" "fbfd0b203f447d4d64d89af51b97525c424911be46e8570cc5666a5334dd4b47", kill_on_drop: false }` [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling autocfg v0.1.4 [INFO] [stderr] Compiling serde v1.0.94 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking stash v0.1.5 (/opt/rustwide/workdir) [INFO] [stderr] Compiling bincode v1.1.4 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stash/mod.rs:398:20 [INFO] [stdout] | [INFO] [stdout] 395 | pub fn into_values(self) -> IntoValues { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | inner: self.data.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stash/mod.rs:440:15 [INFO] [stdout] | [INFO] [stdout] 438 | pub unsafe fn take_unchecked(&mut self, index: Ix) -> V { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | let take_index = index.into_usize(); [INFO] [stdout] 440 | match mem::replace( [INFO] [stdout] | _______________^ [INFO] [stdout] 441 | | self.data.get_unchecked_mut(take_index), [INFO] [stdout] 442 | | Entry::Empty(self.next_free), [INFO] [stdout] 443 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stash/mod.rs:534:20 [INFO] [stdout] | [INFO] [stdout] 531 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 534 | inner: self.data.into_iter().enumerate(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unique_stash/mod.rs:413:20 [INFO] [stdout] | [INFO] [stdout] 410 | pub fn into_values(self) -> IntoValues { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | inner: self.data.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unique_stash/mod.rs:497:20 [INFO] [stdout] | [INFO] [stdout] 494 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | inner: self.data.into_iter().enumerate(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unique_stash/entry.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(value: V) -> VerEntry { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | entry: Full(value), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unique_stash/entry.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn fill(entry: &mut VerEntry, value: V) -> usize { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | match mem::replace(&mut entry.entry, Full(value)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stash` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "fbfd0b203f447d4d64d89af51b97525c424911be46e8570cc5666a5334dd4b47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fbfd0b203f447d4d64d89af51b97525c424911be46e8570cc5666a5334dd4b47", kill_on_drop: false }` [INFO] [stdout] fbfd0b203f447d4d64d89af51b97525c424911be46e8570cc5666a5334dd4b47