[INFO] fetching crate starry 2.1.0... [INFO] checking starry-2.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate starry 2.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate starry 2.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate starry 2.1.0 [INFO] finished tweaking crates.io crate starry 2.1.0 [INFO] tweaked toml for crates.io crate starry 2.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate starry 2.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4605f80a2b1908b69f90367930c7764192417386b6d13cfd8c0c4dcefb556bc2 [INFO] running `Command { std: "docker" "start" "-a" "4605f80a2b1908b69f90367930c7764192417386b6d13cfd8c0c4dcefb556bc2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4605f80a2b1908b69f90367930c7764192417386b6d13cfd8c0c4dcefb556bc2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4605f80a2b1908b69f90367930c7764192417386b6d13cfd8c0c4dcefb556bc2", kill_on_drop: false }` [INFO] [stdout] 4605f80a2b1908b69f90367930c7764192417386b6d13cfd8c0c4dcefb556bc2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 577899fa2d9fb653305e573a8dcc58a3f431746e4b8b4b05a1897215c6b2c7ed [INFO] running `Command { std: "docker" "start" "-a" "577899fa2d9fb653305e573a8dcc58a3f431746e4b8b4b05a1897215c6b2c7ed", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking minimad v0.13.0 [INFO] [stderr] Checking file-size v1.0.3 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking directories-next v2.0.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.23.2 [INFO] [stderr] Checking coolor v0.8.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking proc-status v0.1.1 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.1.0 [INFO] [stderr] Checking lazy-regex v3.1.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.24 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking argh_shared v0.1.12 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking termimad v0.27.0 [INFO] [stderr] Compiling argh_derive v0.1.12 [INFO] [stderr] Checking cli-log v2.0.0 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking argh v0.1.12 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.26 [INFO] [stderr] Checking byo-graphql v0.2.0 [INFO] [stderr] Checking starry v2.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/db.rs:151:30 [INFO] [stdout] | [INFO] [stdout] 148 | let github_client = GithubClient::new(conf).unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let task = task.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let user_id = UserId::new(user); [INFO] [stdout] 151 | tokio::spawn(async move { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 152 | | let user_obs = github_client [INFO] [stdout] 153 | | .get_user_star_counts(user_id.clone(), now) [INFO] [stdout] 154 | | .await; [INFO] [stdout] 155 | | task.lock().await.increment(); [INFO] [stdout] 156 | | user_obs.map(|user_obs| (user_id, user_obs)) [INFO] [stdout] 157 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/github/client.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 30 | let mut gql_client = GraphqlClient::new("https://api.github.com/graphql")?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | gql_client.set_bearer_auth(github_api_token); [INFO] [stdout] 32 | Ok(Self { gql_client }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/db.rs:151:30 [INFO] [stdout] | [INFO] [stdout] 148 | let github_client = GithubClient::new(conf).unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let task = task.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let user_id = UserId::new(user); [INFO] [stdout] 151 | tokio::spawn(async move { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 152 | | let user_obs = github_client [INFO] [stdout] 153 | | .get_user_star_counts(user_id.clone(), now) [INFO] [stdout] 154 | | .await; [INFO] [stdout] 155 | | task.lock().await.increment(); [INFO] [stdout] 156 | | user_obs.map(|user_obs| (user_id, user_obs)) [INFO] [stdout] 157 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/github/client.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 30 | let mut gql_client = GraphqlClient::new("https://api.github.com/graphql")?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | gql_client.set_bearer_auth(github_api_token); [INFO] [stdout] 32 | Ok(Self { gql_client }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starry` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `starry` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "577899fa2d9fb653305e573a8dcc58a3f431746e4b8b4b05a1897215c6b2c7ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "577899fa2d9fb653305e573a8dcc58a3f431746e4b8b4b05a1897215c6b2c7ed", kill_on_drop: false }` [INFO] [stdout] 577899fa2d9fb653305e573a8dcc58a3f431746e4b8b4b05a1897215c6b2c7ed