[INFO] fetching crate starlark_lsp 0.12.0... [INFO] checking starlark_lsp-0.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate starlark_lsp 0.12.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate starlark_lsp 0.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate starlark_lsp 0.12.0 [INFO] finished tweaking crates.io crate starlark_lsp 0.12.0 [INFO] tweaked toml for crates.io crate starlark_lsp 0.12.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 162 packages to latest compatible versions [INFO] [stderr] Adding annotate-snippets v0.9.2 (latest: v0.11.4) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clipboard-win v4.5.0 (latest: v5.4.0) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding ctor v0.1.26 (latest: v0.2.8) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding endian-type v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding erased-serde v0.3.31 (latest: v0.4.5) [INFO] [stderr] Adding error-code v2.3.1 (latest: v3.2.0) [INFO] [stderr] Adding fd-lock v3.0.13 (latest: v4.0.2) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding lalrpop v0.19.12 (latest: v0.21.0) [INFO] [stderr] Adding lalrpop-util v0.19.12 (latest: v0.21.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding logos v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding logos-derive v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding lsp-types v0.94.1 (latest: v0.97.0) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rustyline v11.0.0 (latest: v14.0.0) [INFO] [stderr] Adding schemafy v0.5.2 (latest: v0.6.0) [INFO] [stderr] Adding schemafy_core v0.5.2 (latest: v0.6.0) [INFO] [stderr] Adding schemafy_lib v0.5.2 (latest: v0.6.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding str-buf v1.0.6 (latest: v3.0.3) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding term v0.7.0 (latest: v1.0.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c16042f7955f6b0f00b564a3f7a51803b9e73ae3d6e5656ec23b8aa83b8c711d [INFO] running `Command { std: "docker" "start" "-a" "c16042f7955f6b0f00b564a3f7a51803b9e73ae3d6e5656ec23b8aa83b8c711d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c16042f7955f6b0f00b564a3f7a51803b9e73ae3d6e5656ec23b8aa83b8c711d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c16042f7955f6b0f00b564a3f7a51803b9e73ae3d6e5656ec23b8aa83b8c711d", kill_on_drop: false }` [INFO] [stdout] c16042f7955f6b0f00b564a3f7a51803b9e73ae3d6e5656ec23b8aa83b8c711d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4914f1bc322ae3dab1375e7aa8f0dd1038664e379e0a09d95fe3774778d8f166 [INFO] running `Command { std: "docker" "start" "-a" "4914f1bc322ae3dab1375e7aa8f0dd1038664e379e0a09d95fe3774778d8f166", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling is-terminal v0.4.13 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling allocative v0.3.3 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling starlark_map v0.12.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling lalrpop-util v0.19.12 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Checking annotate-snippets v0.9.2 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking fd-lock v3.0.13 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling starlark v0.12.0 [INFO] [stderr] Checking display_container v0.9.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling dupe_derive v0.9.0 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Compiling allocative_derive v0.3.3 [INFO] [stderr] Checking dupe v0.9.0 [INFO] [stderr] Compiling logos-derive v0.12.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling starlark_derive v0.12.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking rustyline v11.0.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking cmp_any v0.8.1 [INFO] [stderr] Checking logos v0.12.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Compiling starlark_syntax v0.12.0 [INFO] [stderr] Checking lsp-types v0.94.1 [INFO] [stderr] Checking lsp-server v0.7.6 [INFO] [stderr] Compiling schemafy_core v0.5.2 [INFO] [stderr] Compiling schemafy_lib v0.5.2 [INFO] [stderr] Compiling schemafy v0.5.2 [INFO] [stderr] Checking debugserver-types v0.5.0 [INFO] [stderr] Checking starlark_lsp v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/completion.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 128 | let docs = self.last_valid_parse.read().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | / symbols [INFO] [stdout] 163 | | .into_values() [INFO] [stdout] 164 | | .chain(self.get_global_symbol_completion_items(document_uri)) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/completion.rs:165:20 [INFO] [stdout] | [INFO] [stdout] 128 | let docs = self.last_valid_parse.read().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | .chain(Self::get_keyword_completion_items()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/completion.rs:112:34 [INFO] [stdout] | [INFO] [stdout] 95 | .map(|(key, value)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | .or_else(|| { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 113 | | value.param.map(|doc| { [INFO] [stdout] 114 | | Documentation::MarkupContent(MarkupContent { [INFO] [stdout] 115 | | kind: MarkupKind::Markdown, [INFO] [stdout] ... | [INFO] [stdout] 118 | | }) [INFO] [stdout] 119 | | }), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/completion.rs:182:17 [INFO] [stdout] | [INFO] [stdout] 181 | .flat_map(|ast| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | / ast.get_exported_symbols() [INFO] [stdout] 183 | | .into_iter() [INFO] [stdout] 184 | | .filter(|symbol| !previously_loaded.iter().any(|s| s == &symbol.name)) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exported.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 112 | let mut result: SmallMap<&str, _> = SmallMap::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | result.into_values().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exported.rs:165:28 [INFO] [stdout] | [INFO] [stdout] 165 | || get_doc_item_for_def(def).map(DocItem::Function), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:439:76 [INFO] [stdout] | [INFO] [stdout] 439 | .and_then(|eval_result| eval_result.ast.map(|ast| Arc::new(LspModule::new(ast)))), [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:1098:34 [INFO] [stdout] | [INFO] [stdout] 1089 | .and_then(|symbol| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1098 | .or_else(|| { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 1099 | | symbol.param.map(|docs| Hover { [INFO] [stdout] 1100 | | contents: HoverContents::Array(vec![MarkedString::String( [INFO] [stdout] 1101 | | render_doc_param(&docs), [INFO] [stdout] ... | [INFO] [stdout] 1104 | | }) [INFO] [stdout] 1105 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:1115:21 [INFO] [stdout] | [INFO] [stdout] 1114 | self.get_ast_or_load_from_disk(&load_uri)?.and_then(|ast| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1115 | ast.find_exported_symbol(&name).and_then(|symbol| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:1285:26 [INFO] [stdout] | [INFO] [stdout] 1285 | .and_then(|opts| serde_json::from_value(opts.clone()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:1348:17 [INFO] [stdout] | [INFO] [stdout] 1342 | pub(crate) fn new_notification(params: T::Params) -> Notification [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1348 | params: serde_json::to_value(¶ms).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | doc: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:75:28 [INFO] [stdout] | [INFO] [stdout] 75 | param: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:86:26 [INFO] [stdout] | [INFO] [stdout] 86 | doc: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:87:28 [INFO] [stdout] | [INFO] [stdout] 87 | param: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:96:30 [INFO] [stdout] | [INFO] [stdout] 96 | doc: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 97 | param: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:111:30 [INFO] [stdout] | [INFO] [stdout] 111 | doc: doc.clone().map(DocItem::Function), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:112:32 [INFO] [stdout] | [INFO] [stdout] 112 | param: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_lsp` (lib) due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/completion.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 128 | let docs = self.last_valid_parse.read().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | / symbols [INFO] [stdout] 163 | | .into_values() [INFO] [stdout] 164 | | .chain(self.get_global_symbol_completion_items(document_uri)) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/completion.rs:165:20 [INFO] [stdout] | [INFO] [stdout] 128 | let docs = self.last_valid_parse.read().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | .chain(Self::get_keyword_completion_items()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/completion.rs:112:34 [INFO] [stdout] | [INFO] [stdout] 95 | .map(|(key, value)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | .or_else(|| { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 113 | | value.param.map(|doc| { [INFO] [stdout] 114 | | Documentation::MarkupContent(MarkupContent { [INFO] [stdout] 115 | | kind: MarkupKind::Markdown, [INFO] [stdout] ... | [INFO] [stdout] 118 | | }) [INFO] [stdout] 119 | | }), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/completion.rs:182:17 [INFO] [stdout] | [INFO] [stdout] 181 | .flat_map(|ast| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | / ast.get_exported_symbols() [INFO] [stdout] 183 | | .into_iter() [INFO] [stdout] 184 | | .filter(|symbol| !previously_loaded.iter().any(|s| s == &symbol.name)) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exported.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 112 | let mut result: SmallMap<&str, _> = SmallMap::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | result.into_values().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exported.rs:165:28 [INFO] [stdout] | [INFO] [stdout] 165 | || get_doc_item_for_def(def).map(DocItem::Function), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:439:76 [INFO] [stdout] | [INFO] [stdout] 439 | .and_then(|eval_result| eval_result.ast.map(|ast| Arc::new(LspModule::new(ast)))), [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:1098:34 [INFO] [stdout] | [INFO] [stdout] 1089 | .and_then(|symbol| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1098 | .or_else(|| { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 1099 | | symbol.param.map(|docs| Hover { [INFO] [stdout] 1100 | | contents: HoverContents::Array(vec![MarkedString::String( [INFO] [stdout] 1101 | | render_doc_param(&docs), [INFO] [stdout] ... | [INFO] [stdout] 1104 | | }) [INFO] [stdout] 1105 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:1115:21 [INFO] [stdout] | [INFO] [stdout] 1114 | self.get_ast_or_load_from_disk(&load_uri)?.and_then(|ast| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1115 | ast.find_exported_symbol(&name).and_then(|symbol| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:1285:26 [INFO] [stdout] | [INFO] [stdout] 1285 | .and_then(|opts| serde_json::from_value(opts.clone()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:1348:17 [INFO] [stdout] | [INFO] [stdout] 1342 | pub(crate) fn new_notification(params: T::Params) -> Notification [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1348 | params: serde_json::to_value(¶ms).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | doc: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:75:28 [INFO] [stdout] | [INFO] [stdout] 75 | param: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:86:26 [INFO] [stdout] | [INFO] [stdout] 86 | doc: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:87:28 [INFO] [stdout] | [INFO] [stdout] 87 | param: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:96:30 [INFO] [stdout] | [INFO] [stdout] 96 | doc: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 97 | param: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:111:30 [INFO] [stdout] | [INFO] [stdout] 111 | doc: doc.clone().map(DocItem::Function), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:112:32 [INFO] [stdout] | [INFO] [stdout] 112 | param: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 240 | let re = regex::Regex::new(r#"--(\d+):(\d+)$"#)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let (literal, span) = match re.captures(literal) { [INFO] [stdout] 242 | Some(cap) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | self.resolve_load(&literal, current_file, workspace_root) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:299:44 [INFO] [stdout] | [INFO] [stdout] 299 | .map(|name| (name.clone(), DocMember::Function(DocFunction::default()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:405:21 [INFO] [stdout] | [INFO] [stdout] 401 | pub fn new_request(&mut self, params: T::Params) -> lsp_server::Request { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | params: serde_json::to_value(params).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:485:55 [INFO] [stdout] | [INFO] [stdout] 485 | let initialization_options = settings.map(|v| serde_json::to_value(v).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_lsp` (lib test) due to 24 previous errors [INFO] running `Command { std: "docker" "inspect" "4914f1bc322ae3dab1375e7aa8f0dd1038664e379e0a09d95fe3774778d8f166", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4914f1bc322ae3dab1375e7aa8f0dd1038664e379e0a09d95fe3774778d8f166", kill_on_drop: false }` [INFO] [stdout] 4914f1bc322ae3dab1375e7aa8f0dd1038664e379e0a09d95fe3774778d8f166