[INFO] fetching crate starlark_derive 0.12.0... [INFO] checking starlark_derive-0.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate starlark_derive 0.12.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate starlark_derive 0.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate starlark_derive 0.12.0 [INFO] finished tweaking crates.io crate starlark_derive 0.12.0 [INFO] tweaked toml for crates.io crate starlark_derive 0.12.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e3491972cac6016e0f9f957f291952aa4ab6cd8271564f85745ecbf451bdfaa [INFO] running `Command { std: "docker" "start" "-a" "7e3491972cac6016e0f9f957f291952aa4ab6cd8271564f85745ecbf451bdfaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e3491972cac6016e0f9f957f291952aa4ab6cd8271564f85745ecbf451bdfaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e3491972cac6016e0f9f957f291952aa4ab6cd8271564f85745ecbf451bdfaa", kill_on_drop: false }` [INFO] [stdout] 7e3491972cac6016e0f9f957f291952aa4ab6cd8271564f85745ecbf451bdfaa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 693a579c2eaa7169b2305e4eb1677a7edbfd7f40d6d37586b7410aa5748a72dc [INFO] running `Command { std: "docker" "start" "-a" "693a579c2eaa7169b2305e4eb1677a7edbfd7f40d6d37586b7410aa5748a72dc", kill_on_drop: false }` [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Compiling dupe_derive v0.9.0 [INFO] [stderr] Checking dupe v0.9.0 [INFO] [stderr] Checking starlark_derive v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/any_lifetime.rs:122:11 [INFO] [stdout] | [INFO] [stdout] 120 | input: proc_macro::TokenStream, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | ) -> proc_macro::TokenStream { [INFO] [stdout] 122 | match derive_provides_static_type_impl(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/any_lifetime.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 130 | params: impl Iterator, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | ) -> syn::Result { [INFO] [stdout] 132 | let mut lifetime = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(match lifetime { [INFO] [stdout] | ________^ [INFO] [stdout] 145 | | Some(lifetime) => lifetime, [INFO] [stdout] 146 | | None => syn::parse_quote_spanned! { Span::call_site() => 'pst }, [INFO] [stdout] 147 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/any_lifetime.rs:221:8 [INFO] [stdout] | [INFO] [stdout] 150 | fn derive_provides_static_type_impl(input: proc_macro::TokenStream) -> syn::Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let input: DeriveInput = syn::parse(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let lifetime = pst_lifetime(input.generics.params.iter())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | [INFO] [stdout] 160 | let mut lifetimes: Vec = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let mut static_lifetimes: Vec = Vec::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | let mut type_param_names = Vec::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let mut type_param_bounds = Vec::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | let mut type_param_static_type_bounds = Vec::new(); [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | let mut static_type_params = Vec::new(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let mut const_params = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let mut const_param_names = Vec::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | Ok(if input.generics.lt_token.is_none() { [INFO] [stdout] | ________^ [INFO] [stdout] 222 | | syn::parse_quote_spanned! { span => [INFO] [stdout] 223 | | unsafe impl<#lifetime> #impl_generics starlark::any::ProvidesStaticType<#lifetime> for #name #ty_generics #where_clause { [INFO] [stdout] 224 | | type StaticType = #name #ty_generics; [INFO] [stdout] ... | [INFO] [stdout] 248 | | } [INFO] [stdout] 249 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attrs.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn derive_attrs(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let data = input.data; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let name = input.ident; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | / expand_attrs_derive(data, name) [INFO] [stdout] 37 | | .unwrap_or_else(|e| e.to_compile_error()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bc.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 49 | fn parse(input: ItemEnum) -> BcOpcodeEnum { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | variants: input [INFO] [stdout] | _______________________^ [INFO] [stdout] 53 | | .variants [INFO] [stdout] 54 | | .iter() [INFO] [stdout] 55 | | .map(BcOpcodeEnum::parse_variant) [INFO] [stdout] 56 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/coerce.rs:45:11 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn derive_coerce(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | match derive_coerce_impl(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/docs.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | pub(crate) fn derive_docs(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | [INFO] [stdout] 39 | / expand_docs_derive(input) [INFO] [stdout] 40 | | .unwrap_or_else(|e| e.to_compile_error()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 59 | let mut impl_params = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let mut input_params = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let mut output_params = Vec::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | self.angle_brankets(&impl_params), [INFO] [stdout] 95 | | self.angle_brankets(&input_params), [INFO] [stdout] 96 | | self.angle_brankets(&output_params), [INFO] [stdout] 97 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:344:11 [INFO] [stdout] | [INFO] [stdout] 341 | pub fn derive_freeze(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | [INFO] [stdout] 344 | match derive_freeze_impl(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/mod.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 27 | pub(crate) fn starlark_module(attr: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let input = parse_macro_input!(input as ItemFn); [INFO] [stdout] | ----- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | match starlark_module_impl(attr, input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/mod.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 30 | fn starlark_module_impl(attr: TokenStream, input: ItemFn) -> syn::Result { [INFO] [stdout] | ----------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | assert!(attr.is_empty()); [INFO] [stdout] 32 | let x = parse::parse(input)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(render::render(x)?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/parse/mod.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 58 | pub(crate) fn parse(mut input: ItemFn) -> syn::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let (module_docstring, attrs) = parse_module_attributes(&input); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let visibility = input.vis; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let sig_span = input.sig.span(); [INFO] [stdout] 62 | let name = input.sig.ident; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let arg = input.sig.inputs.pop().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let (ty, module_kind) = match arg.into_value() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | FnArg::Typed(PatType { ty, .. }) if is_mut_globals_builder(&ty) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | FnArg::Typed(PatType { ty, .. }) if is_mut_methods_builder(&ty) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(StarModule { [INFO] [stdout] | ________^ [INFO] [stdout] 88 | | module_kind, [INFO] [stdout] 89 | | visibility, [INFO] [stdout] 90 | | globals_builder: *ty, [INFO] [stdout] ... | [INFO] [stdout] 99 | | .collect::>()?, [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/parse/mod.rs:163:8 [INFO] [stdout] | [INFO] [stdout] 160 | fn parse_const(x: ItemConst) -> syn::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok(StarConst { [INFO] [stdout] | ________^ [INFO] [stdout] 164 | | name: x.ident, [INFO] [stdout] 165 | | ty: *x.ty, [INFO] [stdout] 166 | | value: *x.expr, [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/render/fun.rs:513:16 [INFO] [stdout] | [INFO] [stdout] 474 | let source = match arg.source { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 475 | StarArgSource::This => quote_spanned! {span=> __this}, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | StarArgSource::Argument(i) => quote_spanned! {span=> __args[#i].get()}, [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 477 | StarArgSource::Required(i) => quote_spanned! {span=> Some(__required[#i])}, [INFO] [stdout] | -------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | StarArgSource::Optional(i) => quote_spanned! {span=> __optional[#i]}, [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | let next = if arg.pass_style == StarArgPassStyle::This { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_this(#source)? } [INFO] [stdout] | ------------------------------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_optional(#name_str, #source)? } [INFO] [stdout] | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | / syn::parse_quote_spanned! { span=> [INFO] [stdout] 498 | | { [INFO] [stdout] 499 | | // Combo [INFO] [stdout] 500 | | #[allow(clippy::manual_unwrap_or)] [INFO] [stdout] ... | [INFO] [stdout] 505 | | } [INFO] [stdout] 506 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | } else { [INFO] [stdout] 508 | | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_required(#name_str, #source)? } [INFO] [stdout] | | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 513 | | attrs: arg.attrs.clone(), [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/render/fun.rs:515:15 [INFO] [stdout] | [INFO] [stdout] 474 | let source = match arg.source { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 475 | StarArgSource::This => quote_spanned! {span=> __this}, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | StarArgSource::Argument(i) => quote_spanned! {span=> __args[#i].get()}, [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 477 | StarArgSource::Required(i) => quote_spanned! {span=> Some(__required[#i])}, [INFO] [stdout] | -------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | StarArgSource::Optional(i) => quote_spanned! {span=> __optional[#i]}, [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | let next = if arg.pass_style == StarArgPassStyle::This { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_this(#source)? } [INFO] [stdout] | ------------------------------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_optional(#name_str, #source)? } [INFO] [stdout] | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | / syn::parse_quote_spanned! { span=> [INFO] [stdout] 498 | | { [INFO] [stdout] 499 | | // Combo [INFO] [stdout] 500 | | #[allow(clippy::manual_unwrap_or)] [INFO] [stdout] ... | [INFO] [stdout] 505 | | } [INFO] [stdout] 506 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | } else { [INFO] [stdout] 508 | | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_required(#name_str, #source)? } [INFO] [stdout] | | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 515 | | name: arg.name.to_owned(), [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/render/fun.rs:516:13 [INFO] [stdout] | [INFO] [stdout] 474 | let source = match arg.source { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 475 | StarArgSource::This => quote_spanned! {span=> __this}, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | StarArgSource::Argument(i) => quote_spanned! {span=> __args[#i].get()}, [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 477 | StarArgSource::Required(i) => quote_spanned! {span=> Some(__required[#i])}, [INFO] [stdout] | -------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | StarArgSource::Optional(i) => quote_spanned! {span=> __optional[#i]}, [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | let next = if arg.pass_style == StarArgPassStyle::This { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_this(#source)? } [INFO] [stdout] | ------------------------------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_optional(#name_str, #source)? } [INFO] [stdout] | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | / syn::parse_quote_spanned! { span=> [INFO] [stdout] 498 | | { [INFO] [stdout] 499 | | // Combo [INFO] [stdout] 500 | | #[allow(clippy::manual_unwrap_or)] [INFO] [stdout] ... | [INFO] [stdout] 505 | | } [INFO] [stdout] 506 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | } else { [INFO] [stdout] 508 | | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_required(#name_str, #source)? } [INFO] [stdout] | | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 516 | | ty: arg.ty.clone(), [INFO] [stdout] | | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/render/fun.rs:612:8 [INFO] [stdout] | [INFO] [stdout] 553 | let documentation_signature = if need_render_signature { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | / quote_spanned! { [INFO] [stdout] 558 | | span=> { [INFO] [stdout] 559 | | let mut __signature = starlark::eval::ParametersSpec::::new(#name_str.to_owned()); [INFO] [stdout] 560 | | __signature.args(); [INFO] [stdout] ... | [INFO] [stdout] 563 | | } [INFO] [stdout] 564 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 567 | | let docs = match x.docstring.as_ref() { [INFO] [stdout] | | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 568 | | Some(d) => quote_spanned!(span=> Some(#d)), [INFO] [stdout] | | ------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 569 | | None => quote_spanned!(span=> None), [INFO] [stdout] | | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 570 | | }; [INFO] [stdout] 571 | | let parameter_types: Vec = x [INFO] [stdout] | | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 597 | | let return_type_str = render_starlark_return_type(x); [INFO] [stdout] | | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 598 | | let var_name = format_ident!("__documentation"); [INFO] [stdout] | | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 599 | | let as_type = x.as_type_expr(); [INFO] [stdout] | | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 600 | let documentation = quote_spanned!(span=> [INFO] [stdout] | _________-------------___- [INFO] [stdout] | |_________|_______________| [INFO] [stdout] | |_________|_______________| [INFO] [stdout] | |_________|_______________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 601 | | let #var_name = { [INFO] [stdout] 602 | | let parameter_types = std::vec![#(#parameter_types),*]; [INFO] [stdout] 603 | | starlark::values::function::NativeCallableRawDocs { [INFO] [stdout] ... | [INFO] [stdout] 610 | | }; [INFO] [stdout] 611 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 612 | | Ok((var_name, documentation)) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/starlark_type_repr.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 20 | pub(crate) fn derive_starlark_type_repr(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let input = syn::parse_macro_input!(input as syn::DeriveInput); [INFO] [stdout] | ----- -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | match derive_starlark_type_repr_impl(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/starlark_value.rs:29:11 [INFO] [stdout] | [INFO] [stdout] 24 | attr: proc_macro::TokenStream, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | input: proc_macro::TokenStream, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | ) -> proc_macro::TokenStream { [INFO] [stdout] 27 | let attr = syn::parse_macro_input!(attr as StarlarkValueAttrs); [INFO] [stdout] | ---- --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let input = syn::parse_macro_input!(input as syn::ItemImpl); [INFO] [stdout] | ----- ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | match derive_starlark_value_impl(attr, input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/starlark_value.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 89 | input: syn::ItemImpl, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | attrs: StarlarkValueAttrs, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let lifetime_param = match lifetime_param { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(ImplStarlarkValue { [INFO] [stdout] | ________^ [INFO] [stdout] 122 | | input, [INFO] [stdout] 123 | | lifetime_param, [INFO] [stdout] 124 | | attrs, [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/starlark_value.rs:293:12 [INFO] [stdout] | [INFO] [stdout] 266 | let arms = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | let default_arm: Option = if arms.iter().all(Option::is_some) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 288 | Some(syn::parse_quote_spanned! {self.span()=> [INFO] [stdout] | __________________- [INFO] [stdout] | |__________________| [INFO] [stdout] 289 | | _ => { None } [INFO] [stdout] 290 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | }; [INFO] [stdout] 292 | | let arms = arms.into_iter().flatten(); [INFO] [stdout] | | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | Ok(Some(syn::parse_quote_spanned! {self.span()=> [INFO] [stdout] | ____________^ [INFO] [stdout] 294 | fn bin_op_ty(op: starlark::typing::TypingBinOp, _rhs: &starlark::typing::TyBasic) -> Option { [INFO] [stdout] 295 | match op { [INFO] [stdout] 296 | #( #arms )* [INFO] [stdout] ... [INFO] [stdout] 299 | } [INFO] [stdout] 300 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/starlark_value.rs:312:12 [INFO] [stdout] | [INFO] [stdout] 304 | let arms = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | Ok(Some(syn::parse_quote_spanned! {self.span()=> [INFO] [stdout] | ____________^ [INFO] [stdout] 313 | | fn rbin_op_ty(_lhs: &starlark::typing::TyBasic, op: starlark::typing::TypingBinOp) -> Option { [INFO] [stdout] 314 | | match op { [INFO] [stdout] 315 | | #( #arms )* [INFO] [stdout] ... | [INFO] [stdout] 320 | | } [INFO] [stdout] 321 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unpack_value.rs:24:11 [INFO] [stdout] | [INFO] [stdout] 22 | pub(crate) fn derive_unpack_value(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let input = syn::parse_macro_input!(input as syn::DeriveInput); [INFO] [stdout] | ----- -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | match derive_unpack_value_impl(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visit_span.rs:77:11 [INFO] [stdout] | [INFO] [stdout] 75 | pub(crate) fn derive_visit_span_mut(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | match derive(input) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vtable.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 88 | fn parse_named_field(field: TokenStream) -> syn::Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(syn::parse2::(field)?.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vtable.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 158 | let params: Vec = method [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let field_init_param_pairs: Vec = params.iter().map(|p| p.fn_arg()).collect(); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let ret = match &method.sig.output { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | / quote_spanned! {method.sig.span()=> [INFO] [stdout] 170 | | -> #ty [INFO] [stdout] 171 | | } [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let field = Self::parse_named_field(quote_spanned! {method.sig.span()=> [INFO] [stdout] | _____________-----___________________________- [INFO] [stdout] | |_____________|_______________________________| [INFO] [stdout] | |_____________|_______________________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | | pub(crate) #fn_name: for<'a, 'v> fn( [INFO] [stdout] 177 | | #(#field_fn_param_types),* [INFO] [stdout] 178 | | ) #ret [INFO] [stdout] 179 | | })?; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | let init = syn::parse_quote_spanned! {method.sig.span()=> [INFO] [stdout] | _____________----___- [INFO] [stdout] | |_____________|______| [INFO] [stdout] | |_____________|______| [INFO] [stdout] | |_____________|______| [INFO] [stdout] | |_____________|______| [INFO] [stdout] | |_____________|______| [INFO] [stdout] | |_____________|______| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | | #fn_name: { [INFO] [stdout] 184 | | // It is important to put vtable entry into named function [INFO] [stdout] 185 | | // instead of anonymous callback so function name is meaningful in profiler output. [INFO] [stdout] ... | [INFO] [stdout] 205 | | } [INFO] [stdout] 206 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let field_params_names: Vec<&Ident> = params.iter().map(|p| &p.name).collect(); [INFO] [stdout] 208 | let init_for_black_hole = syn::parse_quote_spanned! {method.sig.span()=> [INFO] [stdout] | _____________-------------------___- [INFO] [stdout] | |_____________|_____________________| [INFO] [stdout] | |_____________|_____________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | | #fn_name: |#(#field_params_names),*| { [INFO] [stdout] 210 | | panic!("BlackHole") [INFO] [stdout] 211 | | } [INFO] [stdout] 212 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | Ok(VTableEntry { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 214 | | field, [INFO] [stdout] 215 | | init, [INFO] [stdout] 216 | | init_for_black_hole, [INFO] [stdout] 217 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vtable.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 224 | let mut new_attrs = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | Ok((item_attrs.unwrap_or_default(), new_attrs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vtable.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 243 | let (item_attrs, new_attrs) = self.process_item_attrs(&m.attrs)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | Ok(Some(self.vtable_entry(m)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_derive` (lib) due to 29 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/any_lifetime.rs:122:11 [INFO] [stdout] | [INFO] [stdout] 120 | input: proc_macro::TokenStream, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | ) -> proc_macro::TokenStream { [INFO] [stdout] 122 | match derive_provides_static_type_impl(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/any_lifetime.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 130 | params: impl Iterator, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | ) -> syn::Result { [INFO] [stdout] 132 | let mut lifetime = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(match lifetime { [INFO] [stdout] | ________^ [INFO] [stdout] 145 | | Some(lifetime) => lifetime, [INFO] [stdout] 146 | | None => syn::parse_quote_spanned! { Span::call_site() => 'pst }, [INFO] [stdout] 147 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/any_lifetime.rs:221:8 [INFO] [stdout] | [INFO] [stdout] 150 | fn derive_provides_static_type_impl(input: proc_macro::TokenStream) -> syn::Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let input: DeriveInput = syn::parse(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let lifetime = pst_lifetime(input.generics.params.iter())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | [INFO] [stdout] 160 | let mut lifetimes: Vec = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let mut static_lifetimes: Vec = Vec::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | let mut type_param_names = Vec::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let mut type_param_bounds = Vec::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | let mut type_param_static_type_bounds = Vec::new(); [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | let mut static_type_params = Vec::new(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let mut const_params = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let mut const_param_names = Vec::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | Ok(if input.generics.lt_token.is_none() { [INFO] [stdout] | ________^ [INFO] [stdout] 222 | | syn::parse_quote_spanned! { span => [INFO] [stdout] 223 | | unsafe impl<#lifetime> #impl_generics starlark::any::ProvidesStaticType<#lifetime> for #name #ty_generics #where_clause { [INFO] [stdout] 224 | | type StaticType = #name #ty_generics; [INFO] [stdout] ... | [INFO] [stdout] 248 | | } [INFO] [stdout] 249 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attrs.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn derive_attrs(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let data = input.data; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let name = input.ident; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | / expand_attrs_derive(data, name) [INFO] [stdout] 37 | | .unwrap_or_else(|e| e.to_compile_error()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bc.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 49 | fn parse(input: ItemEnum) -> BcOpcodeEnum { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | variants: input [INFO] [stdout] | _______________________^ [INFO] [stdout] 53 | | .variants [INFO] [stdout] 54 | | .iter() [INFO] [stdout] 55 | | .map(BcOpcodeEnum::parse_variant) [INFO] [stdout] 56 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/coerce.rs:45:11 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn derive_coerce(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | match derive_coerce_impl(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/docs.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | pub(crate) fn derive_docs(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | [INFO] [stdout] 39 | / expand_docs_derive(input) [INFO] [stdout] 40 | | .unwrap_or_else(|e| e.to_compile_error()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 59 | let mut impl_params = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let mut input_params = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let mut output_params = Vec::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | self.angle_brankets(&impl_params), [INFO] [stdout] 95 | | self.angle_brankets(&input_params), [INFO] [stdout] 96 | | self.angle_brankets(&output_params), [INFO] [stdout] 97 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:344:11 [INFO] [stdout] | [INFO] [stdout] 341 | pub fn derive_freeze(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | [INFO] [stdout] 344 | match derive_freeze_impl(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/mod.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 27 | pub(crate) fn starlark_module(attr: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let input = parse_macro_input!(input as ItemFn); [INFO] [stdout] | ----- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | match starlark_module_impl(attr, input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/mod.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 30 | fn starlark_module_impl(attr: TokenStream, input: ItemFn) -> syn::Result { [INFO] [stdout] | ----------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | assert!(attr.is_empty()); [INFO] [stdout] 32 | let x = parse::parse(input)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(render::render(x)?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/parse/mod.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 58 | pub(crate) fn parse(mut input: ItemFn) -> syn::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let (module_docstring, attrs) = parse_module_attributes(&input); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let visibility = input.vis; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let sig_span = input.sig.span(); [INFO] [stdout] 62 | let name = input.sig.ident; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let arg = input.sig.inputs.pop().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let (ty, module_kind) = match arg.into_value() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | FnArg::Typed(PatType { ty, .. }) if is_mut_globals_builder(&ty) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | FnArg::Typed(PatType { ty, .. }) if is_mut_methods_builder(&ty) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(StarModule { [INFO] [stdout] | ________^ [INFO] [stdout] 88 | | module_kind, [INFO] [stdout] 89 | | visibility, [INFO] [stdout] 90 | | globals_builder: *ty, [INFO] [stdout] ... | [INFO] [stdout] 99 | | .collect::>()?, [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/parse/mod.rs:163:8 [INFO] [stdout] | [INFO] [stdout] 160 | fn parse_const(x: ItemConst) -> syn::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok(StarConst { [INFO] [stdout] | ________^ [INFO] [stdout] 164 | | name: x.ident, [INFO] [stdout] 165 | | ty: *x.ty, [INFO] [stdout] 166 | | value: *x.expr, [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/render/fun.rs:513:16 [INFO] [stdout] | [INFO] [stdout] 474 | let source = match arg.source { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 475 | StarArgSource::This => quote_spanned! {span=> __this}, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | StarArgSource::Argument(i) => quote_spanned! {span=> __args[#i].get()}, [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 477 | StarArgSource::Required(i) => quote_spanned! {span=> Some(__required[#i])}, [INFO] [stdout] | -------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | StarArgSource::Optional(i) => quote_spanned! {span=> __optional[#i]}, [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | let next = if arg.pass_style == StarArgPassStyle::This { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_this(#source)? } [INFO] [stdout] | ------------------------------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_optional(#name_str, #source)? } [INFO] [stdout] | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | / syn::parse_quote_spanned! { span=> [INFO] [stdout] 498 | | { [INFO] [stdout] 499 | | // Combo [INFO] [stdout] 500 | | #[allow(clippy::manual_unwrap_or)] [INFO] [stdout] ... | [INFO] [stdout] 505 | | } [INFO] [stdout] 506 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | } else { [INFO] [stdout] 508 | | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_required(#name_str, #source)? } [INFO] [stdout] | | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 513 | | attrs: arg.attrs.clone(), [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/render/fun.rs:515:15 [INFO] [stdout] | [INFO] [stdout] 474 | let source = match arg.source { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 475 | StarArgSource::This => quote_spanned! {span=> __this}, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | StarArgSource::Argument(i) => quote_spanned! {span=> __args[#i].get()}, [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 477 | StarArgSource::Required(i) => quote_spanned! {span=> Some(__required[#i])}, [INFO] [stdout] | -------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | StarArgSource::Optional(i) => quote_spanned! {span=> __optional[#i]}, [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | let next = if arg.pass_style == StarArgPassStyle::This { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_this(#source)? } [INFO] [stdout] | ------------------------------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_optional(#name_str, #source)? } [INFO] [stdout] | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | / syn::parse_quote_spanned! { span=> [INFO] [stdout] 498 | | { [INFO] [stdout] 499 | | // Combo [INFO] [stdout] 500 | | #[allow(clippy::manual_unwrap_or)] [INFO] [stdout] ... | [INFO] [stdout] 505 | | } [INFO] [stdout] 506 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | } else { [INFO] [stdout] 508 | | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_required(#name_str, #source)? } [INFO] [stdout] | | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 515 | | name: arg.name.to_owned(), [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/render/fun.rs:516:13 [INFO] [stdout] | [INFO] [stdout] 474 | let source = match arg.source { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 475 | StarArgSource::This => quote_spanned! {span=> __this}, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | StarArgSource::Argument(i) => quote_spanned! {span=> __args[#i].get()}, [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 477 | StarArgSource::Required(i) => quote_spanned! {span=> Some(__required[#i])}, [INFO] [stdout] | -------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | StarArgSource::Optional(i) => quote_spanned! {span=> __optional[#i]}, [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | let next = if arg.pass_style == StarArgPassStyle::This { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_this(#source)? } [INFO] [stdout] | ------------------------------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_optional(#name_str, #source)? } [INFO] [stdout] | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | / syn::parse_quote_spanned! { span=> [INFO] [stdout] 498 | | { [INFO] [stdout] 499 | | // Combo [INFO] [stdout] 500 | | #[allow(clippy::manual_unwrap_or)] [INFO] [stdout] ... | [INFO] [stdout] 505 | | } [INFO] [stdout] 506 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | } else { [INFO] [stdout] 508 | | syn::parse_quote_spanned! { span=> starlark::eval::Arguments::check_required(#name_str, #source)? } [INFO] [stdout] | | --------------------------------------------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 516 | | ty: arg.ty.clone(), [INFO] [stdout] | | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module/render/fun.rs:612:8 [INFO] [stdout] | [INFO] [stdout] 553 | let documentation_signature = if need_render_signature { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | / quote_spanned! { [INFO] [stdout] 558 | | span=> { [INFO] [stdout] 559 | | let mut __signature = starlark::eval::ParametersSpec::::new(#name_str.to_owned()); [INFO] [stdout] 560 | | __signature.args(); [INFO] [stdout] ... | [INFO] [stdout] 563 | | } [INFO] [stdout] 564 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 567 | | let docs = match x.docstring.as_ref() { [INFO] [stdout] | | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 568 | | Some(d) => quote_spanned!(span=> Some(#d)), [INFO] [stdout] | | ------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 569 | | None => quote_spanned!(span=> None), [INFO] [stdout] | | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 570 | | }; [INFO] [stdout] 571 | | let parameter_types: Vec = x [INFO] [stdout] | | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 597 | | let return_type_str = render_starlark_return_type(x); [INFO] [stdout] | | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 598 | | let var_name = format_ident!("__documentation"); [INFO] [stdout] | | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 599 | | let as_type = x.as_type_expr(); [INFO] [stdout] | | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 600 | let documentation = quote_spanned!(span=> [INFO] [stdout] | _________-------------___- [INFO] [stdout] | |_________|_______________| [INFO] [stdout] | |_________|_______________| [INFO] [stdout] | |_________|_______________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 601 | | let #var_name = { [INFO] [stdout] 602 | | let parameter_types = std::vec![#(#parameter_types),*]; [INFO] [stdout] 603 | | starlark::values::function::NativeCallableRawDocs { [INFO] [stdout] ... | [INFO] [stdout] 610 | | }; [INFO] [stdout] 611 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 612 | | Ok((var_name, documentation)) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/starlark_type_repr.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 20 | pub(crate) fn derive_starlark_type_repr(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let input = syn::parse_macro_input!(input as syn::DeriveInput); [INFO] [stdout] | ----- -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | match derive_starlark_type_repr_impl(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/starlark_value.rs:29:11 [INFO] [stdout] | [INFO] [stdout] 24 | attr: proc_macro::TokenStream, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | input: proc_macro::TokenStream, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | ) -> proc_macro::TokenStream { [INFO] [stdout] 27 | let attr = syn::parse_macro_input!(attr as StarlarkValueAttrs); [INFO] [stdout] | ---- --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let input = syn::parse_macro_input!(input as syn::ItemImpl); [INFO] [stdout] | ----- ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | match derive_starlark_value_impl(attr, input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/starlark_value.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 89 | input: syn::ItemImpl, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | attrs: StarlarkValueAttrs, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let lifetime_param = match lifetime_param { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(ImplStarlarkValue { [INFO] [stdout] | ________^ [INFO] [stdout] 122 | | input, [INFO] [stdout] 123 | | lifetime_param, [INFO] [stdout] 124 | | attrs, [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/starlark_value.rs:293:12 [INFO] [stdout] | [INFO] [stdout] 266 | let arms = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | let default_arm: Option = if arms.iter().all(Option::is_some) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 288 | Some(syn::parse_quote_spanned! {self.span()=> [INFO] [stdout] | __________________- [INFO] [stdout] | |__________________| [INFO] [stdout] 289 | | _ => { None } [INFO] [stdout] 290 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | }; [INFO] [stdout] 292 | | let arms = arms.into_iter().flatten(); [INFO] [stdout] | | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | Ok(Some(syn::parse_quote_spanned! {self.span()=> [INFO] [stdout] | ____________^ [INFO] [stdout] 294 | fn bin_op_ty(op: starlark::typing::TypingBinOp, _rhs: &starlark::typing::TyBasic) -> Option { [INFO] [stdout] 295 | match op { [INFO] [stdout] 296 | #( #arms )* [INFO] [stdout] ... [INFO] [stdout] 299 | } [INFO] [stdout] 300 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/starlark_value.rs:312:12 [INFO] [stdout] | [INFO] [stdout] 304 | let arms = [ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | Ok(Some(syn::parse_quote_spanned! {self.span()=> [INFO] [stdout] | ____________^ [INFO] [stdout] 313 | | fn rbin_op_ty(_lhs: &starlark::typing::TyBasic, op: starlark::typing::TypingBinOp) -> Option { [INFO] [stdout] 314 | | match op { [INFO] [stdout] 315 | | #( #arms )* [INFO] [stdout] ... | [INFO] [stdout] 320 | | } [INFO] [stdout] 321 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unpack_value.rs:24:11 [INFO] [stdout] | [INFO] [stdout] 22 | pub(crate) fn derive_unpack_value(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let input = syn::parse_macro_input!(input as syn::DeriveInput); [INFO] [stdout] | ----- -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | match derive_unpack_value_impl(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visit_span.rs:77:11 [INFO] [stdout] | [INFO] [stdout] 75 | pub(crate) fn derive_visit_span_mut(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | match derive(input) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vtable.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 88 | fn parse_named_field(field: TokenStream) -> syn::Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(syn::parse2::(field)?.field) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vtable.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 158 | let params: Vec = method [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let field_init_param_pairs: Vec = params.iter().map(|p| p.fn_arg()).collect(); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let ret = match &method.sig.output { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | / quote_spanned! {method.sig.span()=> [INFO] [stdout] 170 | | -> #ty [INFO] [stdout] 171 | | } [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let field = Self::parse_named_field(quote_spanned! {method.sig.span()=> [INFO] [stdout] | _____________-----___________________________- [INFO] [stdout] | |_____________|_______________________________| [INFO] [stdout] | |_____________|_______________________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | | pub(crate) #fn_name: for<'a, 'v> fn( [INFO] [stdout] 177 | | #(#field_fn_param_types),* [INFO] [stdout] 178 | | ) #ret [INFO] [stdout] 179 | | })?; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | let init = syn::parse_quote_spanned! {method.sig.span()=> [INFO] [stdout] | _____________----___- [INFO] [stdout] | |_____________|______| [INFO] [stdout] | |_____________|______| [INFO] [stdout] | |_____________|______| [INFO] [stdout] | |_____________|______| [INFO] [stdout] | |_____________|______| [INFO] [stdout] | |_____________|______| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | | #fn_name: { [INFO] [stdout] 184 | | // It is important to put vtable entry into named function [INFO] [stdout] 185 | | // instead of anonymous callback so function name is meaningful in profiler output. [INFO] [stdout] ... | [INFO] [stdout] 205 | | } [INFO] [stdout] 206 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let field_params_names: Vec<&Ident> = params.iter().map(|p| &p.name).collect(); [INFO] [stdout] 208 | let init_for_black_hole = syn::parse_quote_spanned! {method.sig.span()=> [INFO] [stdout] | _____________-------------------___- [INFO] [stdout] | |_____________|_____________________| [INFO] [stdout] | |_____________|_____________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | | #fn_name: |#(#field_params_names),*| { [INFO] [stdout] 210 | | panic!("BlackHole") [INFO] [stdout] 211 | | } [INFO] [stdout] 212 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | Ok(VTableEntry { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 214 | | field, [INFO] [stdout] 215 | | init, [INFO] [stdout] 216 | | init_for_black_hole, [INFO] [stdout] 217 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vtable.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 224 | let mut new_attrs = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | Ok((item_attrs.unwrap_or_default(), new_attrs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vtable.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 243 | let (item_attrs, new_attrs) = self.process_item_attrs(&m.attrs)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | Ok(Some(self.vtable_entry(m)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_derive` (lib test) due to 29 previous errors [INFO] running `Command { std: "docker" "inspect" "693a579c2eaa7169b2305e4eb1677a7edbfd7f40d6d37586b7410aa5748a72dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "693a579c2eaa7169b2305e4eb1677a7edbfd7f40d6d37586b7410aa5748a72dc", kill_on_drop: false }` [INFO] [stdout] 693a579c2eaa7169b2305e4eb1677a7edbfd7f40d6d37586b7410aa5748a72dc