[INFO] fetching crate starlark_bin 0.12.0... [INFO] checking starlark_bin-0.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate starlark_bin 0.12.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate starlark_bin 0.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate starlark_bin 0.12.0 [INFO] finished tweaking crates.io crate starlark_bin 0.12.0 [INFO] tweaked toml for crates.io crate starlark_bin 0.12.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate starlark_bin 0.12.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ebc8803cdac5ea21af4d85bc7a35e2557f95599369045fc6dac7e0bcf5af750 [INFO] running `Command { std: "docker" "start" "-a" "8ebc8803cdac5ea21af4d85bc7a35e2557f95599369045fc6dac7e0bcf5af750", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ebc8803cdac5ea21af4d85bc7a35e2557f95599369045fc6dac7e0bcf5af750", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ebc8803cdac5ea21af4d85bc7a35e2557f95599369045fc6dac7e0bcf5af750", kill_on_drop: false }` [INFO] [stdout] 8ebc8803cdac5ea21af4d85bc7a35e2557f95599369045fc6dac7e0bcf5af750 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5d842958c9228f488c2e8c100ea34fee8bf7d547b1fdd8b59590271b6888a721 [INFO] running `Command { std: "docker" "start" "-a" "5d842958c9228f488c2e8c100ea34fee8bf7d547b1fdd8b59590271b6888a721", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling smallvec v1.13.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling itoa v1.0.10 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling ryu v1.0.16 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling ena v0.14.2 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling allocative v0.3.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling is-terminal v0.4.11 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling parking_lot v0.12.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling indexmap v2.2.2 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Checking bumpalo v3.14.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling starlark_map v0.12.0 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling regex-automata v0.4.5 [INFO] [stderr] Compiling petgraph v0.6.4 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking annotate-snippets v0.9.2 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking lalrpop-util v0.19.12 [INFO] [stderr] Checking fd-lock v3.0.13 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling starlark v0.12.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking display_container v0.9.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking cmp_any v0.8.1 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking argfile v0.1.6 [INFO] [stderr] Checking rustyline v11.0.0 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Compiling logos-derive v0.12.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling dupe_derive v0.9.0 [INFO] [stderr] Compiling serde_repr v0.1.18 [INFO] [stderr] Compiling allocative_derive v0.3.2 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking dupe v0.9.0 [INFO] [stderr] Compiling starlark_derive v0.12.0 [INFO] [stderr] Checking logos v0.12.1 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking lsp-types v0.94.1 [INFO] [stderr] Checking lsp-server v0.7.6 [INFO] [stderr] Compiling schemafy_core v0.5.2 [INFO] [stderr] Compiling schemafy_lib v0.5.2 [INFO] [stderr] Compiling starlark_syntax v0.12.0 [INFO] [stderr] Compiling schemafy v0.5.2 [INFO] [stderr] Checking debugserver-types v0.5.0 [INFO] [stderr] Checking starlark_lsp v0.12.0 [INFO] [stderr] Checking starlark_bin v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/main.rs:155:29 [INFO] [stdout] | [INFO] [stdout] 154 | let extension = Arc::new(extension.to_owned()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | xs.into_iter().flat_map(move |x| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 156 | | // Have to keep cloning extension so we keep ownership [INFO] [stdout] 157 | | let extension = extension.dupe(); [INFO] [stdout] 158 | | if x.is_dir() { [INFO] [stdout] ... | [INFO] [stdout] 168 | | } [INFO] [stdout] 169 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/bazel.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 178 | let globals = globals(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let prelude: Vec<_> = prelude [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let module = if module { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let mut builtins: HashMap> = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let mut raw_command = Command::new("bazel"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 234 | | mode, [INFO] [stdout] 235 | | print_non_none, [INFO] [stdout] 236 | | prelude, [INFO] [stdout] ... | [INFO] [stdout] 251 | | .map(|output_base| PathBuf::from(output_base).join("external")), [INFO] [stdout] 252 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/bazel.rs:307:23 [INFO] [stdout] | [INFO] [stdout] 293 | fn go(&self, file: &str, ast: AstModule) -> EvalResult> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | let mut warnings = Either::Left(iter::empty()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | let mut errors = Either::Left(iter::empty()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | let final_ast = match self.mode { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | messages: warnings.chain(errors), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/bazel.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 312 | fn run(&self, file: &str, ast: AstModule) -> EvalResult> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | let new_module; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | let mut eval = Evaluator::new(module); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | eval.enable_terminal_breakpoint_console(); [INFO] [stdout] 323 | let globals = globals(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | / eval.eval_module(ast, &globals) [INFO] [stdout] 327 | | .map(|v| { [INFO] [stdout] 328 | | if self.print_non_none && !v.is_none() { [INFO] [stdout] 329 | | println!("{}", v); [INFO] [stdout] ... | [INFO] [stdout] 335 | | }) [INFO] [stdout] 336 | | .map_err(Into::into), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/bazel.rs:358:9 [INFO] [stdout] | [INFO] [stdout] 341 | let globals = if self.prelude.is_empty() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | let mut globals = HashSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | / module [INFO] [stdout] 359 | | .lint(globals.as_ref()) [INFO] [stdout] 360 | | .into_iter() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/bazel.rs:668:13 [INFO] [stdout] | [INFO] [stdout] 668 | Err(ResolveLoadError::TargetNotFound(path.to_owned()).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/mod.rs:228:22 [INFO] [stdout] | [INFO] [stdout] 226 | let (adapter, wrapper) = prepare_dap_adapter(Box::new(client.dupe())); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | Backend { [INFO] [stdout] 228 | adapter: Arc::new(adapter), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/mod.rs:229:27 [INFO] [stdout] | [INFO] [stdout] 226 | let (adapter, wrapper) = prepare_dap_adapter(Box::new(client.dupe())); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | eval_wrapper: Mutex::new(Some(Box::new(wrapper))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/events.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 40 | fn event(&self, x: impl Serialize) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | send(serde_json::to_value(&x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/requests.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 56 | fn ret(r: &Request, v: anyhow::Result>) -> Response { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | body: v.unwrap_or(None).map(|v| serde_json::to_value(v).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/requests.rs:64:45 [INFO] [stdout] | [INFO] [stdout] 64 | body: v.unwrap_or(None).map(|v| serde_json::to_value(v).unwrap()), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/requests.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 68 | fn ret_some(r: &Request, v: anyhow::Result) -> Response { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | ret(r, v.map(Some)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/requests.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 72 | fn ret_none(r: &Request, v: anyhow::Result<()>) -> Response { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | ret::<()>(r, v.map(|_| None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/stream.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 45 | let mut file = OpenOptions::new().append(true).open(log_file()).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | file.write_all(format!("{}\n", x).as_bytes()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/eval.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 101 | let globals = globals(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let prelude: Vec<_> = prelude [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let module = if module { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let mut builtins: HashMap> = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 135 | | mode, [INFO] [stdout] 136 | | print_non_none, [INFO] [stdout] 137 | | prelude, [INFO] [stdout] ... | [INFO] [stdout] 140 | | builtin_symbols, [INFO] [stdout] 141 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/eval.rs:179:23 [INFO] [stdout] | [INFO] [stdout] 165 | fn go(&self, file: &str, ast: AstModule) -> EvalResult> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let mut warnings = Either::Left(iter::empty()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let mut errors = Either::Left(iter::empty()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let final_ast = match self.mode { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | messages: warnings.chain(errors), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/eval.rs:220:30 [INFO] [stdout] | [INFO] [stdout] 220 | .map_err(|e| anyhow::Error::from(e).into()), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/eval.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 237 | fn run(&self, file: &str, ast: AstModule) -> EvalResult> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let new_module; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let mut eval = Evaluator::new(module); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | eval.enable_terminal_breakpoint_console(); [INFO] [stdout] 248 | let globals = globals(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | / eval.eval_module(ast, &globals) [INFO] [stdout] 252 | | .map(|v| { [INFO] [stdout] 253 | | if self.print_non_none && !v.is_none() { [INFO] [stdout] 254 | | println!("{}", v); [INFO] [stdout] ... | [INFO] [stdout] 260 | | }) [INFO] [stdout] 261 | | .map_err(Into::into), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/eval.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 266 | let globals = if self.prelude.is_empty() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let mut globals = HashSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | / module [INFO] [stdout] 284 | | .lint(globals.as_ref()) [INFO] [stdout] 285 | | .into_iter() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/main.rs:155:29 [INFO] [stdout] | [INFO] [stdout] 154 | let extension = Arc::new(extension.to_owned()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | xs.into_iter().flat_map(move |x| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 156 | | // Have to keep cloning extension so we keep ownership [INFO] [stdout] 157 | | let extension = extension.dupe(); [INFO] [stdout] 158 | | if x.is_dir() { [INFO] [stdout] ... | [INFO] [stdout] 168 | | } [INFO] [stdout] 169 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/bazel.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 178 | let globals = globals(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let prelude: Vec<_> = prelude [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let module = if module { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let mut builtins: HashMap> = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let mut raw_command = Command::new("bazel"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 234 | | mode, [INFO] [stdout] 235 | | print_non_none, [INFO] [stdout] 236 | | prelude, [INFO] [stdout] ... | [INFO] [stdout] 251 | | .map(|output_base| PathBuf::from(output_base).join("external")), [INFO] [stdout] 252 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/bazel.rs:307:23 [INFO] [stdout] | [INFO] [stdout] 293 | fn go(&self, file: &str, ast: AstModule) -> EvalResult> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | let mut warnings = Either::Left(iter::empty()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | let mut errors = Either::Left(iter::empty()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | let final_ast = match self.mode { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | messages: warnings.chain(errors), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/bazel.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 312 | fn run(&self, file: &str, ast: AstModule) -> EvalResult> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | let new_module; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | let mut eval = Evaluator::new(module); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | eval.enable_terminal_breakpoint_console(); [INFO] [stdout] 323 | let globals = globals(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | / eval.eval_module(ast, &globals) [INFO] [stdout] 327 | | .map(|v| { [INFO] [stdout] 328 | | if self.print_non_none && !v.is_none() { [INFO] [stdout] 329 | | println!("{}", v); [INFO] [stdout] ... | [INFO] [stdout] 335 | | }) [INFO] [stdout] 336 | | .map_err(Into::into), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/bazel.rs:358:9 [INFO] [stdout] | [INFO] [stdout] 341 | let globals = if self.prelude.is_empty() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | let mut globals = HashSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | / module [INFO] [stdout] 359 | | .lint(globals.as_ref()) [INFO] [stdout] 360 | | .into_iter() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/bazel.rs:668:13 [INFO] [stdout] | [INFO] [stdout] 668 | Err(ResolveLoadError::TargetNotFound(path.to_owned()).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/mod.rs:228:22 [INFO] [stdout] | [INFO] [stdout] 226 | let (adapter, wrapper) = prepare_dap_adapter(Box::new(client.dupe())); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | Backend { [INFO] [stdout] 228 | adapter: Arc::new(adapter), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/mod.rs:229:27 [INFO] [stdout] | [INFO] [stdout] 226 | let (adapter, wrapper) = prepare_dap_adapter(Box::new(client.dupe())); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | eval_wrapper: Mutex::new(Some(Box::new(wrapper))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/events.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 40 | fn event(&self, x: impl Serialize) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | send(serde_json::to_value(&x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/requests.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 56 | fn ret(r: &Request, v: anyhow::Result>) -> Response { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | body: v.unwrap_or(None).map(|v| serde_json::to_value(v).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/requests.rs:64:45 [INFO] [stdout] | [INFO] [stdout] 64 | body: v.unwrap_or(None).map(|v| serde_json::to_value(v).unwrap()), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/requests.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 68 | fn ret_some(r: &Request, v: anyhow::Result) -> Response { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | ret(r, v.map(Some)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/requests.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 72 | fn ret_none(r: &Request, v: anyhow::Result<()>) -> Response { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | ret::<()>(r, v.map(|_| None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/dap/library/stream.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 45 | let mut file = OpenOptions::new().append(true).open(log_file()).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | file.write_all(format!("{}\n", x).as_bytes()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/eval.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 101 | let globals = globals(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let prelude: Vec<_> = prelude [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let module = if module { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let mut builtins: HashMap> = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 135 | | mode, [INFO] [stdout] 136 | | print_non_none, [INFO] [stdout] 137 | | prelude, [INFO] [stdout] ... | [INFO] [stdout] 140 | | builtin_symbols, [INFO] [stdout] 141 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/eval.rs:179:23 [INFO] [stdout] | [INFO] [stdout] 165 | fn go(&self, file: &str, ast: AstModule) -> EvalResult> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let mut warnings = Either::Left(iter::empty()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let mut errors = Either::Left(iter::empty()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let final_ast = match self.mode { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | messages: warnings.chain(errors), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/eval.rs:220:30 [INFO] [stdout] | [INFO] [stdout] 220 | .map_err(|e| anyhow::Error::from(e).into()), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/eval.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 237 | fn run(&self, file: &str, ast: AstModule) -> EvalResult> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let new_module; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let mut eval = Evaluator::new(module); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | eval.enable_terminal_breakpoint_console(); [INFO] [stdout] 248 | let globals = globals(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | / eval.eval_module(ast, &globals) [INFO] [stdout] 252 | | .map(|v| { [INFO] [stdout] 253 | | if self.print_non_none && !v.is_none() { [INFO] [stdout] 254 | | println!("{}", v); [INFO] [stdout] ... | [INFO] [stdout] 260 | | }) [INFO] [stdout] 261 | | .map_err(Into::into), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_bin` (bin "starlark") due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bin/eval.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 266 | let globals = if self.prelude.is_empty() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let mut globals = HashSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | / module [INFO] [stdout] 284 | | .lint(globals.as_ref()) [INFO] [stdout] 285 | | .into_iter() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_bin` (bin "starlark" test) due to 20 previous errors [INFO] running `Command { std: "docker" "inspect" "5d842958c9228f488c2e8c100ea34fee8bf7d547b1fdd8b59590271b6888a721", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d842958c9228f488c2e8c100ea34fee8bf7d547b1fdd8b59590271b6888a721", kill_on_drop: false }` [INFO] [stdout] 5d842958c9228f488c2e8c100ea34fee8bf7d547b1fdd8b59590271b6888a721