[INFO] fetching crate starlane-macros 0.1.0... [INFO] checking starlane-macros-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate starlane-macros 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate starlane-macros 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate starlane-macros 0.1.0 [INFO] finished tweaking crates.io crate starlane-macros 0.1.0 [INFO] tweaked toml for crates.io crate starlane-macros 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef050dd89eb2bca1b8dffccab036e75b11649aa6c37fe19f3b9d4caa641450b3 [INFO] running `Command { std: "docker" "start" "-a" "ef050dd89eb2bca1b8dffccab036e75b11649aa6c37fe19f3b9d4caa641450b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef050dd89eb2bca1b8dffccab036e75b11649aa6c37fe19f3b9d4caa641450b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef050dd89eb2bca1b8dffccab036e75b11649aa6c37fe19f3b9d4caa641450b3", kill_on_drop: false }` [INFO] [stdout] ef050dd89eb2bca1b8dffccab036e75b11649aa6c37fe19f3b9d4caa641450b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b35f3cff6d672ab5c20fcc5b30532fb9576a858107a17dc37ce06ef62103fed [INFO] running `Command { std: "docker" "start" "-a" "6b35f3cff6d672ab5c20fcc5b30532fb9576a858107a17dc37ce06ef62103fed", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking starlane-macros v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Expr`, `MetaNameValue`, `PathArguments`, `Token`, `Type`, and `Visibility` [INFO] [stdout] --> src/lib.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | parse_macro_input, Expr, Ident, Item, ItemEnum, Lit, Meta, MetaList, MetaNameValue, NestedMeta, [INFO] [stdout] | ^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] 14 | Path, PathArguments, Token, Type, Visibility, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^ ^^^^ ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Expr`, `MetaNameValue`, `PathArguments`, `Token`, `Type`, and `Visibility` [INFO] [stdout] --> src/lib.rs:13:24 [INFO] [stdout] | [INFO] [stdout] 13 | parse_macro_input, Expr, Ident, Item, ItemEnum, Lit, Meta, MetaList, MetaNameValue, NestedMeta, [INFO] [stdout] | ^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] 14 | Path, PathArguments, Token, Type, Visibility, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^ ^^^^ ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Res` is never used [INFO] [stdout] --> src/lib.rs:17:6 [INFO] [stdout] | [INFO] [stdout] 17 | type Res = IResult>; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ident_to_resource` is never read [INFO] [stdout] --> src/lib.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 19 | struct ResourceParser { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | pub ident_to_resource: HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `children_of` is never used [INFO] [stdout] --> src/lib.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl ResourceParser { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] 26 | pub fn children_of(&self, parent: Resource) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PathIdent` is never constructed [INFO] [stdout] --> src/lib.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 93 | struct PathIdent { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extras` is never used [INFO] [stdout] --> src/lib.rs:1490:4 [INFO] [stdout] | [INFO] [stdout] 1490 | fn extras() -> TokenStream { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_uppercase` is never used [INFO] [stdout] --> src/lib.rs:1664:4 [INFO] [stdout] | [INFO] [stdout] 1664 | fn is_uppercase(a: char) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_camel` is never used [INFO] [stdout] --> src/lib.rs:1668:4 [INFO] [stdout] | [INFO] [stdout] 1668 | fn parse_camel(input: &str) -> Res<&str, Vec> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:24 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new(item: Item) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | path_part: Option::None, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:32 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new(item: Item) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | state_persistence: Option::None, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 148 | let mut kinds: Vec = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let mut resources: Vec = vec![]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let mut ident_to_resource = HashMap::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 247 | | kinds: kinds, [INFO] [stdout] 248 | | resources: resources, [INFO] [stdout] 249 | | ident_to_resource, [INFO] [stdout] 250 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:278:96 [INFO] [stdout] | [INFO] [stdout] 278 | .map(|resource| Ident::new(format!("{}",parsed.kind_for(resource).is_some()).as_str(), resource.get_ident().span()) ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `ident_to_resource` is never read [INFO] [stdout] --> src/lib.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 19 | struct ResourceParser { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | pub ident_to_resource: HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `children_of` is never used [INFO] [stdout] --> src/lib.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl ResourceParser { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] 26 | pub fn children_of(&self, parent: Resource) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PathIdent` is never constructed [INFO] [stdout] --> src/lib.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 93 | struct PathIdent { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extras` is never used [INFO] [stdout] --> src/lib.rs:1490:4 [INFO] [stdout] | [INFO] [stdout] 1490 | fn extras() -> TokenStream { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:24 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new(item: Item) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | path_part: Option::None, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:32 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new(item: Item) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | state_persistence: Option::None, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 148 | let mut kinds: Vec = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let mut resources: Vec = vec![]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let mut ident_to_resource = HashMap::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 247 | | kinds: kinds, [INFO] [stdout] 248 | | resources: resources, [INFO] [stdout] 249 | | ident_to_resource, [INFO] [stdout] 250 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:278:96 [INFO] [stdout] | [INFO] [stdout] 278 | .map(|resource| Ident::new(format!("{}",parsed.kind_for(resource).is_some()).as_str(), resource.get_ident().span()) ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlane-macros` (lib) due to 5 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `starlane-macros` (lib test) due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6b35f3cff6d672ab5c20fcc5b30532fb9576a858107a17dc37ce06ef62103fed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b35f3cff6d672ab5c20fcc5b30532fb9576a858107a17dc37ce06ef62103fed", kill_on_drop: false }` [INFO] [stdout] 6b35f3cff6d672ab5c20fcc5b30532fb9576a858107a17dc37ce06ef62103fed