[INFO] fetching crate starbox 0.3.1... [INFO] checking starbox-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate starbox 0.3.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate starbox 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate starbox 0.3.1 [INFO] finished tweaking crates.io crate starbox 0.3.1 [INFO] tweaked toml for crates.io crate starbox 0.3.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate starbox 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 121ca9072ed74181724a368aa932e628b123b2e63f2746a3de6d3ad5a4235c7c [INFO] running `Command { std: "docker" "start" "-a" "121ca9072ed74181724a368aa932e628b123b2e63f2746a3de6d3ad5a4235c7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "121ca9072ed74181724a368aa932e628b123b2e63f2746a3de6d3ad5a4235c7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "121ca9072ed74181724a368aa932e628b123b2e63f2746a3de6d3ad5a4235c7c", kill_on_drop: false }` [INFO] [stdout] 121ca9072ed74181724a368aa932e628b123b2e63f2746a3de6d3ad5a4235c7c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 66a785b54a4417d2de5847cfa7f631a2a7db34a8a77440a34174be639a4cd80a [INFO] running `Command { std: "docker" "start" "-a" "66a785b54a4417d2de5847cfa7f631a2a7db34a8a77440a34174be639a4cd80a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling serde_derive v1.0.127 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling serde v1.0.127 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking bytemuck v1.7.2 [INFO] [stderr] Checking exoquant v0.2.0 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling cmake v0.1.45 [INFO] [stderr] Checking gif v0.11.2 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking flate2 v1.0.20 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking starbox v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:49:41 [INFO] [stdout] | [INFO] [stdout] 49 | #[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:41 [INFO] [stdout] | [INFO] [stdout] 58 | #[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:41 [INFO] [stdout] | [INFO] [stdout] 66 | #[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 105 | let palette = load_jasc_palette(pal_name)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let bytes: Bytes = img [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | Ok(Canvas { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | palette: pal_name.to_string(), [INFO] [stdout] 140 | | size, [INFO] [stdout] 141 | | bytes, [INFO] [stdout] 142 | | ..Default::default() [INFO] [stdout] 143 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 228 | let test_segment = Canvas { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 245 | | .bytes [INFO] [stdout] 246 | | .chunks(size_bytes) [INFO] [stdout] 247 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 256 | | }) [INFO] [stdout] 257 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:24 [INFO] [stdout] | [INFO] [stdout] 255 | bytes: Bytes::copy_from_slice(chunk), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:279:12 [INFO] [stdout] | [INFO] [stdout] 275 | let bytes = segments [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Ok(Canvas { [INFO] [stdout] | ____________^ [INFO] [stdout] 280 | | title: first_segment.title.to_owned(), [INFO] [stdout] 281 | | author: first_segment.author.to_owned(), [INFO] [stdout] 282 | | palette: first_segment.palette.to_owned(), [INFO] [stdout] ... | [INFO] [stdout] 286 | | bytes, [INFO] [stdout] 287 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:324:12 [INFO] [stdout] | [INFO] [stdout] 321 | let mut decoder = DeflateDecoder::new(bytes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | Ok(bincode::deserialize::(&bytes)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starbox` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:49:41 [INFO] [stdout] | [INFO] [stdout] 49 | #[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:41 [INFO] [stdout] | [INFO] [stdout] 58 | #[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:41 [INFO] [stdout] | [INFO] [stdout] 66 | #[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 105 | let palette = load_jasc_palette(pal_name)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let bytes: Bytes = img [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | Ok(Canvas { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | palette: pal_name.to_string(), [INFO] [stdout] 140 | | size, [INFO] [stdout] 141 | | bytes, [INFO] [stdout] 142 | | ..Default::default() [INFO] [stdout] 143 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 228 | let test_segment = Canvas { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 245 | | .bytes [INFO] [stdout] 246 | | .chunks(size_bytes) [INFO] [stdout] 247 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 256 | | }) [INFO] [stdout] 257 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:24 [INFO] [stdout] | [INFO] [stdout] 255 | bytes: Bytes::copy_from_slice(chunk), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:279:12 [INFO] [stdout] | [INFO] [stdout] 275 | let bytes = segments [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Ok(Canvas { [INFO] [stdout] | ____________^ [INFO] [stdout] 280 | | title: first_segment.title.to_owned(), [INFO] [stdout] 281 | | author: first_segment.author.to_owned(), [INFO] [stdout] 282 | | palette: first_segment.palette.to_owned(), [INFO] [stdout] ... | [INFO] [stdout] 286 | | bytes, [INFO] [stdout] 287 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:324:12 [INFO] [stdout] | [INFO] [stdout] 321 | let mut decoder = DeflateDecoder::new(bytes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | Ok(bincode::deserialize::(&bytes)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starbox` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "66a785b54a4417d2de5847cfa7f631a2a7db34a8a77440a34174be639a4cd80a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66a785b54a4417d2de5847cfa7f631a2a7db34a8a77440a34174be639a4cd80a", kill_on_drop: false }` [INFO] [stdout] 66a785b54a4417d2de5847cfa7f631a2a7db34a8a77440a34174be639a4cd80a