[INFO] fetching crate standard-dist 1.0.0... [INFO] checking standard-dist-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate standard-dist 1.0.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate standard-dist 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate standard-dist 1.0.0 [INFO] finished tweaking crates.io crate standard-dist 1.0.0 [INFO] tweaked toml for crates.io crate standard-dist 1.0.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed1e6ade6cc36c9b948acaeeb8e34a17a27a5bf89cb96b41f6668f6ba7f1e322 [INFO] running `Command { std: "docker" "start" "-a" "ed1e6ade6cc36c9b948acaeeb8e34a17a27a5bf89cb96b41f6668f6ba7f1e322", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed1e6ade6cc36c9b948acaeeb8e34a17a27a5bf89cb96b41f6668f6ba7f1e322", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed1e6ade6cc36c9b948acaeeb8e34a17a27a5bf89cb96b41f6668f6ba7f1e322", kill_on_drop: false }` [INFO] [stdout] ed1e6ade6cc36c9b948acaeeb8e34a17a27a5bf89cb96b41f6668f6ba7f1e322 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dec192b96b5337abb80010ec904283bf3eda37a0876ed9463b027cc38d07786a [INFO] running `Command { std: "docker" "start" "-a" "dec192b96b5337abb80010ec904283bf3eda37a0876ed9463b027cc38d07786a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking standard-dist v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:362:35 [INFO] [stdout] | [INFO] [stdout] 362 | input.step(|cursor| match cursor.ident() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:413:32 [INFO] [stdout] | [INFO] [stdout] 411 | .map(|init| FieldDistributionSpec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 412 | init, [INFO] [stdout] 413 | container: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:465:5 [INFO] [stdout] | [INFO] [stdout] 463 | fields: impl Iterator, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | ) -> syn::Result { [INFO] [stdout] 465 | / fields [INFO] [stdout] 466 | | .map(|field| { [INFO] [stdout] 467 | | let field_type = &field.ty; [INFO] [stdout] 468 | | let distribution = field_distribution(&field)?; [INFO] [stdout] ... | [INFO] [stdout] 502 | | }) [INFO] [stdout] 503 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:499:16 [INFO] [stdout] | [INFO] [stdout] 468 | let distribution = field_distribution(&field)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 469 | let (dist_ty, dist_init) = match distribution.container { [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | None => (parse_quote! {_}, distribution.init), [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 471 | Some(container) => { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 472 | let ty = container.ty; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 473 | let init = distribution.init; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 478 | parse_quote! {&'static #ty}, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | / parse_quote! {{ [INFO] [stdout] 480 | | static DISTRIBUTION: ::once_cell::sync::OnceCell<#ty> = [INFO] [stdout] 481 | | ::once_cell::sync::OnceCell::new(); [INFO] [stdout] ... | [INFO] [stdout] 484 | | }}, [INFO] [stdout] | | - [INFO] [stdout] | |______________________________| [INFO] [stdout] | |______________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 487 | | parse_quote! {&'static #ty}, [INFO] [stdout] | | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 488 | / parse_quote! {{ [INFO] [stdout] 489 | | static DISTRIBUTION: #ty = #init; [INFO] [stdout] 490 | | [INFO] [stdout] 491 | | &DISTRIBUTION [INFO] [stdout] 492 | | }}, [INFO] [stdout] | | - [INFO] [stdout] | |______________________________| [INFO] [stdout] | |______________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | | let init = quote! { ::rand::Rng::sample::<#field_type, #dist_ty>(#rng, #dist_init), }; [INFO] [stdout] | | ---- -------------------------------------------------------------------------- [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 499 | Ok(match &field.ident { [INFO] [stdout] | ________________^ [INFO] [stdout] | |________________| [INFO] [stdout] 500 | | Some(field_ident) => quote! { #field_ident: #init }, [INFO] [stdout] 501 | | None => init, [INFO] [stdout] 502 | | }) [INFO] [stdout] | |_____________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:684:36 [INFO] [stdout] | [INFO] [stdout] 684 | .flat_map(|clause| clause.predicates.iter().map(|pred| pred.to_token_stream())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `standard-dist` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "dec192b96b5337abb80010ec904283bf3eda37a0876ed9463b027cc38d07786a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dec192b96b5337abb80010ec904283bf3eda37a0876ed9463b027cc38d07786a", kill_on_drop: false }` [INFO] [stdout] dec192b96b5337abb80010ec904283bf3eda37a0876ed9463b027cc38d07786a