[INFO] fetching crate stackmate 0.8.0... [INFO] checking stackmate-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate stackmate 0.8.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate stackmate 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate stackmate 0.8.0 [INFO] finished tweaking crates.io crate stackmate 0.8.0 [INFO] tweaked toml for crates.io crate stackmate 0.8.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 132 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding base32 v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding base64 v0.10.1 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bdk v0.16.1 (latest: v0.29.0) [INFO] [stderr] Adding bech32 v0.8.1 (latest: v0.11.0) [INFO] [stderr] Adding bip39 v1.2.0 (latest: v2.0.0) [INFO] [stderr] Adding bitcoin v0.27.1 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin_hashes v0.10.0 (latest: v0.14.0) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (latest: v0.14.0) [INFO] [stderr] Adding bitcoincore-rpc v0.14.0 (latest: v0.19.0) [INFO] [stderr] Adding bitcoincore-rpc-json v0.14.0 (latest: v0.19.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding electrum-client v0.8.0 (latest: v0.21.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding jsonrpc v0.12.1 (latest: v0.18.0) [INFO] [stderr] Adding libtor v46.9.0+0.4.6.x (latest: v47.13.0+0.4.7.x) [INFO] [stderr] Adding libtor-sys v46.9.1+0.4.6.9 (latest: v47.13.0+0.4.7.x) [INFO] [stderr] Adding miniscript v6.1.0 (latest: v12.2.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustls v0.16.0 (latest: v0.23.12) [INFO] [stderr] Adding sct v0.6.1 (latest: v0.7.1) [INFO] [stderr] Adding secp256k1 v0.20.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1 v0.21.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.4.2 (latest: v0.10.0) [INFO] [stderr] Adding sha1 v0.6.1 (latest: v0.10.6) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v1.14.1 (latest: v1.40.0) [INFO] [stderr] Adding unicode-normalization v0.1.9 (latest: v0.1.23) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki v0.21.4 (latest: v0.22.4) [INFO] [stderr] Adding webpki-roots v0.19.0 (latest: v0.26.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: version requirement `46.6.1+0.4.6.6` for dependency `libtor` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a11bab6d8dd1f1a8c1a4a67231b1907d0560e7d15ddb192c15b0c45d0edac5e2 [INFO] running `Command { std: "docker" "start" "-a" "a11bab6d8dd1f1a8c1a4a67231b1907d0560e7d15ddb192c15b0c45d0edac5e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a11bab6d8dd1f1a8c1a4a67231b1907d0560e7d15ddb192c15b0c45d0edac5e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a11bab6d8dd1f1a8c1a4a67231b1907d0560e7d15ddb192c15b0c45d0edac5e2", kill_on_drop: false }` [INFO] [stdout] a11bab6d8dd1f1a8c1a4a67231b1907d0560e7d15ddb192c15b0c45d0edac5e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0161157dc20e7f0051271faa1e61902f8bb0a0466e1a55a337ce26e8cd0c4f84 [INFO] running `Command { std: "docker" "start" "-a" "0161157dc20e7f0051271faa1e61902f8bb0a0466e1a55a337ce26e8cd0c4f84", kill_on_drop: false }` [INFO] [stderr] warning: version requirement `46.6.1+0.4.6.6` for dependency `libtor` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking base64-compat v1.0.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking bech32 v0.8.1 [INFO] [stderr] Compiling secp256k1-sys v0.4.2 [INFO] [stderr] Compiling openssl-src v300.3.1+3.3.1 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling autotools v0.2.7 [INFO] [stderr] Checking bitcoin_hashes v0.10.0 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling tokio v1.14.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking socks v0.3.4 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking unicode-normalization v0.1.9 [INFO] [stderr] Compiling libtor-sys v46.9.1+0.4.6.9 [INFO] [stderr] Checking sha1 v0.6.1 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking base32 v0.4.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking jsonrpc v0.12.1 [INFO] [stderr] Checking secp256k1 v0.20.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking bip39 v1.2.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling libtor-derive v0.1.2 [INFO] [stderr] Compiling bdk-macros v0.6.0 [INFO] [stderr] Checking bitcoin v0.27.1 [INFO] [stderr] Checking secp256k1 v0.21.3 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki-roots v0.19.0 [INFO] [stderr] Checking rustls v0.16.0 [INFO] [stderr] Checking bitcoincore-rpc-json v0.14.0 [INFO] [stderr] Checking electrum-client v0.8.0 [INFO] [stderr] Checking miniscript v6.1.0 [INFO] [stderr] Checking bitcoincore-rpc v0.14.0 [INFO] [stderr] Checking bdk v0.16.1 [INFO] [stderr] Checking libtor v46.9.0+0.4.6.x [INFO] [stderr] Checking stackmate v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/lib.rs:1091:5 [INFO] [stdout] | [INFO] [stdout] 1091 | CString::from_raw(ptr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1091 | let _ = CString::from_raw(ptr); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 88 | let client = match create_blockchain_client(AnyBlockchainConfig::Electrum(config)) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Ok(client) => client, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(WalletConfig { [INFO] [stdout] | ________^ [INFO] [stdout] 94 | | deposit_desc: deposit_desc.to_string(), [INFO] [stdout] 95 | | change_desc: change_desc.to_string(), [INFO] [stdout] 96 | | network, [INFO] [stdout] 97 | | client: Some(client), [INFO] [stdout] 98 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 157 | let client: AnyBlockchain = if node_address.contains("electrum") { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Ok(client) => client, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Ok(client) => client, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | match client.estimate_fee(1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key/seed.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 23 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | CString::new(stringified).unwrap().into_raw() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/key/ec.rs:72:33 [INFO] [stdout] | [INFO] [stdout] 72 | let public_key = if public_key.clone().len() == 64 { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/key/ec.rs:73:34 [INFO] [stdout] | [INFO] [stdout] 73 | "02".to_string() + public_key.clone() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/key/ec.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | } else if public_key.clone().len() == 66 { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/address.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 27 | config: WalletConfig, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let wallet = match Wallet::new_offline( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Err(e) => return Err(S5Error::new(ErrorKind::Internal,&e.to_string())) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | }; [INFO] [stdout] 39 | match wallet.get_address(Peek(index)){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/history.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn sync_history(config: WalletConfig) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let wallet = match Wallet::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | match wallet.list_transactions(false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/history.rs:94:52 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|txdetail| Transaction::from_txdetail(txdetail.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/history.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn sync_balance(config: WalletConfig) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let wallet = match Wallet::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | match wallet.get_balance() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/coldcard.rs:59:11 [INFO] [stdout] | [INFO] [stdout] 55 | let file = match File::open(path){ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(file)=>file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | match serde_json::from_reader(file){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `_KeychainKind` should have a snake case name [INFO] [stdout] --> src/wallet/psbt.rs:146:41 [INFO] [stdout] | [INFO] [stdout] 146 | Error::SpendingPolicyRequired(_KeychainKind) => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `_keychain_kind` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stackmate` (lib) due to 9 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused return value of `std::ffi::CString::from_raw` that must be used [INFO] [stdout] --> src/lib.rs:1091:5 [INFO] [stdout] | [INFO] [stdout] 1091 | CString::from_raw(ptr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1091 | let _ = CString::from_raw(ptr); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 88 | let client = match create_blockchain_client(AnyBlockchainConfig::Electrum(config)) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Ok(client) => client, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(WalletConfig { [INFO] [stdout] | ________^ [INFO] [stdout] 94 | | deposit_desc: deposit_desc.to_string(), [INFO] [stdout] 95 | | change_desc: change_desc.to_string(), [INFO] [stdout] 96 | | network, [INFO] [stdout] 97 | | client: Some(client), [INFO] [stdout] 98 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 157 | let client: AnyBlockchain = if node_address.contains("electrum") { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Ok(client) => client, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Ok(client) => client, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | match client.estimate_fee(1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key/seed.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 23 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | CString::new(stringified).unwrap().into_raw() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/key/ec.rs:72:33 [INFO] [stdout] | [INFO] [stdout] 72 | let public_key = if public_key.clone().len() == 64 { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/key/ec.rs:73:34 [INFO] [stdout] | [INFO] [stdout] 73 | "02".to_string() + public_key.clone() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/key/ec.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | } else if public_key.clone().len() == 66 { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/key/aes.rs:81:47 [INFO] [stdout] | [INFO] [stdout] 81 | let iv_ciphertext = cbc_encrypt(secret.clone(),key.clone(),Encoding::Base64); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/key/aes.rs:81:59 [INFO] [stdout] | [INFO] [stdout] 81 | let iv_ciphertext = cbc_encrypt(secret.clone(),key.clone(),Encoding::Base64); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/key/aes.rs:83:64 [INFO] [stdout] | [INFO] [stdout] 83 | let plaintext = cbc_decrypt(&iv_ciphertext.clone(), key.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/address.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 27 | config: WalletConfig, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let wallet = match Wallet::new_offline( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Err(e) => return Err(S5Error::new(ErrorKind::Internal,&e.to_string())) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | }; [INFO] [stdout] 39 | match wallet.get_address(Peek(index)){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/history.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn sync_history(config: WalletConfig) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let wallet = match Wallet::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | match wallet.list_transactions(false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/history.rs:94:52 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|txdetail| Transaction::from_txdetail(txdetail.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/history.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn sync_balance(config: WalletConfig) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | let wallet = match Wallet::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | match wallet.get_balance() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/coldcard.rs:59:11 [INFO] [stdout] | [INFO] [stdout] 55 | let file = match File::open(path){ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(file)=>file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | match serde_json::from_reader(file){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `_KeychainKind` should have a snake case name [INFO] [stdout] --> src/wallet/psbt.rs:146:41 [INFO] [stdout] | [INFO] [stdout] 146 | Error::SpendingPolicyRequired(_KeychainKind) => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `_keychain_kind` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stackmate` (lib test) due to 9 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0161157dc20e7f0051271faa1e61902f8bb0a0466e1a55a337ce26e8cd0c4f84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0161157dc20e7f0051271faa1e61902f8bb0a0466e1a55a337ce26e8cd0c4f84", kill_on_drop: false }` [INFO] [stdout] 0161157dc20e7f0051271faa1e61902f8bb0a0466e1a55a337ce26e8cd0c4f84