[INFO] fetching crate stackdump-trace 0.4.0... [INFO] checking stackdump-trace-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate stackdump-trace 0.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate stackdump-trace 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate stackdump-trace 0.4.0 [INFO] finished tweaking crates.io crate stackdump-trace 0.4.0 [INFO] tweaked toml for crates.io crate stackdump-trace 0.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 73 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.21.0 (latest: v0.24.1) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding gimli v0.28.1 (latest: v0.31.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding memmap2 v0.5.10 (latest: v0.9.4) [INFO] [stderr] Adding object v0.32.2 (latest: v0.36.4) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding ruzstd v0.5.0 (latest: v0.7.1) [INFO] [stderr] Adding simple_logger v4.3.3 (latest: v5.0.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding strum v0.25.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.25.3 (latest: v0.26.4) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c867a8558869063ecffeecbbb1829408631dd66fdf252524ff4ce2f82bb8ee5 [INFO] running `Command { std: "docker" "start" "-a" "4c867a8558869063ecffeecbbb1829408631dd66fdf252524ff4ce2f82bb8ee5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c867a8558869063ecffeecbbb1829408631dd66fdf252524ff4ce2f82bb8ee5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c867a8558869063ecffeecbbb1829408631dd66fdf252524ff4ce2f82bb8ee5", kill_on_drop: false }` [INFO] [stdout] 4c867a8558869063ecffeecbbb1829408631dd66fdf252524ff4ce2f82bb8ee5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 576619470a06d03f1aaff29d5c1650474ff3a21e5731f5cac19d2a43222ca7f3 [INFO] running `Command { std: "docker" "start" "-a" "576619470a06d03f1aaff29d5c1650474ff3a21e5731f5cac19d2a43222ca7f3", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling cpp_demangle v0.4.4 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking trees v0.4.2 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking simple_logger v4.3.3 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ruzstd v0.5.0 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking stackdump-core v0.4.0 [INFO] [stderr] Checking stackdump-trace v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `required_u8_value`, `required_u16_value`, `required_offset_value`, `required_exprloc_value`, `required_string_value`, and `required_string_value_sup` are never used [INFO] [stdout] --> src/gimli_extensions.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub trait AttributeExt { [INFO] [stdout] | ------------ methods in this trait [INFO] [stdout] 66 | fn required_u8_value(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 67 | fn required_u16_value(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | fn required_offset_value(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 71 | fn required_exprloc_value(&self) -> Result, TraceError>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 72 | fn required_string_value(&self, debug_str: &DebugStr) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 73 | fn required_string_value_sup( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:88:23 [INFO] [stdout] | [INFO] [stdout] 87 | fn from(e: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Self::IOError(Rc::new(e)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:86:68 [INFO] [stdout] | [INFO] [stdout] 86 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:95:68 [INFO] [stdout] | [INFO] [stdout] 95 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:104:68 [INFO] [stdout] | [INFO] [stdout] 104 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:113:68 [INFO] [stdout] | [INFO] [stdout] 113 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:122:68 [INFO] [stdout] | [INFO] [stdout] 122 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:131:68 [INFO] [stdout] | [INFO] [stdout] 131 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:140:68 [INFO] [stdout] | [INFO] [stdout] 140 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:153:68 [INFO] [stdout] | [INFO] [stdout] 153 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/cortex_m/mod.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 196 | let unwind_context = UnwindContext::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | [INFO] [stdout] 198 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 199 | | debug_frame, [INFO] [stdout] 200 | | reset_vector_address_range, [INFO] [stdout] 201 | | text_address_range, [INFO] [stdout] 202 | | bases, [INFO] [stdout] 203 | | unwind_context, [INFO] [stdout] 204 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/type_value_tree/rendering.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 71 | .find(|variant| variant.data().variable_value.as_ref() == Ok(discriminant_value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:100:60 [INFO] [stdout] | [INFO] [stdout] 100 | .map_err(|e| GetEntryTreeError::TraceError(e.into()))?) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:106:64 [INFO] [stdout] | [INFO] [stdout] 106 | .map_err(|e| GetEntryTreeError::TraceError(e.into())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:153:60 [INFO] [stdout] | [INFO] [stdout] 153 | .map_err(|e| GetEntryTreeError::TraceError(e.into()))?) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:159:64 [INFO] [stdout] | [INFO] [stdout] 159 | .map_err(|e| GetEntryTreeError::TraceError(e.into())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:276:8 [INFO] [stdout] | [INFO] [stdout] 270 | let frame_base_data = get_variable_data( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | Ok(frame_base_data.ok().map(|data| data.load_le())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:662:26 [INFO] [stdout] | [INFO] [stdout] 662 | ... .map(|r| r.to_ne_bytes().view_bits().to_bitvec()) // TODO: Is this correct? Shouldn't this be the endianness of the target device? [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:858:33 [INFO] [stdout] | [INFO] [stdout] 858 | .find(|variant| variant.data().variable_value.as_ref() == Ok(&discriminator_value)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:865:33 [INFO] [stdout] | [INFO] [stdout] 865 | .find(|variant| variant.data().variable_value.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:896:34 [INFO] [stdout] | [INFO] [stdout] 896 | .map(|node| &node.data().variable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:901:34 [INFO] [stdout] | [INFO] [stdout] 901 | .map(|node| &node.data().variable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `required_u8_value`, `required_u16_value`, `required_offset_value`, `required_exprloc_value`, `required_string_value`, and `required_string_value_sup` are never used [INFO] [stdout] --> src/gimli_extensions.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub trait AttributeExt { [INFO] [stdout] | ------------ methods in this trait [INFO] [stdout] 66 | fn required_u8_value(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 67 | fn required_u16_value(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | fn required_offset_value(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 71 | fn required_exprloc_value(&self) -> Result, TraceError>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 72 | fn required_string_value(&self, debug_str: &DebugStr) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 73 | fn required_string_value_sup( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:1149:11 [INFO] [stdout] | [INFO] [stdout] 222 | value => value, [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | value => value, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1078 | abstract_origin_tree = (dwarf, unit, abbreviations, entry) [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1088 | let variable_name = get_entry_name(dwarf, unit, entry); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1091 | let mut variable_name = match (variable_name, abstract_origin_entry) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1092 | (Err(_), Some(entry)) => get_entry_name(dwarf, unit, entry), [INFO] [stdout] 1093 | (variable_name, _) => variable_name, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1103 | variable_type_tree = (dwarf, unit, abbreviations, entry) [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1107 | abstract_origin_tree = (dwarf, unit, abbreviations, entry) [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1110 | let variable_type_value_tree = (|| match (variable_type_tree, abstract_origin_tree) { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1149 | match (variable_name, variable_type_value_tree) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:1110:46 [INFO] [stdout] | [INFO] [stdout] 1103 | variable_type_tree = (dwarf, unit, abbreviations, entry) [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1107 | abstract_origin_tree = (dwarf, unit, abbreviations, entry) [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1110 | let variable_type_value_tree = (|| match (variable_type_tree, abstract_origin_tree) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:88:23 [INFO] [stdout] | [INFO] [stdout] 87 | fn from(e: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Self::IOError(Rc::new(e)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:86:68 [INFO] [stdout] | [INFO] [stdout] 86 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:95:68 [INFO] [stdout] | [INFO] [stdout] 95 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:104:68 [INFO] [stdout] | [INFO] [stdout] 104 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:113:68 [INFO] [stdout] | [INFO] [stdout] 113 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:122:68 [INFO] [stdout] | [INFO] [stdout] 122 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:131:68 [INFO] [stdout] | [INFO] [stdout] 131 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:140:68 [INFO] [stdout] | [INFO] [stdout] 140 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gimli_extensions.rs:153:68 [INFO] [stdout] | [INFO] [stdout] 153 | expected_type_name: get_attribute_value_type_name(&self.value()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/cortex_m/mod.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 196 | let unwind_context = UnwindContext::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | [INFO] [stdout] 198 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 199 | | debug_frame, [INFO] [stdout] 200 | | reset_vector_address_range, [INFO] [stdout] 201 | | text_address_range, [INFO] [stdout] 202 | | bases, [INFO] [stdout] 203 | | unwind_context, [INFO] [stdout] 204 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/type_value_tree/rendering.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 71 | .find(|variant| variant.data().variable_value.as_ref() == Ok(discriminant_value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:100:60 [INFO] [stdout] | [INFO] [stdout] 100 | .map_err(|e| GetEntryTreeError::TraceError(e.into()))?) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:106:64 [INFO] [stdout] | [INFO] [stdout] 106 | .map_err(|e| GetEntryTreeError::TraceError(e.into())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:153:60 [INFO] [stdout] | [INFO] [stdout] 153 | .map_err(|e| GetEntryTreeError::TraceError(e.into()))?) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:159:64 [INFO] [stdout] | [INFO] [stdout] 159 | .map_err(|e| GetEntryTreeError::TraceError(e.into())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:276:8 [INFO] [stdout] | [INFO] [stdout] 270 | let frame_base_data = get_variable_data( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | Ok(frame_base_data.ok().map(|data| data.load_le())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:662:26 [INFO] [stdout] | [INFO] [stdout] 662 | ... .map(|r| r.to_ne_bytes().view_bits().to_bitvec()) // TODO: Is this correct? Shouldn't this be the endianness of the target device? [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:858:33 [INFO] [stdout] | [INFO] [stdout] 858 | .find(|variant| variant.data().variable_value.as_ref() == Ok(&discriminator_value)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:865:33 [INFO] [stdout] | [INFO] [stdout] 865 | .find(|variant| variant.data().variable_value.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:896:34 [INFO] [stdout] | [INFO] [stdout] 896 | .map(|node| &node.data().variable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:901:34 [INFO] [stdout] | [INFO] [stdout] 901 | .map(|node| &node.data().variable_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:1149:11 [INFO] [stdout] | [INFO] [stdout] 222 | value => value, [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | value => value, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1078 | abstract_origin_tree = (dwarf, unit, abbreviations, entry) [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1088 | let variable_name = get_entry_name(dwarf, unit, entry); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1091 | let mut variable_name = match (variable_name, abstract_origin_entry) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1092 | (Err(_), Some(entry)) => get_entry_name(dwarf, unit, entry), [INFO] [stdout] 1093 | (variable_name, _) => variable_name, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1103 | variable_type_tree = (dwarf, unit, abbreviations, entry) [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1107 | abstract_origin_tree = (dwarf, unit, abbreviations, entry) [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1110 | let variable_type_value_tree = (|| match (variable_type_tree, abstract_origin_tree) { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1149 | match (variable_name, variable_type_value_tree) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variables/mod.rs:1110:46 [INFO] [stdout] | [INFO] [stdout] 1103 | variable_type_tree = (dwarf, unit, abbreviations, entry) [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1107 | abstract_origin_tree = (dwarf, unit, abbreviations, entry) [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1110 | let variable_type_value_tree = (|| match (variable_type_tree, abstract_origin_tree) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stackdump-trace` (lib test) due to 24 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `stackdump-trace` (lib) due to 24 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "576619470a06d03f1aaff29d5c1650474ff3a21e5731f5cac19d2a43222ca7f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "576619470a06d03f1aaff29d5c1650474ff3a21e5731f5cac19d2a43222ca7f3", kill_on_drop: false }` [INFO] [stdout] 576619470a06d03f1aaff29d5c1650474ff3a21e5731f5cac19d2a43222ca7f3