[INFO] fetching crate stackalloc 1.2.1... [INFO] checking stackalloc-1.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate stackalloc 1.2.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate stackalloc 1.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate stackalloc 1.2.1 [INFO] finished tweaking crates.io crate stackalloc 1.2.1 [INFO] tweaked toml for crates.io crate stackalloc 1.2.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d1fbbe3264bf4f866b37cb907423e00cffafcdde04063af1ff47341f5ff6f176 [INFO] running `Command { std: "docker" "start" "-a" "d1fbbe3264bf4f866b37cb907423e00cffafcdde04063af1ff47341f5ff6f176", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d1fbbe3264bf4f866b37cb907423e00cffafcdde04063af1ff47341f5ff6f176", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1fbbe3264bf4f866b37cb907423e00cffafcdde04063af1ff47341f5ff6f176", kill_on_drop: false }` [INFO] [stdout] d1fbbe3264bf4f866b37cb907423e00cffafcdde04063af1ff47341f5ff6f176 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7677eb4b0b70cd12c9362bc7c51e51c4861f4e8a56b3f6cbe78fb9d6649491d5 [INFO] running `Command { std: "docker" "start" "-a" "7677eb4b0b70cd12c9362bc7c51e51c4861f4e8a56b3f6cbe78fb9d6649491d5", kill_on_drop: false }` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling stackalloc v1.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:304:18 [INFO] [stdout] | [INFO] [stdout] 301 | #[inline] pub fn alloca_zeroed(size: usize, callback: F) -> T [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | alloca(size, move |buf| { [INFO] [stdout] | __________________^ [INFO] [stdout] 305 | | // SAFETY: We zero-initialise the backing slice [INFO] [stdout] 306 | | callback(unsafe { [INFO] [stdout] 307 | | ptr::write_bytes(buf.as_mut_ptr(), 0, buf.len()); // buf.fill(MaybeUninit::zeroed()); [INFO] [stdout] 308 | | slice_assume_init_mut(buf) [INFO] [stdout] 309 | | }) [INFO] [stdout] 310 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:323:24 [INFO] [stdout] | [INFO] [stdout] 319 | #[inline] pub fn stackalloc_uninit(size: usize, callback: F) -> U [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | alloca(size_bytes, move |buf| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 324 | | let abuf = align_buffer_to::>(buf.as_mut_ptr() as *mut u8); [INFO] [stdout] 325 | | debug_assert!(buf.as_ptr_range().contains(&(abuf as *const _ as *const MaybeUninit))); [INFO] [stdout] 326 | | unsafe { [INFO] [stdout] 327 | | callback(slice::from_raw_parts_mut(abuf, size)) [INFO] [stdout] 328 | | } [INFO] [stdout] 329 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:341:29 [INFO] [stdout] | [INFO] [stdout] 337 | #[inline] pub fn stackalloc_with(size: usize, mut init_with: I, callback: F) -> U [INFO] [stdout] | ---------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | stackalloc_uninit(size, move |buf| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 342 | | buf.fill_with(move || MaybeUninit::new(init_with())); [INFO] [stdout] 343 | | // SAFETY: We have initialised the buffer above [INFO] [stdout] 344 | | let buf = unsafe { slice_assume_init_mut(buf) }; [INFO] [stdout] ... | [INFO] [stdout] 353 | | ret [INFO] [stdout] 354 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:342:41 [INFO] [stdout] | [INFO] [stdout] 337 | #[inline] pub fn stackalloc_with(size: usize, mut init_with: I, callback: F) -> U [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | buf.fill_with(move || MaybeUninit::new(init_with())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:366:27 [INFO] [stdout] | [INFO] [stdout] 362 | #[inline] pub fn stackalloc(size: usize, init: T, callback: F) -> U [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | stackalloc_with(size, move || init.clone(), callback) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:394:29 [INFO] [stdout] | [INFO] [stdout] 390 | #[inline] pub fn stackalloc_with_iter(size: usize, iter: I, callback: F) -> U [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 394 | stackalloc_uninit(size, move |buf| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 395 | | let mut done = 0; [INFO] [stdout] 396 | | for (d, s) in buf.iter_mut().zip(iter.into_iter()) [INFO] [stdout] 397 | | { [INFO] [stdout] ... | [INFO] [stdout] 413 | | ret [INFO] [stdout] 414 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stackalloc` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:304:18 [INFO] [stdout] | [INFO] [stdout] 301 | #[inline] pub fn alloca_zeroed(size: usize, callback: F) -> T [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | alloca(size, move |buf| { [INFO] [stdout] | __________________^ [INFO] [stdout] 305 | | // SAFETY: We zero-initialise the backing slice [INFO] [stdout] 306 | | callback(unsafe { [INFO] [stdout] 307 | | ptr::write_bytes(buf.as_mut_ptr(), 0, buf.len()); // buf.fill(MaybeUninit::zeroed()); [INFO] [stdout] 308 | | slice_assume_init_mut(buf) [INFO] [stdout] 309 | | }) [INFO] [stdout] 310 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:323:24 [INFO] [stdout] | [INFO] [stdout] 319 | #[inline] pub fn stackalloc_uninit(size: usize, callback: F) -> U [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | alloca(size_bytes, move |buf| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 324 | | let abuf = align_buffer_to::>(buf.as_mut_ptr() as *mut u8); [INFO] [stdout] 325 | | debug_assert!(buf.as_ptr_range().contains(&(abuf as *const _ as *const MaybeUninit))); [INFO] [stdout] 326 | | unsafe { [INFO] [stdout] 327 | | callback(slice::from_raw_parts_mut(abuf, size)) [INFO] [stdout] 328 | | } [INFO] [stdout] 329 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:341:29 [INFO] [stdout] | [INFO] [stdout] 337 | #[inline] pub fn stackalloc_with(size: usize, mut init_with: I, callback: F) -> U [INFO] [stdout] | ---------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | stackalloc_uninit(size, move |buf| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 342 | | buf.fill_with(move || MaybeUninit::new(init_with())); [INFO] [stdout] 343 | | // SAFETY: We have initialised the buffer above [INFO] [stdout] 344 | | let buf = unsafe { slice_assume_init_mut(buf) }; [INFO] [stdout] ... | [INFO] [stdout] 353 | | ret [INFO] [stdout] 354 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:342:41 [INFO] [stdout] | [INFO] [stdout] 337 | #[inline] pub fn stackalloc_with(size: usize, mut init_with: I, callback: F) -> U [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | buf.fill_with(move || MaybeUninit::new(init_with())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:366:27 [INFO] [stdout] | [INFO] [stdout] 362 | #[inline] pub fn stackalloc(size: usize, init: T, callback: F) -> U [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | stackalloc_with(size, move || init.clone(), callback) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:394:29 [INFO] [stdout] | [INFO] [stdout] 390 | #[inline] pub fn stackalloc_with_iter(size: usize, iter: I, callback: F) -> U [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 394 | stackalloc_uninit(size, move |buf| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 395 | | let mut done = 0; [INFO] [stdout] 396 | | for (d, s) in buf.iter_mut().zip(iter.into_iter()) [INFO] [stdout] 397 | | { [INFO] [stdout] ... | [INFO] [stdout] 413 | | ret [INFO] [stdout] 414 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stackalloc` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "7677eb4b0b70cd12c9362bc7c51e51c4861f4e8a56b3f6cbe78fb9d6649491d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7677eb4b0b70cd12c9362bc7c51e51c4861f4e8a56b3f6cbe78fb9d6649491d5", kill_on_drop: false }` [INFO] [stdout] 7677eb4b0b70cd12c9362bc7c51e51c4861f4e8a56b3f6cbe78fb9d6649491d5