[INFO] fetching crate stack_dst 0.8.1... [INFO] checking stack_dst-0.8.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate stack_dst 0.8.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate stack_dst 0.8.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate stack_dst 0.8.1 [INFO] finished tweaking crates.io crate stack_dst 0.8.1 [INFO] tweaked toml for crates.io crate stack_dst 0.8.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 993c5f7e742318d4a07a189ce915fc2bc6d7483e304eeb8762eccd7656aca34a [INFO] running `Command { std: "docker" "start" "-a" "993c5f7e742318d4a07a189ce915fc2bc6d7483e304eeb8762eccd7656aca34a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "993c5f7e742318d4a07a189ce915fc2bc6d7483e304eeb8762eccd7656aca34a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "993c5f7e742318d4a07a189ce915fc2bc6d7483e304eeb8762eccd7656aca34a", kill_on_drop: false }` [INFO] [stdout] 993c5f7e742318d4a07a189ce915fc2bc6d7483e304eeb8762eccd7656aca34a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9b24f005c04f371dadc0b96683e5ac9d9d37e70e17f5498899ab28e000afbe95 [INFO] running `Command { std: "docker" "start" "-a" "9b24f005c04f371dadc0b96683e5ac9d9d37e70e17f5498899ab28e000afbe95", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking stack_dst v0.8.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `full_const_generics` [INFO] [stdout] --> src/lib.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | feature = "full_const_generics", [INFO] [stdout] | ^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"const_generics"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `const_generics`, `default`, and `unsize` [INFO] [stdout] = help: consider adding `full_const_generics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `full_const_generics` [INFO] [stdout] --> src/lib.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | feature = "full_const_generics", [INFO] [stdout] | ^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"const_generics"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `const_generics`, `default`, and `unsize` [INFO] [stdout] = help: consider adding `full_const_generics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `full_const_generics` [INFO] [stdout] --> src/lib.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | #![cfg_attr(feature = "full_const_generics", allow(incomplete_features))] [INFO] [stdout] | ^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"const_generics"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `const_generics`, `default`, and `unsize` [INFO] [stdout] = help: consider adding `full_const_generics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `full_const_generics` [INFO] [stdout] --> src/lib.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | #![cfg_attr(feature = "full_const_generics", allow(incomplete_features))] [INFO] [stdout] | ^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"const_generics"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `const_generics`, `default`, and `unsize` [INFO] [stdout] = help: consider adding `full_const_generics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `full_const_generics` [INFO] [stdout] --> src/lib.rs:384:7 [INFO] [stdout] | [INFO] [stdout] 384 | #[cfg(feature = "full_const_generics")] [INFO] [stdout] | ^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"const_generics"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `const_generics`, `default`, and `unsize` [INFO] [stdout] = help: consider adding `full_const_generics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `full_const_generics` [INFO] [stdout] --> src/lib.rs:391:11 [INFO] [stdout] | [INFO] [stdout] 391 | #[cfg(not(feature = "full_const_generics"))] [INFO] [stdout] | ^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"const_generics"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `const_generics`, `default`, and `unsize` [INFO] [stdout] = help: consider adding `full_const_generics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `full_const_generics` [INFO] [stdout] --> src/lib.rs:384:7 [INFO] [stdout] | [INFO] [stdout] 384 | #[cfg(feature = "full_const_generics")] [INFO] [stdout] | ^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"const_generics"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `const_generics`, `default`, and `unsize` [INFO] [stdout] = help: consider adding `full_const_generics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `full_const_generics` [INFO] [stdout] --> src/lib.rs:391:11 [INFO] [stdout] | [INFO] [stdout] 391 | #[cfg(not(feature = "full_const_generics"))] [INFO] [stdout] | ^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"const_generics"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `const_generics`, `default`, and `unsize` [INFO] [stdout] = help: consider adding `full_const_generics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fifo.rs:380:70 [INFO] [stdout] | [INFO] [stdout] 380 | crate::list_push_gen(pii.meta, pii.data, iter.len(), |_| iter.next().unwrap(), pii.reset_slot, pii.reset_value); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:325:70 [INFO] [stdout] | [INFO] [stdout] 325 | crate::list_push_gen(pii.meta, pii.data, iter.len(), |_| iter.next().unwrap(), pii.reset_slot, pii.reset_value); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:81:32 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new_stable &T>(val: U, get_ref: F) -> Result, U> [INFO] [stdout] | ------ ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Self::in_buffer_stable(D::default(), val, get_ref) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:172:14 [INFO] [stdout] | [INFO] [stdout] 159 | mut buffer: D, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Some(mem::ManuallyDrop::into_inner(rv)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:447:15 [INFO] [stdout] | [INFO] [stdout] 446 | pub fn appended(mut self, v: I) -> Result { [INFO] [stdout] | -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 447 | match self.append(v) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:469:15 [INFO] [stdout] | [INFO] [stdout] 468 | pub fn extended>(mut self, iter: It) -> Result { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 469 | match self.extend(iter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fifo.rs:380:70 [INFO] [stdout] | [INFO] [stdout] 380 | crate::list_push_gen(pii.meta, pii.data, iter.len(), |_| iter.next().unwrap(), pii.reset_slot, pii.reset_value); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:325:70 [INFO] [stdout] | [INFO] [stdout] 325 | crate::list_push_gen(pii.meta, pii.data, iter.len(), |_| iter.next().unwrap(), pii.reset_slot, pii.reset_value); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:81:32 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new_stable &T>(val: U, get_ref: F) -> Result, U> [INFO] [stdout] | ------ ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Self::in_buffer_stable(D::default(), val, get_ref) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:172:14 [INFO] [stdout] | [INFO] [stdout] 159 | mut buffer: D, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Some(mem::ManuallyDrop::into_inner(rv)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:447:15 [INFO] [stdout] | [INFO] [stdout] 446 | pub fn appended(mut self, v: I) -> Result { [INFO] [stdout] | -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 447 | match self.append(v) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:469:15 [INFO] [stdout] | [INFO] [stdout] 468 | pub fn extended>(mut self, iter: It) -> Result { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 469 | match self.extend(iter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stack_dst` (lib test) due to 7 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `stack_dst` (lib) due to 7 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9b24f005c04f371dadc0b96683e5ac9d9d37e70e17f5498899ab28e000afbe95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b24f005c04f371dadc0b96683e5ac9d9d37e70e17f5498899ab28e000afbe95", kill_on_drop: false }` [INFO] [stdout] 9b24f005c04f371dadc0b96683e5ac9d9d37e70e17f5498899ab28e000afbe95