[INFO] fetching crate stac-server 0.1.1... [INFO] checking stac-server-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate stac-server 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate stac-server 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate stac-server 0.1.1 [INFO] finished tweaking crates.io crate stac-server 0.1.1 [INFO] tweaked toml for crates.io crate stac-server 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 263 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding fallible-iterator v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding matchit v0.7.3 (latest: v0.8.4) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding sync_wrapper v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 795eda072d44fabbf7f4d364c43679160845d9d05b917d8c97de01b44879d2ec [INFO] running `Command { std: "docker" "start" "-a" "795eda072d44fabbf7f4d364c43679160845d9d05b917d8c97de01b44879d2ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "795eda072d44fabbf7f4d364c43679160845d9d05b917d8c97de01b44879d2ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "795eda072d44fabbf7f4d364c43679160845d9d05b917d8c97de01b44879d2ec", kill_on_drop: false }` [INFO] [stdout] 795eda072d44fabbf7f4d364c43679160845d9d05b917d8c97de01b44879d2ec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a1acf4bec82b6f11f680ebcac32ca2da3932e8e490b52311252afb623bd5408b [INFO] running `Command { std: "docker" "start" "-a" "a1acf4bec82b6f11f680ebcac32ca2da3932e8e490b52311252afb623bd5408b", kill_on_drop: false }` [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking robust v1.1.0 [INFO] [stderr] Checking geographiclib-rs v0.2.4 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling stac v0.8.0 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking float_next_after v1.0.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking rstar v0.12.0 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking fraction v0.15.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking num-cmp v0.1.0 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking earcutr v0.4.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking iso8601 v0.6.1 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking geo-types v0.7.13 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking spade v2.12.0 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking geo v0.28.0 [INFO] [stderr] Checking geojson v0.24.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking stac-api v0.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking jsonschema v0.18.1 [INFO] [stderr] Checking stac-async v0.5.2 [INFO] [stderr] Checking stac-validate v0.2.0 [INFO] [stderr] Checking stac-server v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new(backend: B, root: &str) -> Result> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(Api { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | backend, [INFO] [stdout] 39 | | id: DEFAULT_ID.to_string(), [INFO] [stdout] 40 | | description: DEFAULT_DESCRIPTION.to_string(), [INFO] [stdout] 41 | | root: root.parse()?, [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:53:78 [INFO] [stdout] | [INFO] [stdout] 53 | async fn add_collection(&mut self, collection: Collection) -> Result<()> { [INFO] [stdout] | ________________________________________----------------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | | let mut collections = self.collections.write().unwrap(); [INFO] [stdout] 55 | | let _ = collections.insert(collection.id.clone(), collection); [INFO] [stdout] 56 | | Ok(()) [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:59:60 [INFO] [stdout] | [INFO] [stdout] 59 | async fn add_item(&mut self, item: Item) -> Result<()> { [INFO] [stdout] | __________________________________----------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | | if let Some(collection_id) = item.collection.clone() { [INFO] [stdout] 61 | | if self.collection(&collection_id).await?.is_none() { [INFO] [stdout] 62 | | Err(Error::MemoryBackend(format!( [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:79:96 [INFO] [stdout] | [INFO] [stdout] 79 | async fn items(&self, collection_id: &str, items: Items) -> Result> { [INFO] [stdout] | ________________________________________________------------____________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | | { [INFO] [stdout] 81 | | let collections = self.collections.read().unwrap(); [INFO] [stdout] 82 | | if !collections.contains_key(collection_id) { [INFO] [stdout] ... | [INFO] [stdout] 87 | | self.search(search).await.map(Some) [INFO] [stdout] 88 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:97:74 [INFO] [stdout] | [INFO] [stdout] 97 | async fn search(&self, mut search: Search) -> Result { [INFO] [stdout] | ________________________________--------------____________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | | let items = self.items.read().unwrap(); [INFO] [stdout] 99 | | if search.collections.is_none() { [INFO] [stdout] 100 | | search.collections = Some(items.keys().cloned().collect()); [INFO] [stdout] ... | [INFO] [stdout] 139 | | Ok(item_collection) [INFO] [stdout] 140 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:108:40 [INFO] [stdout] | [INFO] [stdout] 108 | .filter(|item| search.matches(item).unwrap_or_default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:125:25 [INFO] [stdout] | [INFO] [stdout] 125 | .map(|item| stac_api::Item::try_from(item.clone()).map_err(Error::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_api(api: Api) -> Router { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | / Router::new() [INFO] [stdout] 26 | | .route("/", get(root)) [INFO] [stdout] 27 | | .route("/api", get(service_desc)) [INFO] [stdout] 28 | | .route("/api.html", get(service_doc)) [INFO] [stdout] ... | [INFO] [stdout] 34 | | .route("/search", get(get_search)) [INFO] [stdout] 35 | | .route("/search", post(post_search)) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes.rs:196:28 [INFO] [stdout] | [INFO] [stdout] 196 | .and_then(|search| search.0.valid().map_err(|err| err.to_string())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stac-server` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new(backend: B, root: &str) -> Result> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(Api { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | backend, [INFO] [stdout] 39 | | id: DEFAULT_ID.to_string(), [INFO] [stdout] 40 | | description: DEFAULT_DESCRIPTION.to_string(), [INFO] [stdout] 41 | | root: root.parse()?, [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:404:9 [INFO] [stdout] | [INFO] [stdout] 403 | fn test_api(backend: MemoryBackend) -> Api { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 404 | / Api::new(backend, "http://stac.test/") [INFO] [stdout] 405 | | .unwrap() [INFO] [stdout] 406 | | .id("an-id") [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:53:78 [INFO] [stdout] | [INFO] [stdout] 53 | async fn add_collection(&mut self, collection: Collection) -> Result<()> { [INFO] [stdout] | ________________________________________----------------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | | let mut collections = self.collections.write().unwrap(); [INFO] [stdout] 55 | | let _ = collections.insert(collection.id.clone(), collection); [INFO] [stdout] 56 | | Ok(()) [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:59:60 [INFO] [stdout] | [INFO] [stdout] 59 | async fn add_item(&mut self, item: Item) -> Result<()> { [INFO] [stdout] | __________________________________----------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | | if let Some(collection_id) = item.collection.clone() { [INFO] [stdout] 61 | | if self.collection(&collection_id).await?.is_none() { [INFO] [stdout] 62 | | Err(Error::MemoryBackend(format!( [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:79:96 [INFO] [stdout] | [INFO] [stdout] 79 | async fn items(&self, collection_id: &str, items: Items) -> Result> { [INFO] [stdout] | ________________________________________________------------____________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | | { [INFO] [stdout] 81 | | let collections = self.collections.read().unwrap(); [INFO] [stdout] 82 | | if !collections.contains_key(collection_id) { [INFO] [stdout] ... | [INFO] [stdout] 87 | | self.search(search).await.map(Some) [INFO] [stdout] 88 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:97:74 [INFO] [stdout] | [INFO] [stdout] 97 | async fn search(&self, mut search: Search) -> Result { [INFO] [stdout] | ________________________________--------------____________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | | let items = self.items.read().unwrap(); [INFO] [stdout] 99 | | if search.collections.is_none() { [INFO] [stdout] 100 | | search.collections = Some(items.keys().cloned().collect()); [INFO] [stdout] ... | [INFO] [stdout] 139 | | Ok(item_collection) [INFO] [stdout] 140 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:108:40 [INFO] [stdout] | [INFO] [stdout] 108 | .filter(|item| search.matches(item).unwrap_or_default()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/memory.rs:125:25 [INFO] [stdout] | [INFO] [stdout] 125 | .map(|item| stac_api::Item::try_from(item.clone()).map_err(Error::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_api(api: Api) -> Router { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | / Router::new() [INFO] [stdout] 26 | | .route("/", get(root)) [INFO] [stdout] 27 | | .route("/api", get(service_desc)) [INFO] [stdout] 28 | | .route("/api.html", get(service_doc)) [INFO] [stdout] ... | [INFO] [stdout] 34 | | .route("/search", get(get_search)) [INFO] [stdout] 35 | | .route("/search", post(post_search)) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes.rs:196:28 [INFO] [stdout] | [INFO] [stdout] 196 | .and_then(|search| search.0.valid().map_err(|err| err.to_string())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stac-server` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "a1acf4bec82b6f11f680ebcac32ca2da3932e8e490b52311252afb623bd5408b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1acf4bec82b6f11f680ebcac32ca2da3932e8e490b52311252afb623bd5408b", kill_on_drop: false }` [INFO] [stdout] a1acf4bec82b6f11f680ebcac32ca2da3932e8e490b52311252afb623bd5408b