[INFO] fetching crate ssloc 0.4.2... [INFO] checking ssloc-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ssloc 0.4.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ssloc 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ssloc 0.4.2 [INFO] finished tweaking crates.io crate ssloc 0.4.2 [INFO] tweaked toml for crates.io crate ssloc 0.4.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate ssloc 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b66cf14e31a64182bdf7a0dc196498d2b40799aa7e8083cb4137a9b6b3edb15d [INFO] running `Command { std: "docker" "start" "-a" "b66cf14e31a64182bdf7a0dc196498d2b40799aa7e8083cb4137a9b6b3edb15d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b66cf14e31a64182bdf7a0dc196498d2b40799aa7e8083cb4137a9b6b3edb15d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b66cf14e31a64182bdf7a0dc196498d2b40799aa7e8083cb4137a9b6b3edb15d", kill_on_drop: false }` [INFO] [stdout] b66cf14e31a64182bdf7a0dc196498d2b40799aa7e8083cb4137a9b6b3edb15d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c00f5cfc115216aaac66d65f8800b39929dfd822d3f6ea1e5b57538da506b1a3 [INFO] running `Command { std: "docker" "start" "-a" "c00f5cfc115216aaac66d65f8800b39929dfd822d3f6ea1e5b57538da506b1a3", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling matrixmultiply v0.3.7 [INFO] [stderr] Compiling paste v1.0.12 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Compiling smallvec v1.10.0 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling rustfft v6.1.0 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking safe_arch v0.7.0 [INFO] [stderr] Checking wide v0.7.10 [INFO] [stderr] Compiling proc-macro-utils v0.8.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Compiling manyhow-macros v0.4.2 [INFO] [stderr] Checking num-complex v0.4.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling manyhow v0.4.2 [INFO] [stderr] Checking primal-check v0.3.3 [INFO] [stderr] Checking transpose v0.2.2 [INFO] [stderr] Compiling forr v0.1.1 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Compiling serde_derive v1.0.164 [INFO] [stderr] Compiling smart-default v0.7.1 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Compiling nalgebra-macros v0.2.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking realfft v3.3.0 [INFO] [stderr] Checking nalgebra v0.32.2 [INFO] [stderr] Checking ssloc v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mbss.rs:27:39 [INFO] [stdout] | [INFO] [stdout] 27 | #[derive(Clone, Copy, Debug, Default, Deserialize, Serialize, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mbss.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | #[derive(Clone, Copy, Default, Debug, Deserialize, Serialize, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mbss.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 265 | let x_ft; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | let spec_inst = match self.spectrum_method { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let spec = match self.pooling { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | spec.into_shape((self.n_elevations(), self.n_azimuth())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sss.rs:77:63 [INFO] [stdout] | [INFO] [stdout] 31 | direction: impl Into, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let sub_sample: Box Option> = match self.filter { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | (self.filter.unwrap_or_default() / 2 + 1..).map_while(move |i| { [INFO] [stdout] | _______________________________________________________________^ [INFO] [stdout] 78 | | mics.iter() [INFO] [stdout] 79 | | .enumerate() [INFO] [stdout] 80 | | .map(|(mic, tau)| { [INFO] [stdout] ... | [INFO] [stdout] 84 | | .fold_options(0., F::add) [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn min<'a>(iter: impl IntoIterator) -> F { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | iter.into_iter().copied().reduce(F::min).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn max<'a>(iter: impl IntoIterator) -> F { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | iter.into_iter().copied().reduce(F::max).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:106:19 [INFO] [stdout] | [INFO] [stdout] 101 | data: impl IntoIterator>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | data: Array2::from_shape_fn((channels, data.len() / channels), |(c, s)| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 107 | | data[c + s * channels] [INFO] [stdout] 108 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:141:23 [INFO] [stdout] | [INFO] [stdout] 141 | .map(|&d| T::from_f64(d).expect("audio format can be converted")) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mbss.rs:27:39 [INFO] [stdout] | [INFO] [stdout] 27 | #[derive(Clone, Copy, Debug, Default, Deserialize, Serialize, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mbss.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | #[derive(Clone, Copy, Default, Debug, Deserialize, Serialize, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mbss.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 265 | let x_ft; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | let spec_inst = match self.spectrum_method { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let spec = match self.pooling { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | spec.into_shape((self.n_elevations(), self.n_azimuth())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sss.rs:77:63 [INFO] [stdout] | [INFO] [stdout] 31 | direction: impl Into, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let sub_sample: Box Option> = match self.filter { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | (self.filter.unwrap_or_default() / 2 + 1..).map_while(move |i| { [INFO] [stdout] | _______________________________________________________________^ [INFO] [stdout] 78 | | mics.iter() [INFO] [stdout] 79 | | .enumerate() [INFO] [stdout] 80 | | .map(|(mic, tau)| { [INFO] [stdout] ... | [INFO] [stdout] 84 | | .fold_options(0., F::add) [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn min<'a>(iter: impl IntoIterator) -> F { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | iter.into_iter().copied().reduce(F::min).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn max<'a>(iter: impl IntoIterator) -> F { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | iter.into_iter().copied().reduce(F::max).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:106:19 [INFO] [stdout] | [INFO] [stdout] 101 | data: impl IntoIterator>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | data: Array2::from_shape_fn((channels, data.len() / channels), |(c, s)| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 107 | | data[c + s * channels] [INFO] [stdout] 108 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:141:23 [INFO] [stdout] | [INFO] [stdout] 141 | .map(|&d| T::from_f64(d).expect("audio format can be converted")) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssloc` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ssloc` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "c00f5cfc115216aaac66d65f8800b39929dfd822d3f6ea1e5b57538da506b1a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c00f5cfc115216aaac66d65f8800b39929dfd822d3f6ea1e5b57538da506b1a3", kill_on_drop: false }` [INFO] [stdout] c00f5cfc115216aaac66d65f8800b39929dfd822d3f6ea1e5b57538da506b1a3