[INFO] fetching crate sshd-openpgp-auth 0.3.0... [INFO] checking sshd-openpgp-auth-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sshd-openpgp-auth 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate sshd-openpgp-auth 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sshd-openpgp-auth 0.3.0 [INFO] finished tweaking crates.io crate sshd-openpgp-auth 0.3.0 [INFO] tweaked toml for crates.io crate sshd-openpgp-auth 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate sshd-openpgp-auth 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3481e33bf1f0f2f0fd04c53ba76eb696edee16789f35624d9c3c62486239f101 [INFO] running `Command { std: "docker" "start" "-a" "3481e33bf1f0f2f0fd04c53ba76eb696edee16789f35624d9c3c62486239f101", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3481e33bf1f0f2f0fd04c53ba76eb696edee16789f35624d9c3c62486239f101", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3481e33bf1f0f2f0fd04c53ba76eb696edee16789f35624d9c3c62486239f101", kill_on_drop: false }` [INFO] [stdout] 3481e33bf1f0f2f0fd04c53ba76eb696edee16789f35624d9c3c62486239f101 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff1dee70410452fd6931a443bb860d445e26b873ec4975ee1f90dd9b3e2f411e [INFO] running `Command { std: "docker" "start" "-a" "ff1dee70410452fd6931a443bb860d445e26b873ec4975ee1f90dd9b3e2f411e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling cc v1.0.88 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling clang-sys v1.7.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling bitflags v2.4.2 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling libloading v0.8.1 [INFO] [stderr] Compiling bindgen v0.68.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling smallvec v1.13.1 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking der v0.7.8 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling fastrand v2.0.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling parking_lot v0.12.1 [INFO] [stderr] Compiling indexmap v2.2.4 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling platforms v3.3.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling curve25519-dalek v4.1.2 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Compiling walkdir v2.4.0 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling petgraph v0.6.4 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Compiling ena v0.14.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Compiling lalrpop-util v0.20.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling sha1collisiondetection v0.3.3 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking generic-array v1.0.0 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking buffered-reader v1.3.0 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking dsa v0.6.3 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Checking memsec v0.6.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking xxhash-rust v0.8.10 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking chrono v0.4.34 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking fqdn v0.3.2 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling relative-path v1.9.2 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking sysinfo v0.26.9 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking whoami v1.4.1 [INFO] [stderr] Checking testresult v0.3.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling lalrpop v0.20.2 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling strum_macros v0.26.1 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking strum v0.26.1 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking ssh-key v0.6.4 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling nettle-sys v2.3.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking cargo-platform v0.1.7 [INFO] [stderr] Checking email_address v0.2.4 [INFO] [stderr] Compiling sequoia-openpgp v1.19.0 [INFO] [stderr] Checking cargo_metadata v0.14.2 [INFO] [stderr] Checking testdir v0.9.1 [INFO] [stderr] Checking nettle v7.3.0 [INFO] [stderr] Checking sshd-openpgp-auth v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:653:32 [INFO] [stdout] | [INFO] [stdout] 648 | .filter_map(|x| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 653 | .then_some(x.unwrap().path()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:693:8 [INFO] [stdout] | [INFO] [stdout] 690 | public_key: ssh_key::PublicKey, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 693 | Ok(match public_key.key_data() { [INFO] [stdout] | ________^ [INFO] [stdout] 694 | | KeyData::Rsa(pubkey) => { [INFO] [stdout] 695 | | Key4::import_public_rsa(pubkey.e.as_bytes(), pubkey.n.as_bytes(), creation_time)?.into() [INFO] [stdout] 696 | | } [INFO] [stdout] ... | [INFO] [stdout] 729 | | } [INFO] [stdout] 730 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:756:8 [INFO] [stdout] | [INFO] [stdout] 734 | pub fn add_dns_proof(cert: Cert) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 735 | let policy = StandardPolicy::new(); [INFO] [stdout] 736 | let mut signer = cert [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 746 | let sig = SignatureBuilder::from(template.clone()) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 756 | Ok(cert.insert_packets2(sig)?.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:802:8 [INFO] [stdout] | [INFO] [stdout] 761 | cert: Cert, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 762 | subkeys: Vec>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 763 | ) -> Result { [INFO] [stdout] 764 | let new_fingerprints = subkeys [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 768 | let current_fingerprints = cert [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 780 | let key = cert [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 788 | let mut signer = key.into_keypair()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 789 | [INFO] [stdout] 790 | let signature_builder = SignatureBuilder::new(SignatureType::SubkeyBinding) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 796 | let signatures: Vec = subkeys [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 800 | let packets: Vec = signatures.iter().map(|x| x.clone().into()).collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 801 | [INFO] [stdout] 802 | Ok(cert.insert_packets(packets)?.insert_packets(subkeys)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:798:25 [INFO] [stdout] | [INFO] [stdout] 798 | .filter_map(|x| x.bind(&mut signer, &cert, signature_builder.clone()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:800:58 [INFO] [stdout] | [INFO] [stdout] 800 | let packets: Vec = signatures.iter().map(|x| x.clone().into()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:884:8 [INFO] [stdout] | [INFO] [stdout] 814 | cert: Cert, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 815 | fingerprints: Vec, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 824 | let current_fingerprints = cert [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 830 | let non_matching = fingerprints [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 848 | let key = cert [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 860 | let mut signer = key.into_keypair()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 861 | [INFO] [stdout] 862 | let subkeys = cert [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 874 | let mut cert_packets = cert.as_tsk().into_packets().collect::>(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 884 | Ok(Cert::from_packets(cert_packets.into_iter())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:937:8 [INFO] [stdout] | [INFO] [stdout] 894 | cert: Cert, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 917 | let mut keypair = cert [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 924 | let signature = cert.set_expiration_time( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 937 | Ok(cert.insert_packets(signature)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1164:32 [INFO] [stdout] | [INFO] [stdout] 1164 | .filter_map(|tsk_file| Cert::from_file(tsk_file).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1195:8 [INFO] [stdout] | [INFO] [stdout] 1175 | pub fn merge_public_cert(tsk: Cert, cert: Cert) -> Result { [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1182 | let tsk_fingerprint = tsk.primary_key().fingerprint(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1193 | let cert_fingerprint = cert.primary_key().fingerprint(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1194 | [INFO] [stdout] 1195 | Ok(if cert_fingerprint == tsk_fingerprint { [INFO] [stdout] | ________^ [INFO] [stdout] 1196 | | if cert_userid == tsk_userid { [INFO] [stdout] 1197 | | tsk.merge_public(cert)? [INFO] [stdout] 1198 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 1208 | | }); [INFO] [stdout] 1209 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:653:32 [INFO] [stdout] | [INFO] [stdout] 648 | .filter_map(|x| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 653 | .then_some(x.unwrap().path()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:693:8 [INFO] [stdout] | [INFO] [stdout] 690 | public_key: ssh_key::PublicKey, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 693 | Ok(match public_key.key_data() { [INFO] [stdout] | ________^ [INFO] [stdout] 694 | | KeyData::Rsa(pubkey) => { [INFO] [stdout] 695 | | Key4::import_public_rsa(pubkey.e.as_bytes(), pubkey.n.as_bytes(), creation_time)?.into() [INFO] [stdout] 696 | | } [INFO] [stdout] ... | [INFO] [stdout] 729 | | } [INFO] [stdout] 730 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:756:8 [INFO] [stdout] | [INFO] [stdout] 734 | pub fn add_dns_proof(cert: Cert) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 735 | let policy = StandardPolicy::new(); [INFO] [stdout] 736 | let mut signer = cert [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 746 | let sig = SignatureBuilder::from(template.clone()) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 756 | Ok(cert.insert_packets2(sig)?.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:802:8 [INFO] [stdout] | [INFO] [stdout] 761 | cert: Cert, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 762 | subkeys: Vec>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 763 | ) -> Result { [INFO] [stdout] 764 | let new_fingerprints = subkeys [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 768 | let current_fingerprints = cert [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 780 | let key = cert [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 788 | let mut signer = key.into_keypair()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 789 | [INFO] [stdout] 790 | let signature_builder = SignatureBuilder::new(SignatureType::SubkeyBinding) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 796 | let signatures: Vec = subkeys [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 800 | let packets: Vec = signatures.iter().map(|x| x.clone().into()).collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 801 | [INFO] [stdout] 802 | Ok(cert.insert_packets(packets)?.insert_packets(subkeys)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:798:25 [INFO] [stdout] | [INFO] [stdout] 798 | .filter_map(|x| x.bind(&mut signer, &cert, signature_builder.clone()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:800:58 [INFO] [stdout] | [INFO] [stdout] 800 | let packets: Vec = signatures.iter().map(|x| x.clone().into()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:884:8 [INFO] [stdout] | [INFO] [stdout] 814 | cert: Cert, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 815 | fingerprints: Vec, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 824 | let current_fingerprints = cert [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 830 | let non_matching = fingerprints [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 848 | let key = cert [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 860 | let mut signer = key.into_keypair()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 861 | [INFO] [stdout] 862 | let subkeys = cert [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 874 | let mut cert_packets = cert.as_tsk().into_packets().collect::>(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 884 | Ok(Cert::from_packets(cert_packets.into_iter())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:937:8 [INFO] [stdout] | [INFO] [stdout] 894 | cert: Cert, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 917 | let mut keypair = cert [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 924 | let signature = cert.set_expiration_time( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 937 | Ok(cert.insert_packets(signature)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1164:32 [INFO] [stdout] | [INFO] [stdout] 1164 | .filter_map(|tsk_file| Cert::from_file(tsk_file).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1195:8 [INFO] [stdout] | [INFO] [stdout] 1175 | pub fn merge_public_cert(tsk: Cert, cert: Cert) -> Result { [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1182 | let tsk_fingerprint = tsk.primary_key().fingerprint(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1193 | let cert_fingerprint = cert.primary_key().fingerprint(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1194 | [INFO] [stdout] 1195 | Ok(if cert_fingerprint == tsk_fingerprint { [INFO] [stdout] | ________^ [INFO] [stdout] 1196 | | if cert_userid == tsk_userid { [INFO] [stdout] 1197 | | tsk.merge_public(cert)? [INFO] [stdout] 1198 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 1208 | | }); [INFO] [stdout] 1209 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sshd-openpgp-auth` (lib test) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `sshd-openpgp-auth` (lib) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "ff1dee70410452fd6931a443bb860d445e26b873ec4975ee1f90dd9b3e2f411e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff1dee70410452fd6931a443bb860d445e26b873ec4975ee1f90dd9b3e2f411e", kill_on_drop: false }` [INFO] [stdout] ff1dee70410452fd6931a443bb860d445e26b873ec4975ee1f90dd9b3e2f411e