[INFO] fetching crate sshauth 0.1.0... [INFO] checking sshauth-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sshauth 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate sshauth 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sshauth 0.1.0 [INFO] finished tweaking crates.io crate sshauth 0.1.0 [INFO] tweaked toml for crates.io crate sshauth 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 113 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding embedded-io v0.4.0 (latest: v0.6.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b28fa40127454b7231aca0e108d32e5140b18e632bae462f29af568ccb7c3d97 [INFO] running `Command { std: "docker" "start" "-a" "b28fa40127454b7231aca0e108d32e5140b18e632bae462f29af568ccb7c3d97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b28fa40127454b7231aca0e108d32e5140b18e632bae462f29af568ccb7c3d97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b28fa40127454b7231aca0e108d32e5140b18e632bae462f29af568ccb7c3d97", kill_on_drop: false }` [INFO] [stdout] b28fa40127454b7231aca0e108d32e5140b18e632bae462f29af568ccb7c3d97 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34523c55d2df4d7a0a20199d51b02228be10eed67e52eb673bbb5fee80e39ab3 [INFO] running `Command { std: "docker" "start" "-a" "34523c55d2df4d7a0a20199d51b02228be10eed67e52eb673bbb5fee80e39ab3", kill_on_drop: false }` [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking cobs v0.2.3 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking ssh-key v0.6.6 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking postcard v1.0.10 [INFO] [stderr] Checking sshauth v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signer.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 68 | sock: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | ) -> Result { [INFO] [stdout] 70 | Ok(TokenSignerBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | authsock: Some(sock.as_ref().to_string()), [INFO] [stdout] 72 | | key: None, [INFO] [stdout] 73 | | privkey: None, [INFO] [stdout] ... | [INFO] [stdout] 76 | | magic_prefix: crate::MAGIC_PREFIX_DEFAULT, [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signer.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 81 | privkey: PrivateKey, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok(TokenSignerBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | authsock: None, [INFO] [stdout] 92 | | key: None, [INFO] [stdout] 93 | | privkey: Some(privkey.clone()), [INFO] [stdout] ... | [INFO] [stdout] 96 | | magic_prefix: crate::MAGIC_PREFIX_DEFAULT, [INFO] [stdout] 97 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signer.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 170 | bail!("invalid identity name {name:?}"); [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | bail!("token must include an identity or a fingerprint"); [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let mech = if let Some(authsock) = &self.authsock { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | if self.privkey.is_some() { [INFO] [stdout] 186 | bail!("cannot provide both a private key and an SSH agent"); [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | / bail!( [INFO] [stdout] 196 | | "must call .key() to provide a public key for \ [INFO] [stdout] 197 | | SSH agent signing" [INFO] [stdout] 198 | | ); [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | bail!("cannot provide both a private key and an SSH agent"); [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | bail!("no key mechanism selected (either SSH agent or static key)"); [INFO] [stdout] | ------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Ok(TokenSigner { [INFO] [stdout] | ____________^ [INFO] [stdout] 214 | | mech, [INFO] [stdout] 215 | | identity, [INFO] [stdout] 216 | | include_fingerprint: self.include_fingerprint, [INFO] [stdout] 217 | | magic_prefix: self.magic_prefix, [INFO] [stdout] 218 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unverified.rs:230:24 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn with_key(&mut self, key: K) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | self.with_keys([key]) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sshauth` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signer.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 68 | sock: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | ) -> Result { [INFO] [stdout] 70 | Ok(TokenSignerBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | authsock: Some(sock.as_ref().to_string()), [INFO] [stdout] 72 | | key: None, [INFO] [stdout] 73 | | privkey: None, [INFO] [stdout] ... | [INFO] [stdout] 76 | | magic_prefix: crate::MAGIC_PREFIX_DEFAULT, [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signer.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 81 | privkey: PrivateKey, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok(TokenSignerBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | authsock: None, [INFO] [stdout] 92 | | key: None, [INFO] [stdout] 93 | | privkey: Some(privkey.clone()), [INFO] [stdout] ... | [INFO] [stdout] 96 | | magic_prefix: crate::MAGIC_PREFIX_DEFAULT, [INFO] [stdout] 97 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signer.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 170 | bail!("invalid identity name {name:?}"); [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | bail!("token must include an identity or a fingerprint"); [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let mech = if let Some(authsock) = &self.authsock { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | if self.privkey.is_some() { [INFO] [stdout] 186 | bail!("cannot provide both a private key and an SSH agent"); [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | / bail!( [INFO] [stdout] 196 | | "must call .key() to provide a public key for \ [INFO] [stdout] 197 | | SSH agent signing" [INFO] [stdout] 198 | | ); [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | bail!("cannot provide both a private key and an SSH agent"); [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | bail!("no key mechanism selected (either SSH agent or static key)"); [INFO] [stdout] | ------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Ok(TokenSigner { [INFO] [stdout] | ____________^ [INFO] [stdout] 214 | | mech, [INFO] [stdout] 215 | | identity, [INFO] [stdout] 216 | | include_fingerprint: self.include_fingerprint, [INFO] [stdout] 217 | | magic_prefix: self.magic_prefix, [INFO] [stdout] 218 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unverified.rs:230:24 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn with_key(&mut self, key: K) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | self.with_keys([key]) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 104 | let privkey = PrivateKey::from_openssh(privkey_str)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let pubkey = privkey.public_key().to_owned(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let pubkeyf = PublicKey::from_openssh(pubkey_str)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Ok(TestKey { id, pubkey_str, privkey_str, pubkey, privkey }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sshauth` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "34523c55d2df4d7a0a20199d51b02228be10eed67e52eb673bbb5fee80e39ab3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34523c55d2df4d7a0a20199d51b02228be10eed67e52eb673bbb5fee80e39ab3", kill_on_drop: false }` [INFO] [stdout] 34523c55d2df4d7a0a20199d51b02228be10eed67e52eb673bbb5fee80e39ab3