[INFO] fetching crate ssh-vault 1.0.13... [INFO] checking ssh-vault-1.0.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ssh-vault 1.0.13 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ssh-vault 1.0.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ssh-vault 1.0.13 [INFO] finished tweaking crates.io crate ssh-vault 1.0.13 [INFO] tweaked toml for crates.io crate ssh-vault 1.0.13 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate ssh-vault 1.0.13 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5214a2b2a0e87f2f0b51d01635b40a8264271da447e0b4273ad7963354b1d6cd [INFO] running `Command { std: "docker" "start" "-a" "5214a2b2a0e87f2f0b51d01635b40a8264271da447e0b4273ad7963354b1d6cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5214a2b2a0e87f2f0b51d01635b40a8264271da447e0b4273ad7963354b1d6cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5214a2b2a0e87f2f0b51d01635b40a8264271da447e0b4273ad7963354b1d6cd", kill_on_drop: false }` [INFO] [stdout] 5214a2b2a0e87f2f0b51d01635b40a8264271da447e0b4273ad7963354b1d6cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e99f784c8ed0bc84180465079672fa10277aa64f450b7bb90ae718bb4a66b830 [INFO] running `Command { std: "docker" "start" "-a" "e99f784c8ed0bc84180465079672fa10277aa64f450b7bb90ae718bb4a66b830", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling cc v1.0.99 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking temp-env v0.3.6 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rpassword v7.3.1 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking base58 v0.2.0 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking ssh-key v0.6.6 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking config v0.14.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking ssh-vault v1.0.13 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:18:20 [INFO] [stdout] | [INFO] [stdout] 18 | |meta| meta.modified().unwrap_or_else(|_| SystemTime::now()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 9 | let builder = Config::builder() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | match builder.build() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 29 | public: Option, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | private: Option, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | ) -> Result { [INFO] [stdout] 32 | let vault = match key_type { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Self { vault }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/dio.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 92 | let input = InputSource::new(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let output = OutputDestination::new(output)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | Ok((input, output)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/find.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(anyhow::anyhow!("No key found")); [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | PublicKey::read_openssh_file(&key).context("Ensure you are passing a valid openssh public key") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/find.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | PrivateKey::from_openssh(private_key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/ssh/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 11 | password: Option>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | ) -> Result { [INFO] [stdout] 13 | let password = match password { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Some(password) => password, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | key.decrypt(password.expose_secret()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/ssh/ed25519.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 23 | fn new(public: Option, private: Option) -> Result { [INFO] [stdout] | ------------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | match (public, private) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/ssh/rsa.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 19 | fn new(public: Option, private: Option) -> Result { [INFO] [stdout] | ------------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | match (public, private) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssh-vault` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:18:20 [INFO] [stdout] | [INFO] [stdout] 18 | |meta| meta.modified().unwrap_or_else(|_| SystemTime::now()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 9 | let builder = Config::builder() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | match builder.build() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/mod.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 29 | public: Option, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | private: Option, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | ) -> Result { [INFO] [stdout] 32 | let vault = match key_type { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Self { vault }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/dio.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 92 | let input = InputSource::new(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let output = OutputDestination::new(output)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | Ok((input, output)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/find.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(anyhow::anyhow!("No key found")); [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | PublicKey::read_openssh_file(&key).context("Ensure you are passing a valid openssh public key") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/find.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | PrivateKey::from_openssh(private_key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/ssh/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 11 | password: Option>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | ) -> Result { [INFO] [stdout] 13 | let password = match password { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Some(password) => password, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | key.decrypt(password.expose_secret()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/ssh/ed25519.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 23 | fn new(public: Option, private: Option) -> Result { [INFO] [stdout] | ------------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | match (public, private) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vault/ssh/rsa.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 19 | fn new(public: Option, private: Option) -> Result { [INFO] [stdout] | ------------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | match (public, private) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssh-vault` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "e99f784c8ed0bc84180465079672fa10277aa64f450b7bb90ae718bb4a66b830", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e99f784c8ed0bc84180465079672fa10277aa64f450b7bb90ae718bb4a66b830", kill_on_drop: false }` [INFO] [stdout] e99f784c8ed0bc84180465079672fa10277aa64f450b7bb90ae718bb4a66b830