[INFO] fetching crate ssh-rs 0.5.0... [INFO] checking ssh-rs-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ssh-rs 0.5.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ssh-rs 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ssh-rs 0.5.0 [INFO] finished tweaking crates.io crate ssh-rs 0.5.0 [INFO] tweaked toml for crates.io crate ssh-rs 0.5.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 130 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding strum v0.25.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.25.3 (latest: v0.26.4) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9765d695dd712a947cc2d832544f363a2edef4270dc368ec46ac860b793a20e [INFO] running `Command { std: "docker" "start" "-a" "b9765d695dd712a947cc2d832544f363a2edef4270dc368ec46ac860b793a20e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9765d695dd712a947cc2d832544f363a2edef4270dc368ec46ac860b793a20e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9765d695dd712a947cc2d832544f363a2edef4270dc368ec46ac860b793a20e", kill_on_drop: false }` [INFO] [stdout] b9765d695dd712a947cc2d832544f363a2edef4270dc368ec46ac860b793a20e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d6461a6ad487c0bb51153c6a8ec4c69e97a37dedbb0ce16975c51e2281bd0d9 [INFO] running `Command { std: "docker" "start" "-a" "4d6461a6ad487c0bb51153c6a8ec4c69e97a37dedbb0ce16975c51e2281bd0d9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling ssh-rs v0.5.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking ssh-key v0.6.6 [INFO] [stdout] warning: method `iv_size` is never used [INFO] [stdout] --> src/algorithm/encryption/mod.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) trait Encryption: Send + Sync { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 16 | fn bsize(&self) -> usize; [INFO] [stdout] 17 | fn iv_size(&self) -> usize; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `IV_SIZE` is never used [INFO] [stdout] --> src/algorithm/encryption/chacha20_poly1305_openssh.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const IV_SIZE: usize = 0; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/channel/local/channel.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | Code(u8), [INFO] [stdout] | ---- ^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 20 | Code(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm/encryption/aes_ctr.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 53 | fn new(hash: Hash, mac: Box) -> Self [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let c = $alg::new(&ckey.into(), &civ.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let r = $alg::new(&skey.into(), &siv.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | extend: Extend::from(mac, ik_c_s, ik_s_c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 135 | crate_aes_ctr!(Ctr128, Aes128Ctr64BE, CTR128_KEY_SIZE); [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `crate_aes_ctr` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm/encryption/aes_ctr.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 53 | fn new(hash: Hash, mac: Box) -> Self [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let c = $alg::new(&ckey.into(), &civ.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let r = $alg::new(&skey.into(), &siv.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | extend: Extend::from(mac, ik_c_s, ik_s_c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 137 | crate_aes_ctr!(Ctr192, Aes192Ctr64BE, CTR192_KEY_SIZE); [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate_aes_ctr` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm/encryption/aes_ctr.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 53 | fn new(hash: Hash, mac: Box) -> Self [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let c = $alg::new(&ckey.into(), &civ.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let r = $alg::new(&skey.into(), &siv.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | extend: Extend::from(mac, ik_c_s, ik_s_c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 139 | crate_aes_ctr!(Ctr256, Aes256Ctr64BE, CTR256_KEY_SIZE); [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate_aes_ctr` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/backend/channel.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 35 | snd: Sender, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | snd, [INFO] [stdout] 41 | | server_channel_no, [INFO] [stdout] 42 | | client_channel_no, [INFO] [stdout] ... | [INFO] [stdout] 46 | | pending_send: vec![], [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/backend/channel.rs:259:12 [INFO] [stdout] | [INFO] [stdout] 258 | pub fn exec(self) -> SshResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | Ok(ExecBroker::open(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/local/channel.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn exec(self) -> SshResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | info!("exec opened."); [INFO] [stdout] 66 | Ok(ChannelExec::open(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/mod.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 292 | pub fn connect_bio(mut self, stream: S) -> SshResult> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | / SessionConnector { [INFO] [stdout] 298 | | inner: SessionState::Init(self.config, stream), [INFO] [stdout] 299 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/session_broker.rs:44:26 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(client: Client, stream: S) -> Self [INFO] [stdout] | -------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let (rqst_snd, rqst_rcv) = mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | channel_num: Arc::new(Mutex::new(U32Iter::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/session_local.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(client: Client, stream: S) -> Self { [INFO] [stdout] | -------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self { [INFO] [stdout] 35 | client: Rc::new(RefCell::new(client)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/session_local.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(client: Client, stream: S) -> Self { [INFO] [stdout] | -------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | stream: Rc::new(RefCell::new(stream)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/session_local.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 100 | Ok(LocalChannel::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | server_channel_no, [INFO] [stdout] 102 | | client_channel_no, [INFO] [stdout] 103 | | remote_window_size, [INFO] [stdout] 104 | | self.client.clone(), [INFO] [stdout] 105 | | self.stream.clone(), [INFO] [stdout] 106 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssh-rs` (lib) due to 12 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `iv_size` is never used [INFO] [stdout] --> src/algorithm/encryption/mod.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) trait Encryption: Send + Sync { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 16 | fn bsize(&self) -> usize; [INFO] [stdout] 17 | fn iv_size(&self) -> usize; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `IV_SIZE` is never used [INFO] [stdout] --> src/algorithm/encryption/chacha20_poly1305_openssh.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const IV_SIZE: usize = 0; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/channel/local/channel.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | Code(u8), [INFO] [stdout] | ---- ^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 20 | Code(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm/encryption/aes_ctr.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 53 | fn new(hash: Hash, mac: Box) -> Self [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let c = $alg::new(&ckey.into(), &civ.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let r = $alg::new(&skey.into(), &siv.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | extend: Extend::from(mac, ik_c_s, ik_s_c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 135 | crate_aes_ctr!(Ctr128, Aes128Ctr64BE, CTR128_KEY_SIZE); [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `crate_aes_ctr` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm/encryption/aes_ctr.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 53 | fn new(hash: Hash, mac: Box) -> Self [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let c = $alg::new(&ckey.into(), &civ.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let r = $alg::new(&skey.into(), &siv.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | extend: Extend::from(mac, ik_c_s, ik_s_c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 137 | crate_aes_ctr!(Ctr192, Aes192Ctr64BE, CTR192_KEY_SIZE); [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate_aes_ctr` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm/encryption/aes_ctr.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 53 | fn new(hash: Hash, mac: Box) -> Self [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let c = $alg::new(&ckey.into(), &civ.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let r = $alg::new(&skey.into(), &siv.into()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | extend: Extend::from(mac, ik_c_s, ik_s_c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 139 | crate_aes_ctr!(Ctr256, Aes256Ctr64BE, CTR256_KEY_SIZE); [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate_aes_ctr` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/backend/channel.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 35 | snd: Sender, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | snd, [INFO] [stdout] 41 | | server_channel_no, [INFO] [stdout] 42 | | client_channel_no, [INFO] [stdout] ... | [INFO] [stdout] 46 | | pending_send: vec![], [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/backend/channel.rs:259:12 [INFO] [stdout] | [INFO] [stdout] 258 | pub fn exec(self) -> SshResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | Ok(ExecBroker::open(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/local/channel.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn exec(self) -> SshResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | info!("exec opened."); [INFO] [stdout] 66 | Ok(ChannelExec::open(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/mod.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 292 | pub fn connect_bio(mut self, stream: S) -> SshResult> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | / SessionConnector { [INFO] [stdout] 298 | | inner: SessionState::Init(self.config, stream), [INFO] [stdout] 299 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/session_broker.rs:44:26 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(client: Client, stream: S) -> Self [INFO] [stdout] | -------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let (rqst_snd, rqst_rcv) = mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | channel_num: Arc::new(Mutex::new(U32Iter::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/session_local.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(client: Client, stream: S) -> Self { [INFO] [stdout] | -------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self { [INFO] [stdout] 35 | client: Rc::new(RefCell::new(client)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/session_local.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(client: Client, stream: S) -> Self { [INFO] [stdout] | -------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | stream: Rc::new(RefCell::new(stream)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/session_local.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 100 | Ok(LocalChannel::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | server_channel_no, [INFO] [stdout] 102 | | client_channel_no, [INFO] [stdout] 103 | | remote_window_size, [INFO] [stdout] 104 | | self.client.clone(), [INFO] [stdout] 105 | | self.stream.clone(), [INFO] [stdout] 106 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssh-rs` (lib test) due to 12 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4d6461a6ad487c0bb51153c6a8ec4c69e97a37dedbb0ce16975c51e2281bd0d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d6461a6ad487c0bb51153c6a8ec4c69e97a37dedbb0ce16975c51e2281bd0d9", kill_on_drop: false }` [INFO] [stdout] 4d6461a6ad487c0bb51153c6a8ec4c69e97a37dedbb0ce16975c51e2281bd0d9