[INFO] fetching crate ssh-key-dir 0.1.4... [INFO] checking ssh-key-dir-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ssh-key-dir 0.1.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ssh-key-dir 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ssh-key-dir 0.1.4 [INFO] finished tweaking crates.io crate ssh-key-dir 0.1.4 [INFO] tweaked toml for crates.io crate ssh-key-dir 0.1.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate ssh-key-dir 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bc99b3a01afbd24298d1d266588d1b2484698ce660b04e0df6f8f5660be8cf16 [INFO] running `Command { std: "docker" "start" "-a" "bc99b3a01afbd24298d1d266588d1b2484698ce660b04e0df6f8f5660be8cf16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bc99b3a01afbd24298d1d266588d1b2484698ce660b04e0df6f8f5660be8cf16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc99b3a01afbd24298d1d266588d1b2484698ce660b04e0df6f8f5660be8cf16", kill_on_drop: false }` [INFO] [stdout] bc99b3a01afbd24298d1d266588d1b2484698ce660b04e0df6f8f5660be8cf16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 631d2cd92082426b64b734731499ca149baa299b3af6262d023e7ee6798c0c4c [INFO] running `Command { std: "docker" "start" "-a" "631d2cd92082426b64b734731499ca149baa299b3af6262d023e7ee6798c0c4c", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.131 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling anyhow v1.0.65 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking textwrap v0.15.1 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking clap_lex v0.2.2 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking clap v3.2.22 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking nix v0.25.0 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking ssh-key-dir v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 60 | let user = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | get_user_by_name(username).with_context(|| format!("no such user {:?}", username))?; [INFO] [stdout] 62 | let guard = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | switch_user_group(user.uid(), user.primary_group_id()).context("couldn't switch user")?; [INFO] [stdout] 64 | Ok((user, guard)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keys.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 98 | ent: io::Result, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let ent = ent.with_context(|| format!("reading {}", dir_path.display()))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let result = copy(&mut file, out).with_context(|| format!("copying {}", ent.path().display())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | / result [INFO] [stdout] 134 | | .and(out.write_all(&[b'\n', b'\n']).context("writing newlines")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssh-key-dir` (bin "ssh-key-dir") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "631d2cd92082426b64b734731499ca149baa299b3af6262d023e7ee6798c0c4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "631d2cd92082426b64b734731499ca149baa299b3af6262d023e7ee6798c0c4c", kill_on_drop: false }` [INFO] [stdout] 631d2cd92082426b64b734731499ca149baa299b3af6262d023e7ee6798c0c4c