[INFO] fetching crate ssbh_write_derive 0.19.0... [INFO] checking ssbh_write_derive-0.19.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ssbh_write_derive 0.19.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ssbh_write_derive 0.19.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ssbh_write_derive 0.19.0 [INFO] finished tweaking crates.io crate ssbh_write_derive 0.19.0 [INFO] tweaked toml for crates.io crate ssbh_write_derive 0.19.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b18b8f04afed8ecac944a1b957cbc34c240f52130e6b813ed441819accbf83f [INFO] running `Command { std: "docker" "start" "-a" "1b18b8f04afed8ecac944a1b957cbc34c240f52130e6b813ed441819accbf83f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b18b8f04afed8ecac944a1b957cbc34c240f52130e6b813ed441819accbf83f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b18b8f04afed8ecac944a1b957cbc34c240f52130e6b813ed441819accbf83f", kill_on_drop: false }` [INFO] [stdout] 1b18b8f04afed8ecac944a1b957cbc34c240f52130e6b813ed441819accbf83f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc2139a0b94d532a53fec95f3c5ec50bc753274681f1235e43459f2252dc8271 [INFO] running `Command { std: "docker" "start" "-a" "bc2139a0b94d532a53fec95f3c5ec50bc753274681f1235e43459f2252dc8271", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Checking ssbh_write_derive v0.19.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 37 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | parenthesized!(content in input); [INFO] [stdout] 39 | let value = content.parse()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | Ok(Self { value }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 120 | let write_variants: Vec<_> = data_enum [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let write_variants = quote! { [INFO] [stdout] | _________--------------___- [INFO] [stdout] | |_________|________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | | match self { [INFO] [stdout] 160 | | #( [INFO] [stdout] 161 | | #write_variants [INFO] [stdout] 162 | | ),* [INFO] [stdout] 163 | | } [INFO] [stdout] 164 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | [INFO] [stdout] 166 | | let add_variants: Vec<_> = data_enum [INFO] [stdout] | | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 199 | let add_variants = quote! { [INFO] [stdout] | _________------------___- [INFO] [stdout] | |_________|______________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | | size += match self { [INFO] [stdout] 201 | | #( [INFO] [stdout] 202 | | #add_variants [INFO] [stdout] 203 | | ),* [INFO] [stdout] 204 | | }; [INFO] [stdout] 205 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | / generate_size_calculation( [INFO] [stdout] 210 | add_variants, [INFO] [stdout] 211 | write_options.pad_after, [INFO] [stdout] 212 | write_options.magic.clone(), [INFO] [stdout] 213 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 222 | let add_fields = size_unnamed_fields(fields, true); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | let write_fields = write_unnamed_fields(fields, true); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | / generate_size_calculation( [INFO] [stdout] 228 | | quote! { [INFO] [stdout] 229 | | size += ( #(#add_fields)+* ); [INFO] [stdout] 230 | | }, [INFO] [stdout] 231 | | write_options.pad_after, [INFO] [stdout] 232 | | write_options.magic.clone(), [INFO] [stdout] 233 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 241 | let write_fields = write_named_fields(fields, true); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | let write_magic = if let Some(magic) = &write_options.magic { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | quote! { #magic.ssbh_write(writer, data_ptr)?; } [INFO] [stdout] | ------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let write_fields = quote! { [INFO] [stdout] | _________------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | | #write_magic [INFO] [stdout] 252 | | #(#write_fields)*; [INFO] [stdout] 253 | | }; [INFO] [stdout] | |_____- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | [INFO] [stdout] 255 | let add_fields = size_named_fields(fields, true); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | / generate_size_calculation( [INFO] [stdout] 260 | | quote! { [INFO] [stdout] 261 | | size += ( #(#add_fields)+* ); [INFO] [stdout] 262 | | }, [INFO] [stdout] 263 | | write_options.pad_after, [INFO] [stdout] 264 | | write_options.magic.clone(), [INFO] [stdout] 265 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssbh_write_derive` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 37 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | parenthesized!(content in input); [INFO] [stdout] 39 | let value = content.parse()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | Ok(Self { value }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 120 | let write_variants: Vec<_> = data_enum [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let write_variants = quote! { [INFO] [stdout] | _________--------------___- [INFO] [stdout] | |_________|________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | | match self { [INFO] [stdout] 160 | | #( [INFO] [stdout] 161 | | #write_variants [INFO] [stdout] 162 | | ),* [INFO] [stdout] 163 | | } [INFO] [stdout] 164 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | [INFO] [stdout] 166 | | let add_variants: Vec<_> = data_enum [INFO] [stdout] | | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 199 | let add_variants = quote! { [INFO] [stdout] | _________------------___- [INFO] [stdout] | |_________|______________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | | size += match self { [INFO] [stdout] 201 | | #( [INFO] [stdout] 202 | | #add_variants [INFO] [stdout] 203 | | ),* [INFO] [stdout] 204 | | }; [INFO] [stdout] 205 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | / generate_size_calculation( [INFO] [stdout] 210 | add_variants, [INFO] [stdout] 211 | write_options.pad_after, [INFO] [stdout] 212 | write_options.magic.clone(), [INFO] [stdout] 213 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 222 | let add_fields = size_unnamed_fields(fields, true); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | let write_fields = write_unnamed_fields(fields, true); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | / generate_size_calculation( [INFO] [stdout] 228 | | quote! { [INFO] [stdout] 229 | | size += ( #(#add_fields)+* ); [INFO] [stdout] 230 | | }, [INFO] [stdout] 231 | | write_options.pad_after, [INFO] [stdout] 232 | | write_options.magic.clone(), [INFO] [stdout] 233 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 241 | let write_fields = write_named_fields(fields, true); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | let write_magic = if let Some(magic) = &write_options.magic { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | quote! { #magic.ssbh_write(writer, data_ptr)?; } [INFO] [stdout] | ------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let write_fields = quote! { [INFO] [stdout] | _________------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | | #write_magic [INFO] [stdout] 252 | | #(#write_fields)*; [INFO] [stdout] 253 | | }; [INFO] [stdout] | |_____- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | [INFO] [stdout] 255 | let add_fields = size_named_fields(fields, true); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | / generate_size_calculation( [INFO] [stdout] 260 | | quote! { [INFO] [stdout] 261 | | size += ( #(#add_fields)+* ); [INFO] [stdout] 262 | | }, [INFO] [stdout] 263 | | write_options.pad_after, [INFO] [stdout] 264 | | write_options.magic.clone(), [INFO] [stdout] 265 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssbh_write_derive` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bc2139a0b94d532a53fec95f3c5ec50bc753274681f1235e43459f2252dc8271", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc2139a0b94d532a53fec95f3c5ec50bc753274681f1235e43459f2252dc8271", kill_on_drop: false }` [INFO] [stdout] bc2139a0b94d532a53fec95f3c5ec50bc753274681f1235e43459f2252dc8271