[INFO] fetching crate ssb-verify-signatures 1.1.1... [INFO] checking ssb-verify-signatures-1.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ssb-verify-signatures 1.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ssb-verify-signatures 1.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ssb-verify-signatures 1.1.1 [INFO] finished tweaking crates.io crate ssb-verify-signatures 1.1.1 [INFO] tweaked toml for crates.io crate ssb-verify-signatures 1.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 130 packages to latest compatible versions [INFO] [stderr] Adding aead v0.3.2 (latest: v0.5.2) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding cipher v0.2.5 (latest: v0.4.4) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cpuid-bool v0.2.0 (latest: v0.99.99) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding crypto-mac v0.10.1 (latest: v0.11.1) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (latest: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hmac v0.10.1 (latest: v0.12.1) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding merlin v2.0.1 (latest: v3.0.0) [INFO] [stderr] Adding poly1305 v0.6.2 (latest: v0.8.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding salsa20 v0.7.2 (latest: v0.10.2) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding snafu v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding subtle v2.4.1 (latest: v2.6.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding universal-hash v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding x25519-dalek v1.2.0 (latest: v2.0.1) [INFO] [stderr] Adding xsalsa20poly1305 v0.6.0 (latest: v0.9.1) [INFO] [stderr] Adding zerocopy v0.3.2 (latest: v0.7.35) [INFO] [stderr] Adding zerocopy-derive v0.2.0 (latest: v0.7.35) [INFO] [stderr] Adding zeroize v1.3.0 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 48c1a3e89d5b084f0de075595315b5cddb1702fdb6f5d75e3e09e2290382572f [INFO] running `Command { std: "docker" "start" "-a" "48c1a3e89d5b084f0de075595315b5cddb1702fdb6f5d75e3e09e2290382572f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "48c1a3e89d5b084f0de075595315b5cddb1702fdb6f5d75e3e09e2290382572f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48c1a3e89d5b084f0de075595315b5cddb1702fdb6f5d75e3e09e2290382572f", kill_on_drop: false }` [INFO] [stdout] 48c1a3e89d5b084f0de075595315b5cddb1702fdb6f5d75e3e09e2290382572f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0c9b6349271c7fe122940860a4766c252ae15d06df9be28ae3fb3d266f7ce49b [INFO] running `Command { std: "docker" "start" "-a" "0c9b6349271c7fe122940860a4766c252ae15d06df9be28ae3fb3d266f7ce49b", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking cpuid-bool v0.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Compiling ryu-ecmascript v0.1.1 [INFO] [stderr] Checking cipher v0.2.5 [INFO] [stderr] Checking aead v0.3.2 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking crypto-mac v0.10.1 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking strtod2 v0.0.1 [INFO] [stderr] Checking hmac v0.10.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking poly1305 v0.6.2 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling zerocopy-derive v0.2.0 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking zerocopy v0.3.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking salsa20 v0.7.2 [INFO] [stderr] Checking merlin v2.0.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking xsalsa20poly1305 v0.6.0 [INFO] [stderr] Checking x25519-dalek v1.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking ssb-legacy-msg-data v0.1.4 [INFO] [stderr] Checking ssb-crypto v0.2.3 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ssb-verify-signatures v1.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stdout] warning: use of deprecated associated function `ed25519_dalek::Signature::new`: use ed25519::Signature::from_bytes instead [INFO] [stdout] --> src/lib.rs:391:26 [INFO] [stdout] | [INFO] [stdout] 391 | let sig = Signature::new(sig_bytes); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn verify_message>(msg: T) -> Result<()> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let (key, sig, bytes) = get_pubkey_sig_bytes_from_ssb_message(msg.as_ref())?; [INFO] [stdout] 117 | key.verify(&bytes, &sig) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssb-verify-signatures` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0c9b6349271c7fe122940860a4766c252ae15d06df9be28ae3fb3d266f7ce49b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c9b6349271c7fe122940860a4766c252ae15d06df9be28ae3fb3d266f7ce49b", kill_on_drop: false }` [INFO] [stdout] 0c9b6349271c7fe122940860a4766c252ae15d06df9be28ae3fb3d266f7ce49b