[INFO] fetching crate ssb-packetstream 0.2.1... [INFO] checking ssb-packetstream-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ssb-packetstream 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ssb-packetstream 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ssb-packetstream 0.2.1 [INFO] finished tweaking crates.io crate ssb-packetstream 0.2.1 [INFO] tweaked toml for crates.io crate ssb-packetstream 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding pin-project v0.4.30 (latest: v1.1.5) [INFO] [stderr] Adding pin-project-internal v0.4.30 (latest: v1.1.5) [INFO] [stderr] Adding snafu v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 038b96f7abd0ba17ca922970912e88955edf1ce6c469f119f0be2f63abce1621 [INFO] running `Command { std: "docker" "start" "-a" "038b96f7abd0ba17ca922970912e88955edf1ce6c469f119f0be2f63abce1621", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "038b96f7abd0ba17ca922970912e88955edf1ce6c469f119f0be2f63abce1621", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "038b96f7abd0ba17ca922970912e88955edf1ce6c469f119f0be2f63abce1621", kill_on_drop: false }` [INFO] [stdout] 038b96f7abd0ba17ca922970912e88955edf1ce6c469f119f0be2f63abce1621 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba1100d6955803ef7372a6580f614b58fbfafeba371e5e915531bd02d4255f6b [INFO] running `Command { std: "docker" "start" "-a" "ba1100d6955803ef7372a6580f614b58fbfafeba371e5e915531bd02d4255f6b", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling pin-project-internal v0.4.30 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking async-ringbuffer v0.5.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Checking pin-project v0.4.30 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking ssb-packetstream v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use sink::*; [INFO] [stdout] | ^^^^^^^ the name `Error` in the type namespace is first re-exported here [INFO] [stdout] 8 | pub use stream::*; [INFO] [stdout] | --------- but the name `Error` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use sink::*; [INFO] [stdout] | ^^^^^^^ the name `Error` in the type namespace is first re-exported here [INFO] [stdout] 8 | pub use stream::*; [INFO] [stdout] | --------- but the name `Error` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mux.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 217 | w: W, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let (shared_sender, recv) = channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let out_done = async move { [INFO] [stdout] 228 | / recv.map(Ok) [INFO] [stdout] 229 | | .forward(PacketSink::new(w)) [INFO] [stdout] 230 | | .await [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sink.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(w: W) -> PacketSink { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | PacketSink { [INFO] [stdout] 76 | state: State::Ready(w), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sink.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn into_inner(mut self) -> W { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | match self.state.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:101:20 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn new(r: R) -> PacketStream { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | PacketStream { [INFO] [stdout] 101 | state: State::Ready(r), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn into_inner(mut self) -> R { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | match self.state.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssb-packetstream` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mux.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 217 | w: W, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let (shared_sender, recv) = channel(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let out_done = async move { [INFO] [stdout] 228 | / recv.map(Ok) [INFO] [stdout] 229 | | .forward(PacketSink::new(w)) [INFO] [stdout] 230 | | .await [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mux.rs:332:35 [INFO] [stdout] | [INFO] [stdout] 330 | mut out: ChildSender, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | inn: Option, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | ) -> Result<(), RpcError> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 333 | | let (method, args) = p.body.split_first().unwrap(); [INFO] [stdout] 334 | | [INFO] [stdout] 335 | | match *method as char { [INFO] [stdout] ... | [INFO] [stdout] 360 | | } [INFO] [stdout] 361 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sink.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(w: W) -> PacketSink { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | PacketSink { [INFO] [stdout] 76 | state: State::Ready(w), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sink.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn into_inner(mut self) -> W { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | match self.state.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:101:20 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn new(r: R) -> PacketStream { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | PacketStream { [INFO] [stdout] 101 | state: State::Ready(r), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn into_inner(mut self) -> R { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | match self.state.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:63 [INFO] [stdout] | [INFO] [stdout] 91 | let send = async { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let recv = async { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let (_, received) = block_on(async { join(send, recv).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssb-packetstream` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ba1100d6955803ef7372a6580f614b58fbfafeba371e5e915531bd02d4255f6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba1100d6955803ef7372a6580f614b58fbfafeba371e5e915531bd02d4255f6b", kill_on_drop: false }` [INFO] [stdout] ba1100d6955803ef7372a6580f614b58fbfafeba371e5e915531bd02d4255f6b