[INFO] fetching crate ssb-db 0.1.7... [INFO] checking ssb-db-0.1.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ssb-db 0.1.7 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ssb-db 0.1.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ssb-db 0.1.7 [INFO] finished tweaking crates.io crate ssb-db 0.1.7 [INFO] tweaked toml for crates.io crate ssb-db 0.1.7 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 136 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding aead v0.3.2 (latest: v0.5.2) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding cipher v0.2.5 (latest: v0.4.4) [INFO] [stderr] Adding cpuid-bool v0.2.0 (latest: v0.99.99) [INFO] [stderr] Adding crypto-mac v0.10.1 (latest: v0.11.1) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (latest: v4.1.3) [INFO] [stderr] Adding diesel v1.4.8 (latest: v2.2.3) [INFO] [stderr] Adding diesel_derives v1.4.1 (latest: v2.2.3) [INFO] [stderr] Adding diesel_migrations v1.4.0 (latest: v2.2.0) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding env_logger v0.6.2 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hmac v0.10.1 (latest: v0.12.1) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding libsqlite3-sys v0.16.0 (latest: v0.30.1) [INFO] [stderr] Adding migrations_internals v1.4.1 (latest: v2.2.0) [INFO] [stderr] Adding migrations_macros v1.4.2 (latest: v2.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding poly1305 v0.6.2 (latest: v0.8.0) [INFO] [stderr] Adding pretty_env_logger v0.3.1 (latest: v0.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding salsa20 v0.7.2 (latest: v0.10.2) [INFO] [stderr] Adding serde_cbor v0.10.2 (latest: v0.11.2) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding snafu v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding subtle v2.4.1 (latest: v2.6.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding universal-hash v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding x25519-dalek v1.2.0 (latest: v2.0.1) [INFO] [stderr] Adding xsalsa20poly1305 v0.6.0 (latest: v0.9.1) [INFO] [stderr] Adding zerocopy v0.3.2 (latest: v0.7.35) [INFO] [stderr] Adding zerocopy-derive v0.2.0 (latest: v0.7.35) [INFO] [stderr] Adding zeroize v1.3.0 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d64ad5756d4975db829db1b1a1dc1feb7d303a262bcf4b33640b9c968deac03d [INFO] running `Command { std: "docker" "start" "-a" "d64ad5756d4975db829db1b1a1dc1feb7d303a262bcf4b33640b9c968deac03d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d64ad5756d4975db829db1b1a1dc1feb7d303a262bcf4b33640b9c968deac03d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d64ad5756d4975db829db1b1a1dc1feb7d303a262bcf4b33640b9c968deac03d", kill_on_drop: false }` [INFO] [stdout] d64ad5756d4975db829db1b1a1dc1feb7d303a262bcf4b33640b9c968deac03d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d40310001c5ebe112f06777aa935810234bbafd097a0642bcedfea8ebf91ffe8 [INFO] running `Command { std: "docker" "start" "-a" "d40310001c5ebe112f06777aa935810234bbafd097a0642bcedfea8ebf91ffe8", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Compiling libsqlite3-sys v0.16.0 [INFO] [stderr] Checking cpuid-bool v0.2.0 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling ryu-ecmascript v0.1.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking buffered_offset_reader v0.6.0 [INFO] [stderr] Checking serde_cbor v0.10.2 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking cipher v0.2.5 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking crypto-mac v0.10.1 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking aead v0.3.2 [INFO] [stderr] Checking hmac v0.10.1 [INFO] [stderr] Checking poly1305 v0.6.2 [INFO] [stderr] Checking strtod2 v0.0.1 [INFO] [stderr] Checking bidir_iter v0.2.1 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking salsa20 v0.7.2 [INFO] [stderr] Checking xsalsa20poly1305 v0.6.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking x25519-dalek v1.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ssb-legacy-msg-data v0.1.4 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking pretty_env_logger v0.3.1 [INFO] [stderr] Compiling diesel_derives v1.4.1 [INFO] [stderr] Compiling zerocopy-derive v0.2.0 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking zerocopy v0.3.2 [INFO] [stderr] Checking ssb-crypto v0.2.3 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking ssb-multiformats v0.4.2 [INFO] [stderr] Checking flumedb v0.1.6 [INFO] [stderr] Checking diesel v1.4.8 [INFO] [stderr] Checking migrations_internals v1.4.1 [INFO] [stderr] Compiling migrations_macros v1.4.2 [INFO] [stderr] Checking diesel_migrations v1.4.0 [INFO] [stderr] Checking ssb-db v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/models/authors.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 23 | .or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | / authors_table [INFO] [stdout] 29 | | .select(authors_id) [INFO] [stdout] 30 | | .order(authors_id.desc()) [INFO] [stdout] 31 | | .first::>(connection) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/models/keys.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 21 | .or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / keys_table [INFO] [stdout] 27 | | .select(keys_id_row) [INFO] [stdout] 28 | | .order(keys_id_row.desc()) [INFO] [stdout] 29 | | .first::>(connection) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/db/models/messages.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 62 | .filter(keys_key.eq(key.clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/db/models/messages.rs:88:41 [INFO] [stdout] | [INFO] [stdout] 88 | .filter(authors_author.eq(author.clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/db/models/messages.rs:101:41 [INFO] [stdout] | [INFO] [stdout] 101 | .filter(authors_author.eq(author.clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/models/authors.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 23 | .or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | / authors_table [INFO] [stdout] 29 | | .select(authors_id) [INFO] [stdout] 30 | | .order(authors_id.desc()) [INFO] [stdout] 31 | | .first::>(connection) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/models/keys.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 21 | .or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / keys_table [INFO] [stdout] 27 | | .select(keys_id_row) [INFO] [stdout] 28 | | .order(keys_id_row.desc()) [INFO] [stdout] 29 | | .first::>(connection) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new>(database_path: S, offset_log_path: S) -> SqliteSsbDb { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let connection = setup_connection(database_path.as_ref()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | let offset_log = match OffsetLog::new(&offset_log_path.as_ref()) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(log) => log, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | connection: RefCell::new(connection), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new>(database_path: S, offset_log_path: S) -> SqliteSsbDb { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let connection = setup_connection(database_path.as_ref()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | let offset_log = match OffsetLog::new(&offset_log_path.as_ref()) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(log) => log, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | offset_log: RefCell::new(offset_log), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 56 | let connection = self.connection.borrow_mut(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let offset_log = self.offset_log.borrow(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / offset_log [INFO] [stdout] 71 | | .iter_at_offset(starting_offset) [INFO] [stdout] 72 | | .skip(num_to_skip) [INFO] [stdout] 73 | | .chunks(10000) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|chunk| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | / connection [INFO] [stdout] 77 | | .transaction::<_, db::Error, _>(|| { [INFO] [stdout] 78 | | chunk [INFO] [stdout] 79 | | .map(|log_entry| { [INFO] [stdout] ... | [INFO] [stdout] 85 | | }) [INFO] [stdout] 86 | | .map_err(|_| Error::SqliteAppendError {}) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/db/models/messages.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 62 | .filter(keys_key.eq(key.clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|chunk| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / chunk [INFO] [stdout] 79 | | .map(|log_entry| { [INFO] [stdout] 80 | | append_item(&connection, log_entry.offset, &log_entry.data)?; [INFO] [stdout] ... | [INFO] [stdout] 83 | | }) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/db/models/messages.rs:88:41 [INFO] [stdout] | [INFO] [stdout] 88 | .filter(authors_author.eq(author.clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | / self.offset_log [INFO] [stdout] 110 | | .borrow() [INFO] [stdout] 111 | | .get(flume_seq) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/db/models/messages.rs:101:41 [INFO] [stdout] | [INFO] [stdout] 101 | .filter(authors_author.eq(author.clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / flume_seq [INFO] [stdout] 124 | | .map(|flume_seq| { [INFO] [stdout] 125 | | self.offset_log [INFO] [stdout] 126 | | .borrow() [INFO] [stdout] 127 | | .get(flume_seq as u64) [INFO] [stdout] 128 | | .map_err(|_| Error::OffsetGetError {}) [INFO] [stdout] 129 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new>(database_path: S, offset_log_path: S) -> SqliteSsbDb { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let connection = setup_connection(database_path.as_ref()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | let offset_log = match OffsetLog::new(&offset_log_path.as_ref()) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(log) => log, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | connection: RefCell::new(connection), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new>(database_path: S, offset_log_path: S) -> SqliteSsbDb { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let connection = setup_connection(database_path.as_ref()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | [INFO] [stdout] 37 | let offset_log = match OffsetLog::new(&offset_log_path.as_ref()) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(log) => log, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | offset_log: RefCell::new(offset_log), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 56 | let connection = self.connection.borrow_mut(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let offset_log = self.offset_log.borrow(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / offset_log [INFO] [stdout] 71 | | .iter_at_offset(starting_offset) [INFO] [stdout] 72 | | .skip(num_to_skip) [INFO] [stdout] 73 | | .chunks(10000) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|chunk| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | / connection [INFO] [stdout] 77 | | .transaction::<_, db::Error, _>(|| { [INFO] [stdout] 78 | | chunk [INFO] [stdout] 79 | | .map(|log_entry| { [INFO] [stdout] ... | [INFO] [stdout] 85 | | }) [INFO] [stdout] 86 | | .map_err(|_| Error::SqliteAppendError {}) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|chunk| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / chunk [INFO] [stdout] 79 | | .map(|log_entry| { [INFO] [stdout] 80 | | append_item(&connection, log_entry.offset, &log_entry.data)?; [INFO] [stdout] ... | [INFO] [stdout] 83 | | }) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | / self.offset_log [INFO] [stdout] 110 | | .borrow() [INFO] [stdout] 111 | | .get(flume_seq) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite_ssb_db/mod.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / flume_seq [INFO] [stdout] 124 | | .map(|flume_seq| { [INFO] [stdout] 125 | | self.offset_log [INFO] [stdout] 126 | | .borrow() [INFO] [stdout] 127 | | .get(flume_seq as u64) [INFO] [stdout] 128 | | .map_err(|_| Error::OffsetGetError {}) [INFO] [stdout] 129 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssb-db` (lib) due to 10 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ssb-db` (lib test) due to 10 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d40310001c5ebe112f06777aa935810234bbafd097a0642bcedfea8ebf91ffe8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d40310001c5ebe112f06777aa935810234bbafd097a0642bcedfea8ebf91ffe8", kill_on_drop: false }` [INFO] [stdout] d40310001c5ebe112f06777aa935810234bbafd097a0642bcedfea8ebf91ffe8